Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Aug 17 09:32
    User @bjorno43 unbanned @linkin-park
  • Jun 20 21:19
    @bjorno43 banned @shenerd140
  • Apr 25 17:13
    @mstellaluna banned @cmal
  • Jan 08 22:05
    @mstellaluna banned @dertiuss323
  • Nov 07 2018 04:42
    User @texas2010 unbanned @ows-ali
  • Nov 02 2018 16:25
    @texas2010 banned @ows-ali
  • Oct 12 2018 05:50
    @bjorno43 banned @NACH74
  • Oct 05 2018 23:02
    @mstellaluna banned @JomoPipi
  • Sep 16 2018 12:21
    @bjorno43 banned @yash-kedia
  • Sep 16 2018 12:16
    @bjorno43 banned @vnikifirov
  • Sep 05 2018 08:12
    User @bjorno43 unbanned @androuino
  • Sep 05 2018 07:38
    @bjorno43 banned @androuino
  • Aug 23 2018 16:57
    User @bjorno43 unbanned @rahuldkjain
  • Aug 23 2018 16:23
    @bjorno43 banned @rahuldkjain
  • Jul 29 2018 14:13
    User @bjorno43 unbanned @jkyereh
  • Jul 29 2018 01:00
    @bjorno43 banned @jkyereh
  • Jul 10 2018 22:09
    @bjorno43 banned @manafn
  • Jul 06 2018 15:20
    @texas2010 banned @imlegend19
  • Jul 03 2018 12:28
    @bjorno43 banned @vbvmatta
  • Jun 29 2018 13:54
    @bjorno43 banned @OGTechnoBoy
achudoz
@achudoz
@roeP alwo your image is overflowing. Fix that by giving it a max-width of 100% or less
Janina Pohorecki
@janepohorecka
Hey, guys :) I have been trying to solve one problem this whole morning and I can't figure it out.. I have white spaces between my inputs that I can't seem to get rid of. Could anyone please offer me a solution? https://codepen.io/janepoho/pen/oZvvKQ
roeP
@roeP
@achudoz i manage to resize the img and to center it, but the text is't in its place even when i put it in the same div
RonBeh
@RonBeh
hey, did anyone use the freeweathermap api?
achudoz
@achudoz

@janepohorecka I know you didn't really like my answer to your problem before, so I took a closer look at the css and when I add

padding:0;
  margin: 0;
  width: 102.2%;

to your fieldset, the margins disappear at least on my screen. The let's talk box overflows, but you can adjust that too and you will be set

Zhu Wei
@zhuwei12
@achudoz It's so strange,I use the same code like u,but I can't display the right result.https://codepen.io/Shallwe/pen/EWYwMb
why
i would be crazy
Mahak Narayan Singh
@makkBit
@janepohorecka wrap all your inputs in a single fieldset, instead of creating a fieldset for each input
Aniculaesei
@Aniculaesei
hello.I have to make a tribute page.But I cant load the image on code pen.Can you help me please?Thank you
how can i load an image?
achudoz
@achudoz
@zhuwei12 it is weird. It might be that you are using jQuery 2.1.3. while I am using jQuery 3.1.1.
h1tag
@h1tag
@Aniculaesei what did you try? Can you show your Codepen pen?
achudoz
@achudoz
@roeP try adding max-width and/or text-align:center to the whole div
Aniculaesei
@Aniculaesei
i dont know from where I can put my image...form my computer..or from the web(with a link)
h1tag
@h1tag
@Aniculaesei web unless you subscribe to Codepen pro $$
achudoz
@achudoz
@Aniculaesei it must be from the web. And note that some services don't work on codepen. for example images from imgur.com wont work on your pen
Aniculaesei
@Aniculaesei
ok...but how I can put an image from web?can you help me pls?
achudoz
@achudoz
<img src="insertImageURLhere">
@Aniculaesei
h1tag
@h1tag
@Aniculaesei you can this website to upload you image postimg
and then copy the "Direct link" you get after uploading the image
Aniculaesei
@Aniculaesei
thank you very much!!!! :)
roeP
@roeP
@achudoz solved it! i use <span> to connect the txt to the img :smile:
achudoz
@achudoz
@roeP hooray!
Zhu Wei
@zhuwei12
@achudoz I find the problem. "https://" in the browser stops me getting data
anyone can help me with this? my button just doesnt work...
Ken Haduch
@khaduch
@FL8Liew - y ou should change the way you are detecting your "starting" value - maybe make it a simple flag because you are storing a jQuery object, and you cannot easily compare objects or are not doing it correctly. Then after you "toggle" the value, make sure to toggle the flag so that the next time you come through it will be giving you the correct information.
FL8Liew
@FL8Liew
@khaduch what do u mean by make it a simple flag??
achudoz
@achudoz
@zhuwei12 good job!
Ken Haduch
@khaduch
@FL8Liew - indicate that the value you are currently displaying is either "C" or "F", then when you toggle it, change it to "F" or "C". That way you can test it. You could also make it true and false, just so your conditional tests are doing the right thing. Just make sure that you always flip the sense of the variable.
Ken Haduch
@khaduch

@FL8Liew - and your calculation for the "F" degrees was not correct. You were using the currentC value, which was a jquery object, so it was getting NaN (or maybe that was in my changed version.) My example change to the code would look like this:

   var starting = 'C';

   var currentC = json1.main.temp + "°C";
   var currentF = json1.main.temp * 9 / 5 + 32 + "°F";
   $('.temperature').text(currentC);
   $(".temperature").click(function() {
    if (starting == 'C') {
     $(".temperature").html(currentF);
     starting = 'F';
    } else if (starting == `F`) {
     $(".temperature").html(currentC);
     starting = 'C';
    }

   });

Probably a change of the variable name from "starting" to "currentUnits" or something else that made sense would be helpful.

FL8Liew
@FL8Liew
@khaduch $('.temperature').text(currentC);<< i dont understand what this part is for...
Ken Haduch
@khaduch
@FL8Liew - setting the actual value in your HTML the first time through, otherwise (at least with my changes) it was not set. You were originally doing this: $(".temperature").html(json1.main.temp + "°C"); and saving that? Although I might have lost the original code with my changes. So in my code, the values are being calculated, then the initial HTML for your temperature class button is being set to that "C" value.
FL8Liew
@FL8Liew
@khaduch i think i kinda understand what u mean, thanks!
CamperBot
@camperbot
fl8liew sends brownie points to @khaduch :sparkles: :thumbsup: :sparkles:
:star2: 2517 | @khaduch |http://www.freecodecamp.com/khaduch
Prateek Gogia
@reeversedev
@khaduch I am getting the wrong country name now.
Ken Haduch
@khaduch

@FL8Liew - you're welcome. And I like this code a little better:

      var unitsC = true; // starting off with Celsius
      var currentC = json1.main.temp + "°C";
      var currentF = json1.main.temp * 9 / 5 + 32 + "°F";
      $(".temperature").html(currentC); // set the initial value in the button
      $(".temperature").click(function() {
        if (unitsC) {
          $(".temperature").html(currentF); // switch to degreesF
        } else {
          $(".temperature").html(currentC); // switch to degreesC
        }
        unitsC = !unitsC; // invert the flag
      });

Made the flag a true / false, and called it "unitsC" so that true means that the C units are being displayed. Then that is just inverted at the end.

@FL8Liew - even more concise:
      var unitsC = true; // starting off with Celsius
      var currentC = json1.main.temp + "°C";
      var currentF = json1.main.temp * 9 / 5 + 32 + "°F";
      $(".temperature").html(currentC);
      $(".temperature").click(function() {
        $('.temperature').html( unitsC ? currentF : currentC);
        unitsC = !unitsC; // invert the flag
      });
@reeversedev - have you posted your URL? Or your most recent code...
Chris
@bestintown23
Why is my images not fullscreen? https://codepen.io/bestintown23/pen/KaOBJR
FL8Liew
@FL8Liew
@khaduch does that mean whenever I compare 2 variables, it is better to use true and false?
Ken Haduch
@khaduch
@FL8Liew - for something like what I showed, I think that it's better - just simpler. If you are generating something more complex, well, it depends on the situation. But for this case, it leads to a cleaner solution since there is one of two possibilities, so a straight true / false test is just perfect for this. And also for this case, you wouldn't want to read a value from the DOM (getting the actual button text itself, which you might have been doing originally? I forget?) There are many ways to make it work, of course.
Gulsvi
@gulsvi
@khaduch I'm curious why it would be bad to read from the DOM. This seems clean as well, but I still have a lot of JS work to do for FCC...
      $('.temperature').text() === currentC ? $(".temperature").text(currentF) : $(".temperature").text(currentC);
So many ways to get one thing done, it gets confusing :/
Prateek Gogia
@reeversedev

@khaduch $(document).ready(function() {
$.ajax({
type: 'GET',
data: {
id: '2172797',
appid: 'b1b15e88fa797225412429c1c50c122a1'
},
url: 'https://samples.openweathermap.org/data/2.5/weather/',
xhrFields: {
withCredentials: false
},
headers: {},
success: function(data) {

        $("#show-weather").text("Your location latitude is: " + data.coord.lat + " and longitude is: " + data.coord.lon);
        $("#show-country").text(" Your current location is: " + data.sys.name);

    },
    error: function(data) {

        console.log('error');
        console.log(data);
    },
});

});

@khaduch
$(document).ready(function() {
$.ajax({
type: 'GET',
data: {
id: '2172797',
appid: 'b1b15e88fa797225412429c1c50c122a1'
},
url: 'https://samples.openweathermap.org/data/2.5/weather/',
xhrFields: {
withCredentials: false
},
headers: {},
success: function(data) {

        $("#show-weather").text("Your location latitude is: " + data.coord.lat + " and longitude is: " + data.coord.lon);
        $("#show-country").text(" Your current location is: " + data.sys.name);

    },
    error: function(data) {

        console.log('error');
        console.log(data);
    },
});

});