hey guys im getting the dom element but im getting undefined when i specify the index. so weird. but on the others im getting the result.
const submitBtn = document.getElementsByTagName('button');
console.log(submitBtn[0]) // returns undefined
const closeBtn = document.getElementsByClassName('fa-times');
console.log(closeBtn[0]); // returns undefined const submitBtn = document.getElementsByTagName('button');
console.log(submitBtn) // returns an array
const closeBtn = document.getElementsByClassName('fa-times');
console.log(closeBtn); // returns an array
Hi all, any feedback on my first project would be much appreciated. https://codepen.io/HerbiScript/pen/zRdwoN?editors=1100 - Just started coding yesterday and know I can improve my efficiency and cleanliness. Also curious if I should jump into some JavaScript before attempting to build my portfolio? Thank you!
:star2: 1159 | @marmiz |http://www.freecodecamp.org/marmiz
:star2: 3734 | @khaduch |http://www.freecodecamp.org/khaduch
api offline
api offline
@HerbiScript - I'm looking at your tribute page - it looks pretty good, but one area that could use a little touching up is the image and how that top part responds to a smaller screen size. You could make the image resize responsively according to the width, and it seems that when it wraps to put the name and information below the image, it would be good to have his name and perhaps the date and "job title" information be on top of the image? And the way the quote about being a gamer wraps around the image, it's like a caption but it does wrap around the image and then get shoved down all the way below all of the text when it wraps. I think that's some area that could use a little work...
@khaduch Thank you for the feedback, it sounds like I need to work on incorporating some bootstrap where necessary, right? I noticed I was too focused on making it look good on my screen and not considering people opening it on something smaller. Again, thanks for the response.
:star2: 3735 | @khaduch |http://www.freecodecamp.org/khaduch
@HerbiScript - yes, it doesn't necessarily have to be bootstrap, but you can use bootstrap to achieve that. You could also just mimic the HTML and CSS (as bootstrap would do) to make that top part of the page be responsive. Maybe using flexbox... but bootstrap might give you a handle on how to make it work...
@artoodeeto - okay, so what's not going right that you are expecting to see in your CodePen post? I'm seeing it output a button information as an HTMLCollection?
api offline
@artoodeeto - I might not be thinking too clearly because it's late here... but I moved the code for the
closeBtn variable after the place where you call appendElem(); (around line 38) and I then see a length of one. So - I'm speculating that when you execute that code around line 16, that you haven't instantiated the element in the document? Could that be true?
api offline
could be a nice little touch and a fun practice
@Marmiz
Class myModal {
constructor(ble, bla);
@Marmiz is that what you mean>
hey guys I just got to the react challenges. I don't really understand how to use react in codepen because i have only used it via npm and node. Isn't using react in codepen kinda defeating the purpose of react. like building components and them each having their own css.
The only problem is, you can't have your code separated out in different files.
Which is okay because codepen is there to create quick examples.
If you want to code online, there are better sites to do that like Stackblitz and CodeSandbox
@rajeshrmishra are you behind some proxy?
like corporate proxy at work
