These are chat archives for FreeCodeCamp/HelpJavaScript

19th
Jan 2019
Brad
@bradtaniguchi
Jan 19 00:03
testing testing testing :D
Jason Luboff
@JLuboff
Jan 19 00:08
Yup...I broke a bunch of stuff lol
Pretty sure just in my dev environment that I've fixed but going to test against my staging databsae to make sure
Brad
@bradtaniguchi
Jan 19 00:10
While your doing your E2E I'm doing like a hundred unit-tests for our validation code.... it's so repetitive I'm starting to feel kinda insane XD
Jason Luboff
@JLuboff
Jan 19 00:11
I just have to wait 3.5 minutes each time :joy:
Brad
@bradtaniguchi
Jan 19 00:12
Yea.. I'd look into optimizing that somehow XD
Jason Luboff
@JLuboff
Jan 19 00:19
eh it still saves me plenty of time
There might be a way to run it headless... but currently it does everything as I watch
Brad
@bradtaniguchi
Jan 19 00:23
True, but you can save more time >:D
@JLuboff If you ever had the CI server setup, youd need headless, but in my experience it doesn't increase speed much, if at all
Jason Luboff
@JLuboff
Jan 19 00:28
Well in that case...not sure how else to speed it up. Unless I start manipulating stuff via the database
Brad
@bradtaniguchi
Jan 19 00:29
Not sure, something to look into tho
Jason Luboff
@JLuboff
Jan 19 00:30
:shrug:
Jason Luboff
@JLuboff
Jan 19 00:37
Pretty sure I've generated a couple thousand emails today
Brad
@bradtaniguchi
Jan 19 01:02
>...>
Riadh
@KWFE
Jan 19 01:34
hi
who still up?
Dhaval Vira
@dhavalveera
Jan 19 01:34
Yes
Brad
@bradtaniguchi
Jan 19 01:37
@KWFE I am, but then its not late here
Chinmay Joshi
@dienigma
Jan 19 02:10
Hey can anyone help with resources to learn angular?
Brad
@bradtaniguchi
Jan 19 02:19
@dienigma Oh yea :sunglasses:
Join me and Angular shall rule the world muhahahhaa
Chinmay Joshi
@dienigma
Jan 19 02:20
haha
Brad
@bradtaniguchi
Jan 19 02:20
But for real, the best single resource is https://angular.io/
Chinmay Joshi
@dienigma
Jan 19 02:20
Okay.
Brad
@bradtaniguchi
Jan 19 02:20
checkout their tour of heroes tutorial, goes into everything for the framework
Chinmay Joshi
@dienigma
Jan 19 02:21
Okay.
Brad
@bradtaniguchi
Jan 19 02:22
also, on gitter there's the angular/angular room to ask for help in too
Chinmay Joshi
@dienigma
Jan 19 02:25
Oh okay cool
Riadh
@KWFE
Jan 19 15:56
hi
Christopher McCormack
@cmccormack
Jan 19 17:50
@KWFE hi, morning
Riadh
@KWFE
Jan 19 17:51
how are you ? @cmccormack .
Christopher McCormack
@cmccormack
Jan 19 17:51
Good, just got pulled into work on a Saturday morning :/
yourself?
Riadh
@KWFE
Jan 19 17:58
doing well taking some rest ,,
Christopher McCormack
@cmccormack
Jan 19 18:06
@KWFE good plan for the weekend :) . I hope to do that soon as well
Tom
@moT01
Jan 19 18:17
:poop:
Riadh
@KWFE
Jan 19 18:24
well wish me to get healthier
Christopher McCormack
@cmccormack
Jan 19 18:32
@KWFE good luck, take care of yourself
@moT01 yo what it is?
Tom
@moT01
Jan 19 19:20
its poop
Christopher McCormack
@cmccormack
Jan 19 19:20
@moT01 no good? what's wrong?
Tom
@moT01
Jan 19 19:21
ha, he called the shit, poop
nothing wrong
wondering if I should game for a bit, or binge again on some of these god aweful, but slightly more than useless PR's
Christopher McCormack
@cmccormack
Jan 19 19:23
lol
do both
I usually keep two files open in PR relations, then when both are pending CI because of conflict resolution I game
Tom
@moT01
Jan 19 19:25
i've just been burning through grammar fixes
Christopher McCormack
@cmccormack
Jan 19 19:28
Are you using PR relations?
really helps to avoid merge conflicts, not perfectly but decently
Tom
@moT01
Jan 19 19:28
yup
Christopher McCormack
@cmccormack
Jan 19 19:28
nice
Tom
@moT01
Jan 19 19:29
do a filename search for guide/english
Christopher McCormack
@cmccormack
Jan 19 19:29
I usually scroll down until I find a number appropriate for how much time I have lol
so if I have very little time I'll scroll down to around 5 and do two files
it's in no way perfect but it keeps me motivated finishing a file
Tom
@moT01
Jan 19 19:30
well, the list you get from searching has the files displayed right away instead of in a collapsible arrow thingy
so I scroll through, doing grammar/typo fixes on files where the oldest PR has a title like that
Christopher McCormack
@cmccormack
Jan 19 19:32
haha that's a good way to do it
Tom
@moT01
Jan 19 19:32
its definitely going for the easy ones
Christopher McCormack
@cmccormack
Jan 19 19:33
sometimes that's all we have time for
Tom
@moT01
Jan 19 19:33
but It's sure helping to get rid of a lot of the crappy PR's and bring the number down
Christopher McCormack
@cmccormack
Jan 19 19:34
I actually dislike doing the regular html / css files, there are so many bad PRs, fixes that are worse than what they fix, etc...
Tom
@moT01
Jan 19 19:36
what do you mean, the non guide PR's? or the guides on html and css
Christopher McCormack
@cmccormack
Jan 19 19:38
guide
they are low hanging fruit for people new to FCC or web stuff so lots of PRs were submitted against them
Tom
@moT01
Jan 19 19:38
right
Christopher McCormack
@cmccormack
Jan 19 19:39
whereas topics like data science tend to have a much higher ratio of good PRs
Tom
@moT01
Jan 19 19:39
makes sense, good observation
Christopher McCormack
@cmccormack
Jan 19 19:39
I like to mix the two when reviewing to keep spirits higher lol
Tom
@moT01
Jan 19 19:40
I've become a lot less caring when it comes to the low effort PR's, and just close them if I can find any reason to
Christopher McCormack
@cmccormack
Jan 19 19:44
yup lots of nice ways to say it's not good :)
Tom
@moT01
Jan 19 19:45
yes, tell them they suck
Christopher McCormack
@cmccormack
Jan 19 19:56
Lol
enestatli
@enestatli
Jan 19 20:03
last night I solved my problem in my dream :D
that feeling!
Tom
@moT01
Jan 19 20:35
:confetti_ball: