These are chat archives for FreezingMoon/AncientBeast

22nd
May 2016
Dread Knight
@DreadKnight
May 22 2016 01:39
@s-lugo understood, good; I can assign you to some easier game related bug that's priority than
Cong
@cxong
May 22 2016 01:56
@DreadKnight what coding style checker do you use? I notice sometimes you make commits that add/remove spaces and so on
Dread Knight
@DreadKnight
May 22 2016 02:05
@cxong I do it manually atm, but we could have some jslinter added to node.js / grunt thingy FreezingMoon/AncientBeast#962
Dread Knight
@DreadKnight
May 22 2016 02:25
@s-lugo perhaps this one is suitable for you FreezingMoon/AncientBeast#886
Cong
@cxong
May 22 2016 03:32
In abilities.js atLeastOneTarget(), possible teams are "ally", "ennemy" and "both", but for queryChoice(), the values are 0 = ennemies, 1 = allies, 2 = same team, 3 = both
Why is the former missing same team? What's the difference between same team and ally?
Dread Knight
@DreadKnight
May 22 2016 03:32
the game is also 2vs2
so you have your own units but there can be allied units as well
Cong
@cxong
May 22 2016 03:33
ok; I guess atLeastOneTarget should also handle same team; maybe using the string "same"?
Dread Knight
@DreadKnight
May 22 2016 03:33
like from another team, your allie
hmm
I guess it could
Cong
@cxong
May 22 2016 03:54
hmm this doesn't seem right; team in queryDirection may be unused, because filterCreature doesn't use the 4th argument
Dread Knight
@DreadKnight
May 22 2016 03:56
hmm
Dread Knight
@DreadKnight
May 22 2016 03:58
it could be a bug, dunno xD
the truth is that I've never played the game 2vs2
and since not much testing has been done in that scenario, there might be bugs about targeting certain abilities perhaps
Cong
@cxong
May 22 2016 04:02
ok; I'll assume filterCreature expects an integer team and just refactor queryDirection and its callers
I'll send a PR which is a work in progress, but just to push the refactor in first
Dread Knight
@DreadKnight
May 22 2016 04:02

:point_up: May 22, 2016 6:57 AM

I can't properly wrap my mind around that stuff atm, but maybe it's that way because there wouldn't be any abilities that would be usable on allied units from another team only

though they could be usable on any other units except yours, so allies and enemies perhaps, requires a bit of thinking xD
(some kind of friendly fire enabled for some abilities)
Cong
@cxong
May 22 2016 04:05
oh wait, team is also used in queryChoice because the entire o parameter is passed in, that's how it works :smile:
Dread Knight
@DreadKnight
May 22 2016 04:07
thought it might be used somewhere else
good
should have suggested that xD
Cong
@cxong
May 22 2016 04:13
I think I will refrain from more refactors until we put in unit tests; it's too easy to introduce bugs like this
Dread Knight
@DreadKnight
May 22 2016 04:13
I agree, with every change to core files, all the unit abilities kinda need testing as well
it will even get scary soon as more units will get added xD
Sebastian Lugo
@slugo
May 22 2016 05:08
@DreadKnight Hey , I read the issue and i'm a little confused. The left side unit card you're referring to is the big card with the artwork and description of the unit that appears at the right side when you're trying to summon a unit ?
Dread Knight
@DreadKnight
May 22 2016 05:09
@s-lugo indeed :D
it's the one and only that shows up in-game; but perhaps I should have posted a screenshot or something
Sebastian Lugo
@slugo
May 22 2016 06:12
@DreadKnight ok , thanks. so when you click it the unit should be summoned ?
Dread Knight
@DreadKnight
May 22 2016 06:13
@s-lugo not exactly, as mentioned, it should do the same thing that the button under the two cards
it basically copies its functionality
Sebastian Lugo
@slugo
May 22 2016 06:18
@DreadKnight sorry, it's just that I don't see any two cards, what does the button says ?
Dread Knight
@DreadKnight
May 22 2016 06:28
@s-lugo it says different stuff based on situation; there's a card with artwork and one with abilities on it
Sebastian Lugo
@slugo
May 22 2016 08:35
@DreadKnight yeah, that's the one im saying, the one that says 'please select an available unit from the left grid' on the picture
Cong
@cxong
May 22 2016 12:37
@DreadKnight can you please review #967 ?
Dread Knight
@DreadKnight
May 22 2016 17:46
@s-lugo do you mean where is the button located code wise or what exactly? or you can't find that screen in the game?
@s-lugo right click an unit, or click an avatar....
@s-lugo or simply right click
@cxong will review soon, haven't been home much today, just got back