by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 02:38
    nightlark labeled #1580
  • Sep 19 23:44
    phlptp commented #1580
  • Sep 19 11:42
    phlptp synchronize #1582
  • Sep 19 11:42

    phlptp on update-trim_config_options_b

    (compare)

  • Sep 19 11:42

    phlptp on trim_config_options_b

    Automated formatting of repo fi… (compare)

  • Sep 19 11:42
    phlptp closed #1583
  • Sep 18 23:58
    github-actions[bot] opened #1583
  • Sep 18 23:58

    github-actions[bot] on update-trim_config_options_b

    Merge 763460350a2477e51f33e8ba2… Automated formatting of repo fi… (compare)

  • Sep 18 23:56
    phlptp synchronize #1582
  • Sep 18 23:56

    phlptp on trim_config_options_b

    remove python from the interfac… (compare)

  • Sep 18 23:47
    phlptp edited #1582
  • Sep 18 23:30
    phlptp synchronize #1582
  • Sep 18 23:30

    phlptp on trim_config_options_b

    Add targeted endpoints (#1559) … Automated update to SWIG genera… Change library names (#1572) *… and 2 more (compare)

  • Sep 18 22:37
    trevorhardy review_requested #1582
  • Sep 18 22:37
    trevorhardy opened #1582
  • Sep 18 20:51
    phlptp synchronize #1580
  • Sep 18 20:51

    phlptp on class_name_update

    fix java test (compare)

  • Sep 18 19:33
    phlptp synchronize #1580
  • Sep 18 19:33

    phlptp on update-class_name_update

    (compare)

  • Sep 18 19:33

    phlptp on class_name_update

    Automated formatting of repo fi… (compare)

Philip Top
@phlptp
can you push the changes you made, I will update and check with you
Trevor Hardy
@trevorhardy
OK.
Pushed in "trim_config_options_b" branch.
Trevor Hardy
@trevorhardy
Multibroker still failing on my end after a clean build.
Philip Top
@phlptp
which of these no longer exists
app->remove_option(app->get_option("--broker"));
            app->remove_option(app->get_option("--brokerport"));
            app->remove_option(app->get_option("--broker_port"));
            app->remove_option(app->get_option("--brokerPort"));
            app->remove_option(app->get_option("--brokername"));
            app->remove_option(app->get_option("--brokeraddress"));
            app->remove_option(app->get_option("--autobroker"));
Trevor Hardy
@trevorhardy
"broker", I'm pretty sure.
Philip Top
@phlptp
it seems to be throwing on --broker_port
Trevor Hardy
@trevorhardy
I'm looking at other tests, though, that still use "--broker" and they are passing. "SystemTests.cpp" for example.
I bet its a typo on my end.
Let me check.
I'm not seeing the typo if I made one. Still looking.
Trevor Hardy
@trevorhardy
I added lines 127 and 128 in that file; we could try pulling them and confirm it solves the problem.
            app->remove_option(app->get_option("--broker_port"));
            app->remove_option(app->get_option("--brokerPort"));
Philip Top
@phlptp
yeah just figured that out.
It does make the tests pass
Trevor Hardy
@trevorhardy
Hmm, interesting.
Philip Top
@phlptp
in cli11 any of the options in that same definition would link the same option. so if you remove one of them the others are gone too
Trevor Hardy
@trevorhardy
Ahh, I see.
I'm running the helics_apps-tests now. Multibroker passed but player_tests are still failing for me.
(After pulling those two lines, that is.)
Philip Top
@phlptp
strange all the player_file_tests pass for me
Trevor Hardy
@trevorhardy
Clang issue?
To be clear, I'm happy to not worry about it for now.
Philip Top
@phlptp
I suppose we should see if the CI tests pass, if those don't we need to fix them
Trevor Hardy
@trevorhardy
Good plan.
You push the fix or should I?
Philip Top
@phlptp
you push it
Trevor Hardy
@trevorhardy
OK
Double-checking on my end first.
Trevor Hardy
@trevorhardy

I've also got a few ci_skip test failing in the application-api-tests.

[ RUN      ] valuefed_single_transfer_ci_skip/valuefed_single_transfer.types_publishers5/0
/Users/hard312/source/HELICS/HELICS/tests/helics/application_api/ValueFederateTestTemplates.hpp:111: Failure
Expected equality of these values:
  val
    Which is: 43
  testValue2
    Which is: -43
[  FAILED  ] valuefed_single_transfer_ci_skip/valuefed_single_transfer.types_publishers5/0, where GetParam() = "inproc" (150 ms)

These are failing for all the core types with essentially the same error message.

Trevor Hardy
@trevorhardy
Fix pushed up; we'll see how the CI tests run.
Philip Top
@phlptp
looks like it is passing the circle-ci tests
Philip Top
@phlptp
and none of the other tests have failed yet, though some are still going
Philip Top
@phlptp
looks like they passed the CI tests
8 replies
Philip Top
@phlptp
@kdheepak do we need the helics-config app any more in helics 3?
Dheepak Krishnamurthy
@kdheepak
No we don't, we can remove it.
Trevor Hardy
@trevorhardy

@kdheepak: I'm on a loaner computer doing a fresh install of pyhelics by doing the following:

git clone https://github.com/GMLC-TDC/pyhelics
cd pyhelics
python -m pip install -e .

When I try to check the installation by import helics as h I get the following error:

...
  File "/Users/hard312/source/HELICS/pyhelics/helics/_build.py", line 23, in <module>
    with open(os.path.join(PYHELICS_INSTALL, "include/helics", file)) as f:
FileNotFoundError: [Errno 2] No such file or directory: '/Users/hard312/source/HELICS/pyhelics/helics/install/include/helics/helics_enums.h'
Dheepak Krishnamurthy
@kdheepak
You need to run python setup.py download
Trevor Hardy
@trevorhardy
Ahh, OK.
Dheepak Krishnamurthy
@kdheepak
after cd pyhelics but before python -m pip install -e .
Trevor Hardy
@trevorhardy
Thanks for the quick reply. When I followed ALL the instructions in your documentation it worked out fine.
Trevor Hardy
@trevorhardy
I there a way to get general options used in a JSON config file via an API? For example, can I see what value for period was set? It feels like helicsGetOptionValue would be the one but when I try it out I get an error:
AttributeError: helicsGetOptionValue
Philip Top
@phlptp
helicsFederateGetTimeValue then use the period enumeration
Trevor Hardy
@trevorhardy
And then, helicsFederateGetFlagProperty for something like uninterruptible, right?
Philip Top
@phlptp
right
You might try to query "config" to the federate that might actually get everything in the federate configuration
I think I use that internally but haven't really published docs on it. But sounds like it may be useful for whatever it is you are doing
I probably should add it to the docs but it is still somewhat experimental.
Trevor Hardy
@trevorhardy

Good suggestion.

My need was pretty basic: we had hard-coded the update interval in the example federate code but also had it defined in the config file. I just wanted to set the internal variable to be whatever value was in the config file (rather than the hard-coded value).

Allison Campbell
@bearcub
I have a question about the use of the HELICS apps. If you have a moment, would you mind popping over to the github discussion board and providing some feedback?
https://github.com/GMLC-TDC/HELICS/discussions/1578