These are chat archives for GMOD/Apollo

14th
Jul 2015
Nathan Dunn
@nathandunn
Jul 14 2015 19:11
test chat message
Deepak
@deepakunni3
Jul 14 2015 19:17
Message received
Nathan Dunn
@nathandunn
Jul 14 2015 19:18
great . .. FYI, I just pushed a change so that the integration tests are more consistent
Deepak
@deepakunni3
Jul 14 2015 19:19
Awesome. So no more random break in integration tests.
Nathan Dunn
@nathandunn
Jul 14 2015 19:19
basically when it pulls out a sequence alteration I am sorting it by its fmin . . . so if it fails .. it will consistently fail and vice versa
that is my hope :smile:
Deepak
@deepakunni3
Jul 14 2015 19:20
but why would it fail sometimes and pass in other cases
Nathan Dunn
@nathandunn
Jul 14 2015 19:25
I'm sure there is some random assortment of sequence alterations that when combined create this error. . . that or you can't combine them randomly
either way you want a consistent result
Nathan Dunn
@nathandunn
Jul 14 2015 19:32
BTW, what is status of #458?
Deepak
@deepakunni3
Jul 14 2015 19:34
#458 is up for review. It should be fixed with the commits made in the pull request
Nathan Dunn
@nathandunn
Jul 14 2015 19:36
I see . . is this for @monicacecilia to review?
or did I already merge it? (sorry long weekend)
it looks like I did in #472 . . this should be marked as ready then and put up?
Deepak
@deepakunni3
Jul 14 2015 19:41
yeah. I wanted your opinion on it. if it looks good then we can put it up for testing.
Nathan Dunn
@nathandunn
Jul 14 2015 19:41
yeah, I looked over it, but if you want to walk me through it that would be great
Deepak
@deepakunni3
Jul 14 2015 19:42
sure. skype?
Nathan Dunn
@nathandunn
Jul 14 2015 19:42
sure
Nathan Dunn
@nathandunn
Jul 14 2015 20:59
@deepakunni3 This was the alternate codes one I was talking about: GMOD/Apollo#95
anyway . . . not sure what the priority is
Deepak
@deepakunni3
Jul 14 2015 21:01
ah, yes. We should add this to the agenda for Thursday
Nathan Dunn
@nathandunn
Jul 14 2015 21:09
agreed