Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Feb 26 2018 23:40
    nathandunn synchronize #1235
  • Feb 26 2018 23:40
    nathandunn edited #1235
  • Feb 26 2018 23:33
    nathandunn assigned #1235
  • Feb 26 2018 23:32
    nathandunn synchronize #1235
  • Feb 26 2018 23:26
    wafflebot[bot] labeled #1235
  • Feb 26 2018 23:26
    wafflebot[bot] unlabeled #1235
  • Feb 26 2018 23:26
    nathandunn synchronize #1235
  • Feb 26 2018 10:55
    epaule commented #1863
  • Feb 24 2018 17:25
    deepakunni3 commented #1864
  • Feb 24 2018 07:36
    wafflebot[bot] unlabeled #1864
  • Feb 24 2018 07:36

    nathandunn on master

    Fix cvTerm and alternateCvTerm … (compare)

  • Feb 24 2018 07:36
    nathandunn closed #1864
  • Feb 24 2018 07:36
    nathandunn milestoned #1864
  • Feb 24 2018 07:31
    nathandunn commented #1864
  • Feb 24 2018 07:17
    nathandunn synchronize #1864
  • Feb 24 2018 07:09

    nathandunn on master

    pinging build (compare)

  • Feb 24 2018 06:53
    wafflebot[bot] assigned #1864
  • Feb 24 2018 06:53
    nathandunn synchronize #1864
  • Feb 24 2018 01:05
    deepakunni3 review_requested #1864
  • Feb 24 2018 01:05
    wafflebot[bot] labeled #1864
Robert Buels
@rbuels
lol
Robert Buels
@rbuels
@garrettjstevens @peterkxie apollo meeting in 30 mins is in the google meet room
peterkxie
@peterkxie
:thumbsup:
Nathan Dunn
@nathandunn
@garrettjstevens I’ll try to get that PR in by the end of Monday . . I’ll be out most of the morning (other than the interview), so it probably won’t be until the afternoon
Nathan Dunn
@nathandunn
@garrettjstevens Looking at PR, do we have a websocket test for it, yet?
never mind . . I see that you do . . sorry.
Garrett Stevens
@garrettjstevens

@nathandunn is the "findAllOrganisms" web services endpoint available via web sockets? I've been trying this:

client.publish({
  destination: '/app/AnnotationNotification',
  body: JSON.stringify({ operation: 'find_all_organisms' }),
})

but I get the message "Operation findAllOrganisms not found"

Nathan Dunn
@nathandunn
let me check
it won’t be at this point because only RequestHandlingService methods are available
we woul dhave to write an end-point.
@garrettjstevens that took a scope (organism) and an operation (find_all_organisms). However, that is one where there shouldn’t necessarily be a reason to do it that way unless we were pushing updates organisms. Not an operation that happens often. Typically we only supported real-time annotation editing. Right now only getFeatures is a problem.
Nathan Dunn
@nathandunn
but that is because of GWT, not the server
Nathan Dunn
@nathandunn
BTW for both @peterkxie and @garrettjstevens its absolutely okay to use regular ajax requests. We can always change / update to websockets as we go. For the purposes of demonstration and gettin gthe UI working I think Ajax might be easier.
My goal today is to get a dev environment working with react and grails (spring) with authentication . .. we’ll see where I get
Garrett Stevens
@garrettjstevens
@nathandunn yes, that's what we're using to develop right now
Nathan Dunn
@nathandunn
:+1:
I’m fairly convinced that you can use react dev mode with a localhost proxy against grails and everything will work (today’s work). I don’t think with using the current security scheme with Apollo 2 / Spring you’ll be able to authenticate in a production environment across domains.
Nathan Dunn
@nathandunn
for that you will need tokens, which would be part of the apollo 3 design spec
Robert Buels
@rbuels
What prevents the current Apollo 2 from cross domain authentication if we get the current PR across the finish line?
Nathan Dunn
@nathandunn
it needs to have a session on the current thread
basically the websocket comes in and its not associated with any session . . . I need to redo the examples so that I am testing routes with a session . . . even when I was building it locally it wasn’t getting the session
maybe we can come back to it once I get that connected
@rbuels it would be worth reading through all of the comments, but this in particular: https://github.com/GMOD/Apollo/pull/2598#issuecomment-811445444
Nathan Dunn
@nathandunn
it might be possible, but probably not. To do what you are saying, you would really want to design it using JWT token security from the get-go, which is what I’m doing for Apollo 3
But I feel that we can probably get hot-reload working . . .
I think you simply add, "proxy":"http://localhost:8080/apollo”, and it seems to get the JSESSIONID properly when using http://localhost:3000/apollo (or whatever)
Robert Buels
@rbuels
sure if we did proxies it will work, obviously
that's equivalent to having jb2 served by the apollo server the same way that jb1 is
and you get the cookie and things just work, etc
Nathan Dunn
@nathandunn
yes
but even in the toy problems I need to go back and see what that minimal set is to make sure it gets a session
bound to a thread on the server-side
right now we only have a baseline for getting around CORS via a web socket
but its not connecting to the server in a useful way since it isn’t binding to the current user even with the JSESSIONID . .. I’m sure its pretty tractable, I just need to go back over the current codebase and figure out what I’m doing wrong. Then we can see where we can take it from there.
since I know it already works from dojo-land
Robert Buels
@rbuels
My internet went down. Sigh
Nathan Dunn
@nathandunn
@garrettjstevens this is ready: garrettjstevens/apollo-websocket-test#2 . . . it just has the ajax versus the websocket login and logout . . but I support both
with the newer server code
Also done with these fixes as well
Nathan Dunn
@nathandunn
though going to test another AJAX query once queried authenticated
Nathan Dunn
@nathandunn
@garrettjstevens I am done testing. I think that both PRs will likely be fine.
you can push them as if you are good with them
Robert Buels
@rbuels
fyi i will need to duck out of tomorrow's apollo meeting about 20 mins early, got to drive the dog to the groomer cause it was the only grooming appointment we could get :-P
Curtis Ross
@cross12tamu
Do y'all have a branding repo that I could pull some SVGs from for one of our web apps?
Nathan Dunn
@nathandunn
:+1:
@cross12tamu . . . I'm not sure I catch your drift. Do you want Apollo logos or a way to brand your Apollo differently from the apollo logos?
Curtis Ross
@cross12tamu
@nathandunn just Apollo logos
Nathan Dunn
@nathandunn
Curtis Ross
@cross12tamu
thanks!