Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Nov 28 09:18
    gep13 closed #214
  • Nov 27 23:22
    tonimikr123 opened #214
  • May 05 16:36
    juangburgos commented #80
  • Jul 16 2020 07:56

    GeertvanHorrik on develop

    Add CefSharp to the list of pro… Merge pull request #213 from Do… (compare)

  • Jul 16 2020 07:56
    GeertvanHorrik closed #213
  • Jul 16 2020 07:39
    DominikPalo edited #213
  • Jul 16 2020 07:37
    DominikPalo opened #213
  • Feb 20 2020 09:02
    volak closed #180
  • Jun 06 2019 12:54
    Ducatel commented #211
  • Jun 06 2019 12:15
    Ducatel commented #211
  • Jun 06 2019 12:07
    Ducatel commented #211
  • Jun 06 2019 11:45
    GeertvanHorrik closed #211
  • Jun 06 2019 11:45
    GeertvanHorrik commented #211
  • Jun 06 2019 11:44

    GeertvanHorrik on develop

    #211 Add `urlencoded_filename` … (test) Add test with URL which … (doc) Add documentation of new … and 1 more (compare)

  • Jun 06 2019 11:44
    GeertvanHorrik closed #212
  • Jun 06 2019 09:08
    Ducatel opened #212
  • Jun 05 2019 15:26
    Ducatel opened #211
  • Apr 16 2019 21:45
    michael-hay commented #80
  • Apr 16 2019 21:30
    michael-hay commented #80
  • Apr 16 2019 21:29
    michael-hay commented #80
Andrew Brown
@AGBrown
@AArnott - maybe you've fixed this a million times already?
Andrew Brown
@AGBrown
well this is fun; if you use git EOL autoconversion then your repository source files "don't match" the files used to compile the dll, and visual studio complains that they are different. The only difference is the eol, but that's enough for VS to ignore the file unless you unset the "Require source files to exactly match the original version" option in VS. I don't know yet if this is related to it only going to the metadata.
Andrew Arnott
@AArnott
@AGBrown I open the pdb in a text editor and look for "SRCSRV" when I want to check that the pdb has indeed been rewritten.
@AGBrown The EOL issue is hitting the Roslyn team as well (who recently adopted GitLink too). They are fixing it by getting the Debugger team to change the VS debugger to tolerate line ending differences (at least in the most common cases).
For now, @ctaggart wrote up how to avoid the problem here: https://github.com/ctaggart/SourceLink/wiki/Line-Endings
Regarding your "source files are behind an authentication page" problem, the debugger team is looking into that too. I don't know of a way to fix that. Aside from perhaps setting gitlink to use its "powershell" mode, which I only guess is meant to address that problem.
Andrew Brown
@AGBrown

@AArnott, thanks - and sorry for the slow response, I was afk for a couple of weeks. I can see that our pdb files have been rewritten, but for some reason resharper is not navigating to source for interfaces (it is for classes). I'm assuming this is resharper and not gitlink related as the interfaces have the rewritten info in the pdb.

ref. EOLs - I think we're just going to ensure that git doesn't do line conversion using gitattributes with * -text, that way the repo will always reflect the compilation directory source as well.

ref. authentication page - I'm using Fiddler to add an authentication cookie to requests. I didn't have to do that as it just worked (just by logging in to the source control server in a VS tab) before using resharper, now it doesn't.

Matt Ellis
@citizenmatt
@AGBrown Can you get me a repo project, please? I seem to hazily remember something about interfaces not being part of the .pdb files, but that doesn't sound right as you say they're in there.
Andrew Brown
@AGBrown
@citizenmatt, I'll try and put together a sample - I can't send you my client's projects unfortunately
(the interfaces are certainly listed in the SRCSRV data generated by gitlink in the pdb file)
@citizenmatt and separately, on the authentication issue - we're using VS 2013 update 5 on windows 8.1, we've logged in using both a tab inside VS, and in internet explorer. However using fiddler I can see that resharper sends requests to our gitlab server without reusing either of those sessions with their authentication cookies.
Matt Ellis
@citizenmatt
I don’t know about the authentication issue, I’m afraid. Best thing is to log an issue in this case: https://youtrack.jetbrains.com/newIssue?project=RSRP&clearDraft=true&c=
moljac
@moljac
Morn
On Mac with Cake on mono I get this error:
Unhandled Exception:
System.IO.FileNotFoundException: Could not load file or assembly 'Catel.Core, Version=4.5.3.0, Culture=neutral, PublicKeyToken=null' or one of its dependencies.
File name: 'Catel.Core, Version=4.5.3.0, Culture=neutral, PublicKeyToken=null'
[ERROR] FATAL UNHANDLED EXCEPTION: System.IO.FileNotFoundException: Could not load file or assembly 'Catel.Core, Version=4.5.3.0, Culture=neutral, PublicKeyToken=null' or one of its dependencies.
Any ideas how to solve this?
I’m Xamarin.Auth maintainer/developer and want to add GitLink to the project and suggest other team-mates to add GitLink to other Xamarin projects.
Geert van Horrik
@GeertvanHorrik
@moljac This is probably using .net core?
moljac
@moljac
Morn Geert
Nope - it is mono
Sorry for delay. Users need help regarding new google OAuth for “installed”/mobile apps.
Geert van Horrik
@GeertvanHorrik
I believe the new unstable version (GL 3.0) no longer embeds Catel.Core using Costura but provides it as a dependency
so could you try to install GitLink -include-prerelease
moljac
@moljac
I tried it through Cake
Will do.
Do you know whether Xamarin.Forms team uses GitLink? I am supposed to write an email to whole engineering Xamarin team with suggestion to use GitLink for all our open source projects.
I cannot find any Xamarin products using GitLink
Geert van Horrik
@GeertvanHorrik
I don't think so. I know Roslyn uses it, but no other parties at MS. The new unstable GitLink simply works against pdb files instead of solution files (which Cake supports for now), so that should be much easier to use. I will ask @gep13 to support GL 3 (unstable) as well
@gep13 maybe we can support it based on version detection?
Gotta go for a while, but ping me if you have any questions. We are looking for a way to combine our efforts with SourceLink (v2) for portable pdb's as well. So GitLink will probably be used for the full .net fx, SL v2 will be used for portable / .net core libs
Gary Ewan Park
@gep13
@GeertvanHorrik typically, we make the aliases in Cake work with the latest version of the shipped version of the tool. We have made additional aliases for the likes to NUnit 2 and NUnit3, since they are both widely used. However, normally we just update the individual aliases. If we can take appropriate action based on a setting/version/convention, then certainly we can do that.
Geert van Horrik
@GeertvanHorrik
Thanks. We'll try to make v3 stable soon, but I need to do some work-related stuff first (which is always a higher prio)
moljac
@moljac
Pdb header didn't match
Any suggestions?
VS 2015
Geert van Horrik
@GeertvanHorrik
@moljac what version of GL / VS / Target FX?
Paulo Morgado
@paulomorgado
https://github.com/GitTools/GitLink/blob/develop/README.md states that:
NuGet/MSBuild integration
The simplest way to use GitLink is to install its NuGet package into your project.
Install-Package GitLink
Once installed, it automatically integrates with MSBuild to add source download instructions to your PDB.
Geert van Horrik
@GeertvanHorrik
That's the unstable version (develop branch)
so install the prerelease and it works as advertised on the develop branch readme
Paulo Morgado
@paulomorgado
with any hosting? even on premises?
Geert van Horrik
@GeertvanHorrik
Depends. The hard part is VS understanding authentication when retrieving the source files. So GitLink will work perfectly, but since VS can't do any auth while requesting the source files, it looks like it's not working. Best is to use GitLink for open-source (or at least publicly available repositories). I believe MS is working to support authentication for source link (replacement for source server support)
Paulo Morgado
@paulomorgado
by the way, you should add $(BuildingForLiveUnitTesting) != 'true' to avoid it kicking off during Live Unit Testing builds
Geert van Horrik
@GeertvanHorrik
Feel free to PR :-)
Paulo Morgado
@paulomorgado
I'm a bit stressed with until next week. If I don't PR, ping me.
Geert van Horrik
@GeertvanHorrik
:+1: Thanks for reaching out to us.
Paulo Morgado
@paulomorgado
so an on prem host should have an unauthenticated source endpoint
Geert van Horrik
@GeertvanHorrik
Yes, or use a proxy that tunnels the files for you (but that's the same as removing authentication, which is a security issue on it's own)
Paulo Morgado
@paulomorgado
Just submitted a PR for BuildingForLiveUnitTesting
Bastian Schmidt
@batzen
May i ask why version 2.4.1 was deleted from nuget? can't find anything mentioning this...
Andrew Arnott
@AArnott
How did that even happen? Unlisting is easy, but deleting is hard.
Pascal Berger
@pascalberger
@batzen The reason why it was removed was explained in this issue: https://github.com/cake-contrib/Cake.Recipe/pull/123#issuecomment-310923552
Andrew Arnott
@AArnott
Interesting. I think v3 won't suffer from this. IIRC I removed this dynamic assembly loading.
Geert van Horrik
@GeertvanHorrik
Yes, this shouldn't be part of GitLink v3 (prerelease). Although it's very frustrating since I immediately contacted the NuGet team but they don't seem in a hurry.
Best is to use GitLink from Chocolatey, they have better support
(or use GitLink unstable)
Gary Ewan Park
@gep13
Chocolatey Support FTW :-)
wahmedswl
@wahmedswl
Hi, getting Unhandled Exception: GitLink.GitLinkException: Pdb header didn't match at GitLink.Pdb.PdbFile.CheckPdbHeader() at GitLink.Pdb.PdbFile..ctor(String path) at GitLink.Linker.Link(String pdbPath, LinkOptions options) at GitLink.Program.Main(String[] args)
using GitLink with Cake