Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Nov 28 09:18
    gep13 closed #214
  • Nov 27 23:22
    tonimikr123 opened #214
  • May 05 16:36
    juangburgos commented #80
  • Jul 16 2020 07:56

    GeertvanHorrik on develop

    Add CefSharp to the list of pro… Merge pull request #213 from Do… (compare)

  • Jul 16 2020 07:56
    GeertvanHorrik closed #213
  • Jul 16 2020 07:39
    DominikPalo edited #213
  • Jul 16 2020 07:37
    DominikPalo opened #213
  • Feb 20 2020 09:02
    volak closed #180
  • Jun 06 2019 12:54
    Ducatel commented #211
  • Jun 06 2019 12:15
    Ducatel commented #211
  • Jun 06 2019 12:07
    Ducatel commented #211
  • Jun 06 2019 11:45
    GeertvanHorrik closed #211
  • Jun 06 2019 11:45
    GeertvanHorrik commented #211
  • Jun 06 2019 11:44

    GeertvanHorrik on develop

    #211 Add `urlencoded_filename` … (test) Add test with URL which … (doc) Add documentation of new … and 1 more (compare)

  • Jun 06 2019 11:44
    GeertvanHorrik closed #212
  • Jun 06 2019 09:08
    Ducatel opened #212
  • Jun 05 2019 15:26
    Ducatel opened #211
  • Apr 16 2019 21:45
    michael-hay commented #80
  • Apr 16 2019 21:30
    michael-hay commented #80
  • Apr 16 2019 21:29
    michael-hay commented #80
Geert van Horrik
@GeertvanHorrik
so could you try to install GitLink -include-prerelease
moljac
@moljac
I tried it through Cake
Will do.
Do you know whether Xamarin.Forms team uses GitLink? I am supposed to write an email to whole engineering Xamarin team with suggestion to use GitLink for all our open source projects.
I cannot find any Xamarin products using GitLink
Geert van Horrik
@GeertvanHorrik
I don't think so. I know Roslyn uses it, but no other parties at MS. The new unstable GitLink simply works against pdb files instead of solution files (which Cake supports for now), so that should be much easier to use. I will ask @gep13 to support GL 3 (unstable) as well
@gep13 maybe we can support it based on version detection?
Gotta go for a while, but ping me if you have any questions. We are looking for a way to combine our efforts with SourceLink (v2) for portable pdb's as well. So GitLink will probably be used for the full .net fx, SL v2 will be used for portable / .net core libs
Gary Ewan Park
@gep13
@GeertvanHorrik typically, we make the aliases in Cake work with the latest version of the shipped version of the tool. We have made additional aliases for the likes to NUnit 2 and NUnit3, since they are both widely used. However, normally we just update the individual aliases. If we can take appropriate action based on a setting/version/convention, then certainly we can do that.
Geert van Horrik
@GeertvanHorrik
Thanks. We'll try to make v3 stable soon, but I need to do some work-related stuff first (which is always a higher prio)
moljac
@moljac
Pdb header didn't match
Any suggestions?
VS 2015
Geert van Horrik
@GeertvanHorrik
@moljac what version of GL / VS / Target FX?
Paulo Morgado
@paulomorgado
https://github.com/GitTools/GitLink/blob/develop/README.md states that:
NuGet/MSBuild integration
The simplest way to use GitLink is to install its NuGet package into your project.
Install-Package GitLink
Once installed, it automatically integrates with MSBuild to add source download instructions to your PDB.
Geert van Horrik
@GeertvanHorrik
That's the unstable version (develop branch)
so install the prerelease and it works as advertised on the develop branch readme
Paulo Morgado
@paulomorgado
with any hosting? even on premises?
Geert van Horrik
@GeertvanHorrik
Depends. The hard part is VS understanding authentication when retrieving the source files. So GitLink will work perfectly, but since VS can't do any auth while requesting the source files, it looks like it's not working. Best is to use GitLink for open-source (or at least publicly available repositories). I believe MS is working to support authentication for source link (replacement for source server support)
Paulo Morgado
@paulomorgado
by the way, you should add $(BuildingForLiveUnitTesting) != 'true' to avoid it kicking off during Live Unit Testing builds
Geert van Horrik
@GeertvanHorrik
Feel free to PR :-)
Paulo Morgado
@paulomorgado
I'm a bit stressed with until next week. If I don't PR, ping me.
Geert van Horrik
@GeertvanHorrik
:+1: Thanks for reaching out to us.
Paulo Morgado
@paulomorgado
so an on prem host should have an unauthenticated source endpoint
Geert van Horrik
@GeertvanHorrik
Yes, or use a proxy that tunnels the files for you (but that's the same as removing authentication, which is a security issue on it's own)
Paulo Morgado
@paulomorgado
Just submitted a PR for BuildingForLiveUnitTesting
Bastian Schmidt
@batzen
May i ask why version 2.4.1 was deleted from nuget? can't find anything mentioning this...
Andrew Arnott
@AArnott
How did that even happen? Unlisting is easy, but deleting is hard.
Pascal Berger
@pascalberger
@batzen The reason why it was removed was explained in this issue: https://github.com/cake-contrib/Cake.Recipe/pull/123#issuecomment-310923552
Andrew Arnott
@AArnott
Interesting. I think v3 won't suffer from this. IIRC I removed this dynamic assembly loading.
Geert van Horrik
@GeertvanHorrik
Yes, this shouldn't be part of GitLink v3 (prerelease). Although it's very frustrating since I immediately contacted the NuGet team but they don't seem in a hurry.
Best is to use GitLink from Chocolatey, they have better support
(or use GitLink unstable)
Gary Ewan Park
@gep13
Chocolatey Support FTW :-)
wahmedswl
@wahmedswl
Hi, getting Unhandled Exception: GitLink.GitLinkException: Pdb header didn't match at GitLink.Pdb.PdbFile.CheckPdbHeader() at GitLink.Pdb.PdbFile..ctor(String path) at GitLink.Linker.Link(String pdbPath, LinkOptions options) at GitLink.Program.Main(String[] args)
using GitLink with Cake
any help would be appreciated
Geert van Horrik
@GeertvanHorrik
Are you building in release mode with pdb generation enabled?
Andrew Arnott
@AArnott
That happens when you're building portable PDBs (which is the default for .NET SDK projects).
wahmedswl
@wahmedswl
yes, release mode with pdb generation
Andrew Arnott
@AArnott
And is it a .NET SDK project?
wahmedswl
@wahmedswl
yes, .net project
i am going to switch to GitLink with cake
can i give pdb via cmd etc to GitLink to work with pdb directly?
also, how can repo url be modified via msbuild task?
Andrew Arnott
@AArnott
No, I'm not asking if it is a .NET project. I'm asking if it is one of the new projects that include an SDK attribute in the Project tag of the project file.
Matthias Koch
@matkoch
@AArnott that reminds me of "the new ipad" :) seems like the name is not distinctive enough
Kevin B
@Keboo
Hey guys. I am just getting started with GitLink. On the README it says "Once installed, it automatically integrates with MSBuild to add source download instructions to your PDB." Does this also apply to the new project types (<Project Sdk="Microsoft.NET.Sdk">) or do I need to invoke the CLI as part of my build process? I have added the nuget package and turned my msbuild logging up, but I don't see the GitLink.exe being executing (it does get copied to my output directory).
Copying file from "C:\Users\kitok\.nuget\packages\gitlink\2.4.0\lib\net45\GitLink.exe" to "bin\Release\net45\GitLink.exe". Is there something I should be looking for in the MSBuild output?
Geert van Horrik
@GeertvanHorrik
the readme references the unstable packages (develop branch)
it's on the list to be released as stable, but I just have too much to do at the moment to release it as stable, maybe next week
Andrew Arnott
@AArnott
@Keboo install the v3 prerelease to get msbuild integration for free. Yes, it works with .NET SDK projects.
Kevin B
@Keboo
awesome, thanks for the help guys.
Kevin B
@Keboo
One more question. I have added the latest 3.0.0 pre-release nuget. It appears that there are only a few specific <DebugType> values that are compatible with GitLink. "full" and "pdbonly" both appear to work as expected. "portable" causes the MSBuild tasks to error due to the pdb file having a different header. Finally "embeded" and "none" both appear to skip running the LinkPdbToGitRemote target since there is no PDB file to act upon.
Is this description of the behavior expected/correct?
I assume the typical approach is to simply set the libraries to "full"?