Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • May 05 16:36
    juangburgos commented #80
  • Jul 16 2020 07:56

    GeertvanHorrik on develop

    Add CefSharp to the list of pro… Merge pull request #213 from Do… (compare)

  • Jul 16 2020 07:56
    GeertvanHorrik closed #213
  • Jul 16 2020 07:39
    DominikPalo edited #213
  • Jul 16 2020 07:37
    DominikPalo opened #213
  • Feb 20 2020 09:02
    volak closed #180
  • Jun 06 2019 12:54
    Ducatel commented #211
  • Jun 06 2019 12:15
    Ducatel commented #211
  • Jun 06 2019 12:07
    Ducatel commented #211
  • Jun 06 2019 11:45
    GeertvanHorrik closed #211
  • Jun 06 2019 11:45
    GeertvanHorrik commented #211
  • Jun 06 2019 11:44

    GeertvanHorrik on develop

    #211 Add `urlencoded_filename` … (test) Add test with URL which … (doc) Add documentation of new … and 1 more (compare)

  • Jun 06 2019 11:44
    GeertvanHorrik closed #212
  • Jun 06 2019 09:08
    Ducatel opened #212
  • Jun 05 2019 15:26
    Ducatel opened #211
  • Apr 16 2019 21:45
    michael-hay commented #80
  • Apr 16 2019 21:30
    michael-hay commented #80
  • Apr 16 2019 21:29
    michael-hay commented #80
  • Mar 19 2019 18:00
    schultetwin1 closed #208
  • Mar 19 2019 18:00
    schultetwin1 commented #208
Andrew Arnott
@AArnott
@Keboo install the v3 prerelease to get msbuild integration for free. Yes, it works with .NET SDK projects.
Kevin B
@Keboo
awesome, thanks for the help guys.
Kevin B
@Keboo
One more question. I have added the latest 3.0.0 pre-release nuget. It appears that there are only a few specific <DebugType> values that are compatible with GitLink. "full" and "pdbonly" both appear to work as expected. "portable" causes the MSBuild tasks to error due to the pdb file having a different header. Finally "embeded" and "none" both appear to skip running the LinkPdbToGitRemote target since there is no PDB file to act upon.
Is this description of the behavior expected/correct?
I assume the typical approach is to simply set the libraries to "full"?
Geert van Horrik
@GeertvanHorrik
Portables are not supported by GitLink. I will now release GitLink 3.0 as stable. In the future, we hope to merge the functionality of GitLink into SourceLink (which supports portable pdbs).
Geert van Horrik
@GeertvanHorrik
Thanks to the hard work of @AArnott , GitLink 3.0 has been released!
Gary Ewan Park
@gep13
:+1:
great news!
@GeertvanHorrik is there anything in the Cake Add in for GitLink that needs changed? Or will it continue to work as is?
Kevin B
@Keboo
@GeertvanHorrik thank you
Geert van Horrik
@GeertvanHorrik
@gep13 I would force it to use 2.4.1 for now, then test slowly whether you can continue to update
especially because it's a breaking change release, that needs planning and timing
Gary Ewan Park
@gep13
@GeertvanHorrik yip, i am already pinned to 2.4.1, but i will take the new one for a spin, and report back with any issues.
Geert van Horrik
@GeertvanHorrik
:+1:
WJH
@wongjiahau
hello guys may I know how to use gitlink ?
Andrew Arnott
@AArnott
@wongjiahau please start with the Readme and ask specific questions.
jairbubbles
@jairbubbles
Hello @GeertvanHorrik Do you think it would be possible to a beta package for the -a option ?
Geert van Horrik
@GeertvanHorrik
yep, will do
Geert van Horrik
@GeertvanHorrik
done.
jairbubbles
@jairbubbles
Thx
(FYI I've already switched from PdbGit to GitLink 3.0 without any visible issue)
Geert van Horrik
@GeertvanHorrik
nice, that's probably because PdbGit implementation is now mostly moved to GitLink
jairbubbles
@jairbubbles
I've been working a little bit more on pdb for native applications but I ended up thinking we should keep it the way it is. Extracting a list of source files from a native application he's much more complex and it's not as accurate as you'll end with many files from headers from standard library and so on. The best way to illustrate this is to launch cvdump.exe -sf on a native pdb (https://github.com/Microsoft/microsoft-pdb/tree/master/cvdump). For each compilation unit you'll get many files.
If we were to explore that way I'd use cvdump.exe in command line and exploits the output but it's a 1MB .exe to embed. I don't think like it's worth it. Possibily adding too many files like we're doing right now doesn't seem a big issue to me. It just makes the SRCSRV part of the pdb a little bit bigger.
jairbubbles
@jairbubbles
after switching from PdbGit to GitLibk I'm hitting "No source files were found in the PDB" on some sample projects which do not have source files and on C++ projects but it's another topic.
I feel like it should be a warning and the process should not return an error.
Andrew Arnott
@AArnott
I'm going to submit a PR that replaces the VS2017 deprecated project.json files with PackageReference items. If I'm lucky, I'll succeed at moving to .NET SDK projects too to further simplify things.
Then, my original goal: to support suppressing the "no source file found" warning for specific files so that git versioning that produces source files during the build doesn't result in build warnings from gitlink.
Oh, and modify the linker to prefer the origin remote rather than just picking the 'first' one, so that we don't accidentally generate PDBs that link to forks.
Geert van Horrik
@GeertvanHorrik
Great to hear, thanks for the efforts @AArnott !
Andrew Arnott
@AArnott
OK. I have #182 to migrate the projects to the .NET SDK format. I also have two more branches that build on it for the two features I mentioned this morning. I'm waiting for #182 to merge before filing the two additional PRs so that the diff is nice and focused.
Andrew Arnott
@AArnott
I'm looking to migrate some projects from pdbgit to gitlink. GitLink v3 has been around for a while, but I'm just now getting to it. Can you release a new gitlink with my recent fixes? I'd like to address especially the build warnings while I'm updating all my projects.
Geert van Horrik
@GeertvanHorrik
doing now!
Andrew Arnott
@AArnott
thanks. :)
Geert van Horrik
@GeertvanHorrik
3.2.0-alpha.14.build.118 being deployed to chocolatey right now
Andrew Arnott
@AArnott
will you have an equivalent deployment to myget or nuget? I consume the nuget package.
Geert van Horrik
@GeertvanHorrik
sorry, pushing now to NuGet as well
Andrew Arnott
@AArnott
Thanks
Justin Swanson
@Noggog
Hey all! Thank you for this tool, I'm super excited to start using it.
I have one tangental question, but my google fu is failing me.
I have a bunch of nuget packages with PDBs in them, but when I go to use them in a console app, the console app does not seem to be bringing the pdbs into its build results folder. Thus, when exceptions happen, the line numbers are missing. If I copy the pdbs in manually, the line numbers show up. But I'm uncertain why they aren't being copied by the build process automatically, considering they're part of the library's nuget package.
This isn't necessarily Gitlink's problem, but it is blocking my proper usage of it, I think
Justin Swanson
@Noggog
Alright, I guess I just solved in the short term by embedding the pdbs via Build -> Advanced -> Debugging Information -> Embed. Seems like a decent short term solution, but still curious on why the pdbs weren't copying
Geert van Horrik
@GeertvanHorrik
Please note that we recommend using SourceLink nowadays, it's embedded into Visual Studio etc