Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 19:19

    arturcic on master

    cleanup GitPreparer (compare)

  • 19:04
    warlock2k opened #2230
  • 19:04
    warlock2k labeled #2230
  • 17:17
    warlock2k commented #2229
  • 17:10
    arturcic commented #2229
  • 17:09
    warlock2k commented #2229
  • 17:03
    arturcic commented #2229
  • 17:01
    warlock2k commented #2229
  • 16:54
    arturcic commented #2229
  • 16:52
    warlock2k commented #2229
  • 16:50
    warlock2k commented #2229
  • 16:50
    arturcic commented #2229
  • 16:48
    warlock2k commented #2229
  • 16:47
    stale[bot] closed #1811
  • 10:19
    warlock2k commented #2229
  • 09:58
    arturcic commented #2229
  • 09:56
    arturcic commented #2229
  • 09:55
    warlock2k commented #2229
  • 09:50
    arturcic commented #2229
  • 09:50
    warlock2k commented #2229
henrik eriksson
@henrik_GJ_Esson_twitter
Using gitversion 5.0.1. No concerns from our master branch, using trunk based development. But when on a release branch, gitversion fails
2019-09-17 17:23:13 INFO [09/17/19 17:23:13:36] Begin: Finding branch source of 'release/6.0'
2019-09-17 17:23:13 INFO [09/17/19 17:23:13:44] End: Finding branch source of 'release/6.0' (Took: 78.12ms)
2019-09-17 17:23:13 INFO [09/17/19 17:23:13:44] End: Calculating base versions (Took: 3,055.39ms)
2019-09-17 17:23:13 ERROR [09/17/19 17:23:13:49] An unexpected error occurred:
System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.
at System.ThrowHelper.ThrowKeyNotFoundException()
at System.Collections.Generic.Dictionary2.get_Item(TKey key) at GitVersion.GitRepoMetadataProvider.<>c__DisplayClass15_0.<GetMergeCommitsForBranch>b__0(String sb) at System.Linq.Enumerable.WhereSelectListIterator2.MoveNext()
at System.Linq.Enumerable.AnyTSource
at System.Linq.Enumerable.WhereSelectEnumerableIterator2.MoveNext() at System.Linq.Enumerable.WhereEnumerableIterator1.MoveNext()
at System.Linq.Buffer1..ctor(IEnumerable1 source)
at System.Linq.OrderedEnumerable1.<GetEnumerator>d__1.MoveNext() at System.Collections.Generic.List1..ctor(IEnumerable1 collection) at System.Linq.Enumerable.ToList[TSource](IEnumerable1 source)
at GitVersion.GitRepoMetadataProvider.GetMergeCommitsForBranch(Branch branch, Branch[] excludedBranches)
at GitVersion.GitRepoMetadataProvider.FindCommitBranchWasBranchedFrom(Branch branch, Branch[] excludedBranches)
at GitVersion.VersionCalculation.BaseVersionCalculators.VersionInBranchNameBaseVersionStrategy.<GetVersions>d1.MoveNext()
at System.Linq.Enumerable.<SelectManyIterator>d
172.MoveNext() at System.Linq.Enumerable.WhereSelectEnumerableIterator2.MoveNext()
at System.Collections.Generic.List1..ctor(IEnumerable1 collection)
at System.Linq.Enumerable.ToListTSource
at GitVersion.VersionCalculation.BaseVersionCalculator.GetBaseVersion(GitVersionContext context)
at GitVersion.VersionCalculation.NextVersionCalculator.FindVersion(GitVersionContext context)
at GitVersion.GitVersionFinder.FindVersion(GitVersionContext context)
at GitVersion.ExecuteCore.<>cDisplayClass7_0.<ExecuteInternal>b0(IRepository repo)
at GitVersion.GitPreparer.WithRepositoryTResult
at GitVersion.ExecuteCore.ExecuteGitVersion(String targetUrl, String dynamicRepositoryLocation, Authentication authentication, String targetBranch, Boolean noFetch, String workingDirectory, String commitId, Config overrideConfig, Boolean noCache)
at GitVersion.SpecifiedArgumentRunner.Run(Arguments arguments, IFileSystem fileSystem)
at GitVersion.Program.VerifyArgumentsAndRun()
2019-09-17 17:23:13 INFO [09/17/19 17:23:13:49]
2019-09-17 17:23:13 INFO [09/17/19 17:23:13:49] Attempting to show the current git graph (please include in issue):
2019-09-17 17:23:13 INFO [09/17/19 17:23:13:49] Showing max of 100 commits
2019-09-17 17:23:14 INFO [09/17/19 17:23:14:08] *
Is this a known issue? What could the issue be?
henrik eriksson
@henrik_GJ_Esson_twitter
the exception in a more readable format
2019-09-18 15:26:00            INFO [09/18/19 15:26:00:61] Begin: Finding branch source of 'release/6.1'
2019-09-18 15:26:00            INFO [09/18/19 15:26:00:64] End: Finding branch source of 'release/6.1' (Took: 37.90ms)
2019-09-18 15:26:00          INFO [09/18/19 15:26:00:65] End: Calculating base versions (Took: 3,925.10ms)

2019-09-18 15:26:00          ERROR [09/18/19 15:26:00:68] An unexpected error occurred:
System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.
   at System.ThrowHelper.ThrowKeyNotFoundException()
   at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
   at GitVersion.GitRepoMetadataProvider.<>c__DisplayClass15_0.<GetMergeCommitsForBranch>b__0(String sb)
   at System.Linq.Enumerable.WhereSelectListIterator`2.MoveNext()
   at System.Linq.Enumerable.Any[TSource](IEnumerable`1 source, Func`2 predicate)
   at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext()
   at System.Linq.Enumerable.WhereEnumerableIterator`1.MoveNext()
   at System.Linq.Buffer`1..ctor(IEnumerable`1 source)
   at System.Linq.OrderedEnumerable`1.<GetEnumerator>d__1.MoveNext()
   at System.Collections.Generic.List`1..ctor(IEnumerable`1 collection)
   at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
   at GitVersion.GitRepoMetadataProvider.GetMergeCommitsForBranch(Branch branch, Branch[] excludedBranches)
   at GitVersion.GitRepoMetadataProvider.FindCommitBranchWasBranchedFrom(Branch branch, Branch[] excludedBranches)
   at GitVersion.VersionCalculation.BaseVersionCalculators.VersionInBranchNameBaseVersionStrategy.<GetVersions>d__1.MoveNext()
   at System.Linq.Enumerable.<SelectManyIterator>d__17`2.MoveNext()
   at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext()
   at System.Collections.Generic.List`1..ctor(IEnumerable`1 collection)
   at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
   at GitVersion.VersionCalculation.BaseVersionCalculator.GetBaseVersion(GitVersionContext context)
   at GitVersion.VersionCalculation.NextVersionCalculator.FindVersion(GitVersionContext context)
   at GitVersion.GitVersionFinder.FindVersion(GitVersionContext context)
   at GitVersion.ExecuteCore.<>c__DisplayClass7_0.<ExecuteInternal>b__0(IRepository repo)
   at GitVersion.GitPreparer.WithRepository[TResult](Func`2 action)
   at GitVersion.ExecuteCore.ExecuteGitVersion(String targetUrl, String dynamicRepositoryLocation, Authentication authentication, String targetBranch, Boolean noFetch, String workingDirectory, String commitId, Config overrideConfig, Boolean noCache)
   at GitVersion.SpecifiedArgumentRunner.Run(Arguments arguments, IFileSystem fileSystem)
   at GitVersion.Program.VerifyArgumentsAndRun()
henrik eriksson
@henrik_GJ_Esson_twitter
Reported issue here: GitTools/GitVersion#1815
Gary Ewan Park
@gep13
@/all I have just converted the gittools user on NuGet.org into an Organisation, which will allow us to better administer the various GitVersion packages on NuGet.org. This should be a completeley transparent operation, but if you notice any problems, please let me know.
@asbjornu can you let me know your NuGet.org Username, and I will get you added to the Organisation.
Should I also add anyone else into the organisation?
Pascal Berger
@pascalberger
@gep13 I didn't do much on GitVersion lately, but if you want you can add me
Gary Ewan Park
@gep13
:+1:
Matthias Koch
@matkoch
any chance for a release package soon?
Stanley Goldman
@StanleyGoldman
:wave:
I wanted to use GitVersion in GitHub Actions and was naively using Ubuntu to build my .net core application in GitHub Actions, and realized that I needed to install it for Ubuntu
So I started making a GitHub Action that would install GitVersion so I could then use it in further GitHub Actions
I was encouraged by the 5.1.1 release: https://github.com/GitTools/GitVersion/releases/tag/5.1.1
because it was the first to have artifacts for each OS
I then realized that GitVersion is included by default with Windows based GitHub Actions
I still wanted what I wanted when I wanted it, so I created a GitHub Action for mac and linux that would install GitVersion 5.1.1
It was really just me wanting to know how to make a GitHub Action at that point
Stanley Goldman
@StanleyGoldman
all that said, I'm going to open the proper pull requests, to get GitVersion v5.1.1 included by default for linux and mac GitHub Actions
Mattias Karlsson
@devlead
InterestingšŸ¤”
Stanley Goldman
@StanleyGoldman
I'll link any future work in case you guys are still interested ;)
this is what makes it available to windows GitHub Actions
this is the issue i opened to get it added to mac/linux
and the PR
Artur
@arturcic
@StanleyGoldman have you considered to install the gitversion global tool instead? As .net ask is already installed on those images and can run the tool. Basically you could have something similar to https://marketplace.visualstudio.com/items?itemName=gittools.usegitversion
.net SDK
Stanley Goldman
@StanleyGoldman
yea, i definitely saw that
There are so many ways to use GitVersion, which is definitely great
i just always felt partial to using it on the command line
Gary Ewan Park
@gep13
@StanleyGoldman just to confirm... The Global Tool absolutley works from the command line.
Stanley Goldman
@StanleyGoldman
hey @gep13 :wave:... allow me to try again
lol :smile:
in the latest version of GitHub Actions, the new script-able CI system from GitHub
allows for Windows, Mac and Linux environments
on Windows environments, GitVersion is already installed by way of choco
on Mac and Linux environments, GitVersion is not
I'm currently migrating a pet project from AppVeyor to GitHub Actions, wanted to use linux, and I did not have choco by default on linux
Stanley Goldman
@StanleyGoldman
I responded by creating a GitHub Action that installs GitVersion in linux and mac: https://github.com/StanleyGoldman/setup-gitversion
After conversing with some coworkers, a maintainer of libgit2 also felt himself in the same corner, and implemented one for himself: https://github.com/ethomson/setup-gitversion
I realize it would be better to get GitVersion's command line tool installed into GitHub Actions for Linux and Mac environments
if nothing else, but for the sake of parity
i hope i've made sense of my verbal thought diarrhea earlier...
Gary Ewan Park
@gep13
Yip, it totally makes sense to get GitVersion installed by default on the base images that ship as part of GitHub Actions. I think there is still some merit in having a GitHub Action that installs the GitVersion .Net Global Tool though. That way, when using another image to run your GitHub Actions, you have the ability to install GitVersion on any OS that has .Net Core installed.