Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
kevin sproles
@kevinsproles
can't seem to get beautify to trigger on file save.
works fine when manually triggering it.
Glavin Wiechert
@Glavin001
For which language, @kevinsproles ?
kevin sproles
@kevinsproles
@Glavin001 HTML
kevin sproles
@kevinsproles
@Glavin001 SCSS as well
WEIDA KONG
@iadaking

Installing “atom-beautify@0.28.7” failed.Hide output…

spawn-sync@1.0.11 postinstall C:\Users\ADMINI~1\AppData\Local\Temp\apm-install-dir-11567-12976-7d72bu\node_modules\atom-beautify\node_modules\cross-spawn\node_modules\spawn-sync
node postinstall

npm

don't understand why
gh0stl4b
@gh0stl4b
Same here, it just hangs the process and that is it...
Glavin Wiechert
@Glavin001
Cross-spawn has been updated. Please try installing again. Thanks
Juan M Garcia
@kelvix
and pretty sure I'm officially stuck, something about the tree view having a directory on Linux causes the atom ui to "flash" when a beautify on save occurs sigh
Juan M Garcia
@kelvix
but if i fork it, clone it, and apm link --dev try to figure out why it doesn't work it works...
h3x3d
@h3x3d
Hello guys. I'm having trouble with configuring atom-beautify. It always indents with tabs, not with spaces, configured in jsbeautifyrc in project root, or even in plugin configuration directly
h3x3d
@h3x3d
so, i found the problem. If u have jsbeautifyrc file in ur home directory - it will use it unless there is a jsbeautifyrc near the current file. I think that project-wide settings must override global user settings
Austin Cheney
@prettydiff
@h3x3d I disagree. You can always overwrite a global config with a local config. When that no longer becomes true you can never overwrite a global config, which is bad because a global config will always be more generic and distant from the needs of local work.
@Glavin001 I have started off a wiki on Github. I have seen some really good info recently that can be applied to multiple users.
Glavin Wiechert
@Glavin001
Great thanks !
Michael Stramel
@stramel
Hey @Glavin001, I love this plugin and use it all the time. However, the update time takes forever for some reason. Is this normal? Also, this made me start thinking about the codebase, it is one single plugin for all these different language beautifiers. Would it make sense to structure it more like linter, where you have a main beautifier plugin that defines the API for each language beautifier to interface with and allows developers to install only beautifiers that they will use?
Glavin Wiechert
@Glavin001
Glavin001/atom-beautify#320
@stramel I'd recommend that issue, #320
Michael Stramel
@stramel
@Glavin001 Thanks, exactly what I was looking for
Glavin Wiechert
@Glavin001
Great
I would really appreciate feedback and any new ideas on this matter
The disadvantage with lazy loading the beautified dependencies being that it would need to be loaded when the beautified is used, so the first time the user uses the beautified after an update it will not immediately work.
Michael Stramel
@stramel
Hmm, how does linter get around it?
Glavin Wiechert
@Glavin001
Each linter are separate packages
So you must install linter, and linter-language etc
Michael Stramel
@stramel
oh, that's not what you meant by lazy loading?
nevermind
I think I like the approach linter took with separate packages
For instance, I never really use any beautifier other than a handful. So for me it is definitely beneficial to only load those handfuls. It would also make updates shorter since each package is small and managed separately
Glavin Wiechert
@Glavin001
I want Atom Beautify to be the one-stop place for all code beautification in Atom. As of #282, each beautifier is very light-weight itself (e.g. https://github.com/Glavin001/atom-beautify/blob/master/src/beautifiers/autopep8.coffee ) and it'd be annoying for me to maintain at least (currently) 15 small repos for each beautifier, when right now they are simply files. So I am not supportive of splitting into separate modules, as the linter package does.
Essentially, I picture it as Atom Beautify being able to recognize each language it supports and then effectively install each module upon usage. Like linter package, except auto-installing: you do not need to install linter and then linter-coffeescript, you simply install linter and try to lint CoffeeScript and it will detect that it is supported and install it for you.
Please leave your feedback on the Issue #320 :).
Austin Cheney
@prettydiff
I have been looking at this over the last two weeks. I am going to publish an update today that radically changes the architecture of Pretty Diff, and so I also plan to reduce the size of the npm package. The current package as of v1.13.8 is 8480kb. With my code changes that I am about to launch I anticipate the package will become about 2mb.
Glavin Wiechert
@Glavin001
great!!
Austin Cheney
@prettydiff
I am debating on whether I want to do the extra work to minify everything and reduce the weight to about 1.2mb
Glavin Wiechert
@Glavin001
Well 8mb to 2mb is great already.
I think typescript formatter was much bigger than that lol
Ekim Emre Yardimli
@yardimli
Hi I use atom-beautify :) Will it be possible to beautify only selected text in some future version? Also if file extension is php the html inside doesnt get formatted properly any workaround for this except changing the file extension temporarily ?
Austin Cheney
@prettydiff
@yardimli would you mind creating a github issue and pasting your code sample to a gist? github issue - https://github.com/Glavin001/atom-beautify/issues gist - http://gist.github.com/
Glavin Wiechert
@Glavin001
@yardimli Atom-Beautify has supported beautifying only selected text for many versions now. I think there is an issue with PHP beautifying only selected text though
See Glavin001/atom-beautify#453
Clem Freeman
@clemf
It seems like beautify doesn't work properly with twig, is this the case?
Austin Cheney
@prettydiff
clemf could you open an issue on Github and provide a code sample so that I can reproduce the problem? https://github.com/Glavin001/atom-beautify/issues
@clemf
Andrew Serff
@andrewserff
I assume I'm just missing a setting, but when I format jsx code, beautify is adding a newlines where I don't want it to - Is there a way to stop this? I don't see jsx in the settings and assume it's handled as part of javascript? I think it might be a line length issue? but it splits things on dots, and it is splitting properties like {{myvar}}, etc. I'd rather have long lines than super expanded code blocks on 10 lines...
oh i just found the jsx @prettydiff config section, but there seems to be no settings? is there some where else I need to look?
Austin Cheney
@prettydiff
@andrewserff would you be able to create a gist with some sample of code so that I can reproduce the problem?
Andrew Serff
@andrewserff
@prettydiff Here you go: https://gist.github.com/andrewserff/e53d0547533c38499573 You'll see two files a "before" file of what it looks like before I format. And then an "after" file of what is looks like post-beautify-ing. I did notice it seems to do this in a .js file too. But those lines aren't very long, so I don't think it's a line length issue anymore...
The js file I saw it happen in is also a React component written in ES6 with jsx in it as well...