Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
bufke
@david:burkesoftware.com
[m]
yeah now I only need 5 chat apps instead of 6 at all times 😢
james.kiger
@james.kiger:burkesoftware.com
[m]
Oh, super easy integration. Nice
bufke
@david:burkesoftware.com
[m]
/org-slug/settings/teams/ would be the main page for teams and a reasonable place to add text
but a user might be able to avoid that page since it's referenced elsehwere
james.kiger
@james.kiger:burkesoftware.com
[m]
Yeah, and since it's a list if we put it at the bottom and they have a lot of teams they might never see it
bufke
@david:burkesoftware.com
[m]
my vote - add a sentence to Create a New Team modal. Then add maybe 2-3 sentences to settings/teams
james.kiger
@james.kiger:burkesoftware.com
[m]
OK, that makes sense
bufke
@david:burkesoftware.com
[m]
It needs to convey that teams about about notifications and workflow. Organizations manage permissions.
I still think that's really dumb but not an issue we can easily tackle if we aim for api compat
Does that surprise anyone else in the community? That a org member who isn't in a team, can see all issues in said team.
james.kiger
@james.kiger:burkesoftware.com
[m]
"GlitchTip teams are for managing event notifications. View permissions are handled through organization membership."
Brendan Berkley
@BrendanBerkley_gitlab
you'd expect an admin to be able to see everything
bufke
@david:burkesoftware.com
[m]
yeah that makes sense
but even the lowest role "member" can view all issues
or is supposed to be able to :P in GT today they can't but we're talking about "fixing" that

organization membership

That could be a link that opens in a new tab

"GlitchTip teams are for managing issue notifications and workflow."
james.kiger
@james.kiger:burkesoftware.com
[m]
For the "invite member" page:
:Organization member status grants view access to all of an organization’s events handled by GlitchTip."
bufke
@david:burkesoftware.com
[m]
I know "workflow" is ambiguous, but it does/should have have subtle effects in the UI
james.kiger
@james.kiger:burkesoftware.com
[m]
ah, I see
bufke
@david:burkesoftware.com
[m]
One affect it does/should have is to hid projects from the user
it doesn't make it secure, it's more of a visual change for UX
please don't look at these projects you aren't in a team for
(but you can!)
I guess GT doesn't need to follow that UX decision
we can worry about UX later though - workflow is still a good term to say I think
I kind of like the idea that GT is more clear showing the user EVERYTHING they have permission for
best to make it explicit
james.kiger
@james.kiger:burkesoftware.com
[m]
Yeah, that makes sense
Thinking of adding that "organization member" note either to the end of the email note or directly under the permission selection options.
The ideal I think would be to have the text change to describe each of the four permission options, though I would need a little input on what all those differences are.
oliver drewes
@oliver.drewes_gitlab
Hi there, i am wondering which repo contains the django settings.py, as currently the static as also the media paths are hardcoded, which does not provide a usage in k8s as you have reverse proxies in front for normal use. Or is it an npm / frontend only issue?
bufke
@david:burkesoftware.com
[m]

It's here @oliver.drewes_gitlab https://gitlab.com/glitchtip/glitchtip-backend/-/blob/master/glitchtip/settings.py

I use whitenoise for static files and django-storages for media.

I'm not sure exactly what you're looking to achieve. I know GT works fine with volumes in docker compose and fine with external media on k8s.
oliver drewes
@oliver.drewes_gitlab
I want to use my glitchtip at www.url.com/glitchtip instead of the root /
bufke
@david:burkesoftware.com
[m]
Got it, it should be possible with some work on settings. I can't think of any fundamental reason it wouldn't be. I'm not sure if you'd have to modify the frontend or not as well. Happy to review any merge requests.
I could see the frontend being an issue to solve. The base url would change and it's not acceptable to set that during build time.
oliver drewes
@oliver.drewes_gitlab
Had a look already, this is rhe reson ehy we mostly build the webapps on container boot. An alternative would be to add routing options to the code. But i am neither familar with angular nor deeply with nodejs
Do you think a rewrite at boot would help by changing the base path? Like with a sed of the index file?
Found this article as the only appropriate result on my search: https://pretagteam.com/question/how-to-set-application-context-path-in-angular2-routing-properly
Chethan Prakash
@chethan
We are using log4j2 based sentry appender for glitchip everything is working seamlessly. One of the issues we see is that the grouping of the errors is not happening per template message, instead of that grouping is happening on the exact log message. Has anyone seen this and any way to resolve the same?

Example:

With log4j2, it’s expected that each log template will be grouped together. But not each time different variables values are used.

logger.info("User {} has logged in using id {}", map.get("Name"), user.getId());

In this case there should be 1 issue, regardless of the value of name and id.

bufke
@david:burkesoftware.com
[m]
Regarding base path - sed sure seems not ideal. A nice thing about our current set up is that the angular bundle is just a static bundle and doesn't know anything about Django. And Django doesn't need to know anything about angular. It just serves it. That very nice simplicity is not great if you want to pass information such as base path from a Python env var to Angular. I'm open to proposals. I understand the use case of having a variable base path.
Regarding how we group events @chethan - I believe the message string is generated by older sentry open source code ported to python 3. If my memory is correct, the grouping of events is very simple and based on message. You could look at how the old open source sentry handles your events for comparison. If you like the way OSS Sentry does it more, you could port that code or find out why it doesn't work already. Though we don't strictly have to follow sentry here as it wouldn't have anything to do with API compatibility. I would probably lean towards a good default that could apply some level of fuzzy logic on matching like events. But I'd defer to anyone willing to put in the work. I think Sentry had some more options on ways this logic could be customized but I never really used that.
Chethan Prakash
@chethan
@david:burkesoftware.com Thanks for the response. I will have a look at it.
james.kiger
@james.kiger:burkesoftware.com
[m]
I am pleased to announce that GlitchTip 1.9, introducing frontend support for Uptime Monitoring, has been released:
https://glitchtip.com/blog/2021-11-30-glitchtip-1-9
bufke
@david:burkesoftware.com
[m]
How do people use notifications in the real world? Any feature requests? Uptime monitoring has very limited notifications in this initial feature release.