These are chat archives for HdrHistogram/HdrHistogram

7th
Jul 2015
Todd L. Montgomery
@tmontgomery
Jul 07 2015 15:15
@mikeb01 any reason that clang is required for HdrHistogram_c?
Michael Barker
@mikeb01
Jul 07 2015 21:07
@tmontgomery Just checked against g++ now. There were a couple of variable names that g++ didn't like in the test code, which I've fixed. It builds and runs okay with g++ 5.1.1.
I raised a bug with an earlier version of g++ https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59874 which is why I'd been using clang.
The 'C' compiler for gcc would work okay, it was specifically the C++ compiler that was giving me grief.
Todd L. Montgomery
@tmontgomery
Jul 07 2015 21:19
ah. ok. Was just curious mainly.
Michael Barker
@mikeb01
Jul 07 2015 21:20
If the g++ bug is giving you grief, let me know. There is a workaround that I could apply, but it will mean a degradation in performance for recording samples.
Todd L. Montgomery
@tmontgomery
Jul 07 2015 21:22
no worries. I was looking for ease of building for Aeron C++ API since it brings it in
I may play around with adding a disable for zlib.h for MSVC at some point just to see if it can build
it's not a problem, really
Michael Barker
@mikeb01
Jul 07 2015 21:23
Yeah, I haven't tried building it on MSVC. I used a bunch of c99 stuff so I wasn't sure how it would behave and I don't have an environment to test it on. Some of the logging stuff just won't work.
Have a look at hdr_time.h, that is the one place where I have an OS #ifdef, so it will probably cause a compile failure on windows. If you know an equivalent function on Windows I'd be happy to include it.
Todd L. Montgomery
@tmontgomery
Jul 07 2015 21:26
it's not bad. QueryPerformanceCounter probably will work.
Michael Barker
@mikeb01
Jul 07 2015 21:28
Cheers, I'll have a look. Fortunately the platform specific stuff is only used in the examples and the tests.
The basic data structure should be okay. The gcc builtins might cause some grief on MSVC
Todd L. Montgomery
@tmontgomery
Jul 07 2015 21:30
I'd have to look, but MSVC probably has equivalents. It does have clz, but no ctz (much to my chagrin)
after Aeron is in maven, I'll take a look