Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Joseph Musser
    @jnm2
    However, your request is basically the same as mine (#404) where I want to keep 3D as 3D and not 3 d. @MehdiK said "if more users get behind this request, we'll implement it."
    Kevin Watkins
    @MrKWatkins
    @aloisdg Using string replace gets pretty messy in general:
    • Depending on the humanize options/method used I'd also need to replace "robo cop" and "Robo Cop".
    • I'd have to do that everywhere I used humanize. I could wrap that up in extension methods of course so not a massive pain but I'd still have to do that for every humanize method.
    • I have an annoying edge case where one of the words in another case also makes sense as the two separate words... I.e. so I have the two cases "robo cop".Humanize() and "RoboCop".Humanize(), which I'd like to become "Robo cop" and "RoboCop" respectively.
    @jm2 I've added a comment to #404 adding my use case, thanks.
    Joseph Musser
    @jnm2
    s/jm2/jnm2
    100% with you on string.Replace. Yuck.
    The solution would have to be searching every upper-case-containing word from every capital letter or digit in the string. Not great for a general .Humanize(), perf-wise. A regex will create a fast state machine for you from a custom dictionary but even so. It might have to be opt-in.
    Joseph Musser
    @jnm2
    @MrKWatkins
    Oren Novotny
    @onovotny
    @aloisdg @mexx @hazzik: I'd like to try to get a release of Humanizer out on/around June 27 that supports .NET Standard
    can you please see if you can merge in any outstanding PR's that you think are good to go?
    Alois
    @aloisdg
    Nice. I saw earlier that esperanto is now supported. I can add it for this release. (see #558 ) I think It is better to postpone the support of "avant hier" and "apr├Ęs demain" (see #543 ). I wont have the time to digg it right now.
    Oren Novotny
    @onovotny
    sure
    Alois
    @aloisdg
    I have an important project for my school to finish before the 18. I may not make the PR before this date.
    Oren Novotny
    @onovotny
    totally ok, the release won't be until the 24-27th when we know the final .net corefx build
    Alois
    @aloisdg
    fine :)
    Oren Novotny
    @onovotny
    appreciate your efforts :)
    Alois
    @aloisdg
    Thank you! Appreciate yours too!
    Joseph Musser
    @jnm2
    @onovotny I finished #555 and have two problems: 1) build.cmd gives me
      Error reading 'C:\Users\jmusser\Source\Repos\Humanizer\src\Humanizer.Tests.DotNet\project.json' at line 24 column 27
      : TODO: unknown keyword platform
        TODO: unknown keyword platform
    C:\Users\jmusser\Source\Repos\Humanizer\build.proj(53,5): error MSB3073: The command ""C:\Users\jmusser\Source\Repos\Hu
    manizer\tools\NuGet\NuGet.exe" restore "C:\Users\jmusser\Source\Repos\Humanizer\src\Humanizer.DotNet.sln"" exited with
    code 1.
    2) approve_public_api happened when I added StringJoinOptions. What's the procedure with that?
    Joseph Musser
    @jnm2
    @aloisdg have you run into this?
    Alois
    @aloisdg
    @jnm2 didnt try yet. I am trying to generate a nuget package for another project :p
    Joseph Musser
    @jnm2
    No problem. I'm probably stuck on a rookie problem, not knowing what bits I need to install. It would be great if CONTRIBUTING.md had guidance on these two things.
    Alois
    @aloisdg
    Feel free to improve it ;)
    Joseph Musser
    @jnm2
    @onovotny ping
    Do I submit the changed approve_public_api to you? What is the process?
    Joseph Musser
    @jnm2
    Is it going to be a compatibility issue?
    Oren Novotny
    @onovotny
    just please include that with the PR
    it all gets reviewed together
    that doc is just a sanity check to catch surface changes
    Joseph Musser
    @jnm2
    Okay. Looks like I need to install .net core rc2 in order to follow CONTRIBUTING.MD and run build.cmd. @onovotny can I skip that and run tests on full framework within Visual Studio instead?
    Oren Novotny
    @onovotny
    that should be fine for now
    note that once the GA is out next week that it'll be updated to use that
    Alois
    @aloisdg
    Hello, is there a document to show how to build the project? I tried to run build.ps1 but I get:
    PS C:\Users\alois\Source\Repos\NewRepo> .\build.ps1
      MSBuild auto-detection: using msbuild version '14.0' from 'C:\Program Files (x86)\MSBuild\14.0\bin'.
      Error reading 'C:\Users\alois\Source\Repos\NewRepo\src\Humanizer.Tests.DotNet\project.json' at line 24 column 27 : TODO: unknown ke
      yword platform
        TODO: unknown keyword platform
    C:\Users\alois\Source\Repos\NewRepo\build.proj(53,5): error MSB3073: The command ""C:\Users\alois\Source\Repos\NewRepo\tools\NuGet\Nu
    Get.exe" restore "C:\Users\alois\Source\Repos\NewRepo\src\Humanizer.DotNet.sln"" exited with code 1.
    Oren Novotny
    @onovotny
    probably needs Update 3 installed
    and/or a later version of nuget
    Alois
    @aloisdg
    indeed. I am using Update 2
    Update3 is released? VS didnt show the update.
    Alois
    @aloisdg
    Update started... See you tomorrow :)
    Oren Novotny
    @onovotny
    not yet
    Alois
    @aloisdg
    ok
    Joseph Musser
    @jnm2
    Fwiw I built and tested using Update 2 and skipped build.cmd because Oren gave me the okay.
    I've got too much going on to have the luxury of installing pre-release bits of things in general :-(
    Been time-consuming in the past.
    Alois
    @aloisdg
    I dont mind getting the update, but as you said it would be nice to see it in the Contributing.md file
    If Update3 fixed it, I will make a PR to add this in it
    @onovotny What do you think?
    Alois
    @aloisdg
    Well Update3 didnt fix it, but I least I can run the sln in VS.
    Joseph Musser
    @jnm2
    Btw Update 3 RTM is live just now
    Humanizer 2.1 is live now!
    Alois
    @aloisdg
    cool :smile: