Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Oct 06 2016 20:39

    johmanx10 on master

    Use variadic inputs in the Invo… Merge pull request #49 from Mar… (compare)

  • Oct 06 2016 20:39
    johmanx10 closed #49
  • Oct 06 2016 19:29
    MarkRedeman opened #49
  • Sep 11 2016 12:09

    johmanx10 on master

    Change class assertions into re… (compare)

  • Sep 11 2016 12:09

    johmanx10 on master

    Change class assertions into re… (compare)

  • Sep 11 2016 11:15

    johmanx10 on master

    Fixed signature Merge branch 'master' of github… (compare)

  • Sep 11 2016 11:15

    johmanx10 on master

    Merge pull request #46 from joh… Merge pull request #47 from joh… Merge pull request #48 from joh… and 1 more (compare)

  • Sep 11 2016 11:14

    johmanx10 on master

    Fixed signature (compare)

  • Sep 11 2016 11:13

    johmanx10 on master

    Solve the Mediator pattern with… Fix dev requirements Merge pull request #48 from joh… (compare)

  • Sep 11 2016 11:13
    johmanx10 closed #48
  • Sep 11 2016 11:11
    johmanx10 assigned #48
  • Sep 11 2016 11:11
    johmanx10 opened #48
  • Sep 11 2016 11:11

    johmanx10 on master

    Fix dev requirements (compare)

  • Sep 11 2016 11:07

    johmanx10 on master

    Solve the Mediator pattern with… (compare)

  • Sep 11 2016 10:54

    johmanx10 on master

    Added example for the Mediator … Added example for the Mediator … Merge pull request #47 from joh… (compare)

  • Sep 11 2016 10:54
    johmanx10 closed #47
  • Sep 11 2016 10:52
    johmanx10 opened #47
  • Sep 11 2016 10:52
    johmanx10 assigned #47
  • Sep 11 2016 10:51

    johmanx10 on master

    Added example for the Mediator … (compare)

  • Sep 11 2016 10:49

    johmanx10 on master

    Added example for the Mediator … (compare)

Jan-Marten de Boer
@johmanx10
Hey Guys. I found this to be a perfect way to centralize public communication about the HylianShield organisation and over here the validator repo, specifically
So, @a-schuurman might be happy to know I'm currently writing tests against local modifications I made to the Network validator, in an effort to reduce cyclomatic and NPath complexity. To do this, I have introduced a ProtocolDefinitionInterface which tells the Network validator how to set up rules and parsers to validate incoming URLs. To properly test this, I have introduced a CustomProtocol validator in the Network namespace. This means you can determine schemes, ports, query parameters and restrictions on-the-fly if the default validators don't seem to meet your criteria
It is also a really small addition away from supporting schemeles URLs
Jan-Marten de Boer
@johmanx10
Crap, the complexity of the network validator is still too high
Jan-Marten de Boer
@johmanx10
That should be resolved now
Jan-Marten de Boer
@johmanx10
Most hacky unit test I have ever written:
    /**
     * Test that the constructor throws when the filter is mis-configured.
     *
     * @return void
     * @expectedException \LogicException
     * @expectedExceptionMessage Invalid filter configured!
     */
    public function testIllegalFilter()
    {
        $validator = clone $this->validator;
        $reflection = new \ReflectionObject($validator);

        $property = $reflection->getProperty('filter');
        $property->setAccessible(true);
        $property->setValue($validator, null);
        $property->setAccessible(false);

        $reflection
            ->getConstructor()
            ->invoke($validator);
    }
Just call the constructor again on an already initialized and cloned object. No biggy ><
Jan-Marten de Boer
@johmanx10
Yay, all done. Let's have weekend now... XD
Jan-Marten de Boer
@johmanx10
Version 0.9.0 is released
Jan-Marten de Boer
@johmanx10
Note to self: Do not use Gitbook on a main branch and do not use Gitbook with their own editor, as every change is an actual commit on the repository