Where communities thrive

  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
Repo info
    figured it might be useful, was waiting to see how long before someone else found it
    realitygaps @realitygaps connected via irc tho
    Anne Jan Brouwer
    Just found it today
    I'm reading through MainWindow::config
    (I had to modify it twice so far)
    but I'm not really sure how to handle it
    it seems vital and also quite complicated(long)
    what is it's relation with MainWindow::checkConfig?
    any user stories for those functions? or high-lever overview?
    another thing that gets to my mind recently are decorators
    I think there is more use cases, but ie. mountWebDav
    could do great as decorator
    MW just loads pass-store(asynchronously) and displays itself
    (most options disabled)
    and waits for PassLoaded signal
    Anne Jan Brouwer
    the config is terribly set-up see IJHack/QtPass#235
    I'm trying to clean it up .. but currently don't have the time
    the webdav stuff I have never touched
    that was all @rdoeffinger
    the checkconfig is mostly needed for first time
    and in the configdialog there is a wizard that's also weird
    Anne Jan Brouwer
    that was me . . mostly
    realitygaps @realitygaps considering bridging the channel to the irc one
    good to know, I want touch config stuff then
    it would be nice to have one function for all initial config loading and reloading later
    so that there is one place to add/modify things
    (of course if possible)
    I haven't looked at wizard's source code, but it seems all right from UX perspective
    allows to set up everything quickly
    I even regret that it's not possible to call it directly from menu or smth to create more keys
    Anne Jan Brouwer
    @tezeb check out the develop branch for that
    have weird issues though
    the config cleanup
    @annejan is there a reason for executing processes as a concatenated string(ie. process.start(app + " " + args + " ")) and not as QStringList as defined in interface?
    ie. process.start(app, {arg1, arg2, arg3...}) // assuming c++11
    I think about changing it, but I would prefer not to break some compatibility with some odd OS or smth
    Anne Jan Brouwer
    mmm .. nope should be good as a string list too . . if I recall correctly
    this is over 2 years ago though (summer 2014) so I can't be sure . .
    Anne Jan Brouwer
    I'm going for a 1.1.6 release with just bugfixes
    no new features
    just to clear the air ;)
    it's 1.1.5 with just the bugfixes
    :shipit: or should I take in some more urgent changes tot 1.1.5 ??
    Anne Jan Brouwer
    :thumbsup: released