Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Apr 21 2016 19:16
    Anirudh94 closed #44
  • Apr 21 2016 19:16
    Anirudh94 commented #44
  • Apr 21 2016 19:15
    Anirudh94 opened #44
  • Apr 21 2016 19:14
    Anirudh94 opened #43
  • Apr 10 2016 23:30
    Ian-Stewart-Binks closed #11
  • Apr 10 2016 23:30
    Ian-Stewart-Binks commented #11
  • Apr 10 2016 23:29

    Ian-Stewart-Binks on master

    Use react to generate foosball … Merge pull request #41 from Ani… (compare)

  • Apr 10 2016 23:29
    Ian-Stewart-Binks closed #41
  • Apr 10 2016 23:28

    Ian-Stewart-Binks on moving-table

    (compare)

  • Apr 10 2016 23:21

    Anirudh94 on master

    Update moving-table rule Signe… Merge pull request #42 from Ian… (compare)

  • Apr 10 2016 23:21
    Anirudh94 closed #42
  • Apr 10 2016 23:21
    Anirudh94 reopened #42
  • Apr 10 2016 23:21
    Anirudh94 closed #42
  • Apr 10 2016 23:21
    Anirudh94 commented #42
  • Apr 10 2016 20:57

    Ian-Stewart-Binks on remove-scraper

    (compare)

  • Apr 10 2016 20:57

    Ian-Stewart-Binks on master

    Remove Scraper Signed-off-by: … Merge pull request #40 from Ian… (compare)

  • Apr 10 2016 20:57
    Ian-Stewart-Binks closed #40
  • Apr 10 2016 20:57
    Ian-Stewart-Binks commented #40
  • Apr 10 2016 20:56
    Ian-Stewart-Binks opened #42
  • Apr 10 2016 20:56

    Ian-Stewart-Binks on moving-table

    Update moving-table rule Signe… (compare)

Ian Stewart-Binks
@Ian-Stewart-Binks
Yes.
Each object itself would be contained in an array
Anirudh Mukundan
@Anirudh94
what do u mean?
Ian Stewart-Binks
@Ian-Stewart-Binks
[{
  "name": "string",
  "contents": ["rules"]
},
{
  "name": "string",
  "contents": ["rules"]
},
{
  "name": "string",
  "contents": ["rules"]
}
]
Anirudh Mukundan
@Anirudh94
oh yep thats what i want
so schema per rule and 'rules' is just an array
of rule objects
one problem to note is ensuring an order
being a website we may want certains rules towards the top dunno
well its not a problem so much as something to keep in mind
Ian Stewart-Binks
@Ian-Stewart-Binks
The schema can change
Emmett Underhill
@emmettu
I could adjust the the schema to parse as such
also I'd like to give myself at least some recognition in saying that scrape.py does work. However the html does not have a consistent format
so if we want the rules to be perfect then in my opinion we should just do it by hand
Ian Stewart-Binks
@Ian-Stewart-Binks
@emmettu It was a good attempt.
Anirudh Mukundan
@Anirudh94
@emmettu np yo, the html wasnt consistent
Ian Stewart-Binks
@Ian-Stewart-Binks
And if you think we should just do it by hand, then you should note that at an earlier point. Also, if the scraper doesn't do a good job, you should note that in the PR description.
In the future, I'll make sure to run the code and check the output.
Emmett Underhill
@emmettu
I did check the output
nevermind I misread
You're right it should have been noted in the PR description. Also the dialogue from the very beginning of this feature was that it might not be practical
Ian Stewart-Binks
@Ian-Stewart-Binks
I vote that we do not fall back on the rules of foosball.com
And that we port over rules that we like, incrementally.
The current system of falling back on 'official' foosball rules is flawed.
/all thoughts?
Anirudh Mukundan
@Anirudh94
+1
Emmett Underhill
@emmettu
@/all I'm pretty sure you still need to @ in front of all when you ping everyone
just a heads up
Anirudh Mukundan
@Anirudh94
@emmettu yep seems you're right
Ian Stewart-Binks
@Ian-Stewart-Binks
Yep.
Anirudh Mukundan
@Anirudh94
i just saw the html source for abridged i think you can def parse it manually tho
like char by char lol
dunno about soupy juice or wtv
but itll be easier to copy paste than doing that xD
Emmett Underhill
@emmettu
char by char?
how would that work?
tbh yes you probably can do it my point was it would be such a specific parsing script that you might as well just do it by hand
Anirudh Mukundan
@Anirudh94
yeye
unless they suddenly start updating the site every few weeks
Emmett Underhill
@emmettu
yeah and then it still wouldn't be worth it because if you write a very specific parser you would need to update it every time the site is updated
which is the problem.
the site doesn't have a consistent enough html format to parse it generally
Anirudh Mukundan
@Anirudh94
lol
send them better html since itll be more convenient for us
honestly if they accepted we could easily put in 'backdoors' to change the rules ;)
well assuming they accepted AND blindly deployed it
Anirudh Mukundan
@Anirudh94
@Ian-Stewart-Binks So I don't know how comfortable you are, but since you've actually deployed stuff like coureography before I'm going to assume you're better than me at web development
I've developed sites with basic HTML/CSS and Node/python backend before but this React stuff is confusing to me
do u suggest I start off learning with a simpler templating engine first or is it ok to jump straight in?
Ian Stewart-Binks
@Ian-Stewart-Binks
@Anirudh94 Sorry, I didn't get notified of this. What do you mean by jumping right in?