These are chat archives for Ian-Stewart-Binks/Foosball

9th
Mar 2016
Anirudh Mukundan
@Anirudh94
Mar 09 2016 14:56
uhh sorry guys for not being too attentive...
Emmett Underhill
@emmettu
Mar 09 2016 15:38
lol it's ok it's a hobby project
don't get stressed about it
Anirudh Mukundan
@Anirudh94
Mar 09 2016 19:17
@emmettu yo where is parse_long() being used? i.e. what is calling that method?
Anirudh94 @Anirudh94 asks u to be patient with python noob in case he was being dumb
Anirudh Mukundan
@Anirudh94
Mar 09 2016 19:18
this is regarding #30
Emmett Underhill
@emmettu
Mar 09 2016 19:27
@Anirudh94 not called anywhere it's just part of the api
it returns a really shitty parse of the long htlm
Anirudh Mukundan
@Anirudh94
Mar 09 2016 19:28
@emmettu oh its just like api that you can use if u want but actually used atm?
i get what it does, was just curious why it was there, but yeah sure im good with including it
Emmett Underhill
@emmettu
Mar 09 2016 19:31
yes it's optional
Anirudh Mukundan
@Anirudh94
Mar 09 2016 19:31
@emmettu cool good thinking
Emmett Underhill
@emmettu
Mar 09 2016 19:31
I guess that raises a good point though: the main method should not be part of the scrape module
Anirudh Mukundan
@Anirudh94
Mar 09 2016 19:33
hmm
even though thats true i like the idea of scrape being a self contained script
if u mean separating it into another file lets just not worry about it for now
@Ian-Stewart-Binks ?
Anirudh Mukundan
@Anirudh94
Mar 09 2016 19:46
but yeah i basically have no real problems functionally with the code, @emmettu lemme know when you're ready and i'll merge it
Emmett Underhill
@emmettu
Mar 09 2016 20:02
Are we squashing?
Emmett Underhill
@emmettu
Mar 09 2016 20:13
Are we squashing commits?
Anirudh Mukundan
@Anirudh94
Mar 09 2016 20:16
@emmettu its up to you
squash unless u feel it deserves to be a seperate commit in the history
basically if you can compress until the commit message accurately covers everything that was done in the patch, otherwise separate patch
Emmett Underhill
@emmettu
Mar 09 2016 20:22
lol I mean, how do we feel about our commit history
atomic commits or feature commits?
Anirudh Mukundan
@Anirudh94
Mar 09 2016 20:49
@emmettu idk wtv
Emmett Underhill
@emmettu
Mar 09 2016 20:50
@Ian-Stewart-Binks wdyt?
Anirudh Mukundan
@Anirudh94
Mar 09 2016 21:31
@emmettu i don't think either of us have a specific idea, do whatever u think is best, and if u think it warrants some kind of thought add a note about it to readme or contributing.md
@emmettu one thing I would like is that all commits start with some kind of action verb "Fix...","Create...","Add..." etc.
Its generally more informative so instead of, say, "Treemap Implementation" use "Add treemap to heapdump viewer"
Emmett Underhill
@emmettu
Mar 09 2016 21:48
lol good examples
Emmett Underhill
@emmettu
Mar 09 2016 21:59
I squashed the readme commits so just merge whenever
@Anirudh94
Anirudh Mukundan
@Anirudh94
Mar 09 2016 22:14
@emmettu nothing seems to be squashed
wanna just squash everything
?
taking a closer look i don't think any of those changes need to be a separate commit
Ian Stewart-Binks
@Ian-Stewart-Binks
Mar 09 2016 22:16
@Anirudh94 pls merge #32
Emmett Underhill
@emmettu
Mar 09 2016 22:16
I squashed the last 4 readme commits
@Anirudh94
not the whole thing
Anirudh Mukundan
@Anirudh94
Mar 09 2016 22:17
@emmettu u sure we want 11 commits for this?
i think we shouldnt have more than 2
Emmett Underhill
@emmettu
Mar 09 2016 22:18
did we make up our minds on what commit style we want then?
because if we did then I guess I should here it
Anirudh Mukundan
@Anirudh94
Mar 09 2016 22:20
@emmettu also fyi u need to rebase on latest
no conflicts
Emmett Underhill
@emmettu
Mar 09 2016 22:28
squashed
feel free to merge once the ci job finishes