@ByteJuggler handling redirects should not be affecting TIdHTTP's ability to handle authentication. If anything, a redirect simply resets the
AuthRetries and ProxyAuthRetries counters, giving TIdHTTP more chances to continue authentication attempts. Please don't assume what you think is happening, debug and find out exactly what is really happening.
@elekgeek the preferred way to use
TIdTCPServeris to use blocking I/O that follows a defined protocol, raising exceptions on errors/disconnects/shutdowns, and let the server handle the exceptions. If you skip that logic, you become responsible for handling certain things manually, like shutdown. For instance, you could set a variable before setting Active=False (or, just look at Active itself, since it is toggled to false before thread shutdowns occur), and then have OnExecute look at that variable, and if set then call AContext.Connection.Disconnect, or raise your own exception, before exiting the event.
@elekgeek the code I gave works just fine for shutting down clients. So, the most likely possibility is if
Log() itself is deadlocking, such as if it tries to synchronize with the main UI thread while the main UI thread is blocked waiting for the server to finish shutdown. Do not synchronize with the thread that is shutting down the server, that is a guaranteed deadlock. Either skip the synched operation during shutdown, or use a separate worker thread to shutdown the server so syncs can still be processed.
@elekgeek As for "rubbish text", that is just because of the use of the 8bit encoding, which stores each byte as-is as a separate
char and your code is not accounting for that. You can't use UTF-8 unless you ensure complete byte sequences for multi-byte characters, but your original code was not doing that. What kind of protocol is your server implementing? If the text is line-based, for instance, then you could just use TIdIOHandler.ReadLn(), in which case using UTF-8 would be OK. But if you use ReadBytes(-1) or ExtractString(-1) or InputBufferAsString then all guarantees about the completeness of multi-byte sequences go out the window
@rlebeau this has worked for me and solved my problem:
with IdTCPServer1.Contexts.LockList do
try
for iA := Count - 1 downto 0 do
begin
Context := Items[iA];
if Context = nil then
Continue;
Context.Connection.IOHandler.WriteBufferClear;
Context.Connection.IOHandler.InputBuffer.Clear;
Context.Connection.IOHandler.Close;
if Context.Connection.Connected then
Context.Connection.Disconnect;
end;
finally
IdTCPServer1.Contexts.UnlockList;
IdTCPServer1.Active := False;
end;What do you think?
This code also suggested by you works very well:
with AContext.Connection.IOHandler do
begin
CheckForDataOnSource(10);
CheckForDisconnect; // <-- add this
if not InputBufferIsEmpty then
begin
RxBufStr := InputBufferAsString(IndyTextEncoding_8Bit); // <-- don't assume any encoding
Log(RxBufStr);
Write(RxBufStr, IndyTextEncoding_8Bit); // <-- use TIdIOHandler.Write() instead
end;
end;Now my question:
- why were you not been able to suggest such a solution, no offense intended, but for sure you have a good reason.
- How can the client check if the server went down and close its own connection?
@elekgeek you don't need any of that. Just set
Active to false, it already disconnects the clients for you, and then waits for their threads to terminate. Your issue is that your code is blocking the threads from terminating correctly. That is what you need to fix properly, not hack around it.
and BTW
procedure TForm2.Log(const s: string);
begin
mLog.Lines.Add(s);
end;@elekgeek your Log() function is directly accessing a UI component (a TMemo?). THAT IS NOT THREAD-SAFE! That could easily cause deadlocks (amongst many other problems). OnExecute is fired in a worker thread, so Log() MUST synchronize with the main UI thread. I suggest it use TThread.Queue() or TIdNotify for that purpose (depending on your version of Delphi). That would avoid any cross-thread access issues, avoid any deadlock scenarios, and avoid blocking the OnExecute code (which should not need to wait on the UI to display log messages). For example:
procedure TForm2.Log(const s: string);
begin
TThread.Queue(nil,
procedure
begin
mLog.Lines.Add(s);
end
);
end;or:
uses
..., IdSync;
type
TLog = class(TIdNotify)
protected
FMsg: string;
procedure DoNotify; override;
public
constructor Create(const s: string); reintroduce;
end;
constructor TLog.Create(const s: string);
begin
inherited Create;
FMsg := s;
end;
procedure TLog.DoNotify;
begin
Form2.mLog.Lines.Add(FMsg);
end;
procedure TForm2.Log(const s: string);
begin
TLog.Create(s).Notify;
end;
@klsyzzz NTLM support in Indy is spotty at best. There are two different NTLM classes available for TIdHTTP - TIdNTLMAuthentication in IdAuthenticationNTLM.pas (portable but untested), and TIdSSPINTLMAuthentication in IdAuthenticationSSPI.pas (Windows only). In theory, you should be able to just add one of those units to your uses clause and let TIdHTTP handle the rest. In practice, .... umm, good luck? They either work or they don't. I have no way of testing either one, as I have no access to any HTTP servers that use NTLM
hi @rlebeau , I added IdAuthenticationNTLM.pas to my uses clause, and created an instance of TidHTTP, what I need to do next to enable NTLM auth? I didn't find any property on TidHTTP to select auth type, do I need to do the following:
auth := TIdNTLMAuthentication.Create;
IdHTTP1.AuthenticationManager.AddAuthentication(auth);
auth := TIdNTLMAuthentication.Create;
IdHTTP1.AuthenticationManager.AddAuthentication(auth);
@klsyzzz just add the unit to the uses clause to register the class with TIdHTTP. TIdHTTP should then automatically use the class on any server that supports NTLM (though you can use the TIdHTTP.OnSelectAuthorization event to make sure that is what TIdHTTP picks, if multiple authentications are supported and registered). Now put your NTLM credentials in the TIdHTTP.Request.UserName and TIdHTTP.Request.Password properties, and assign a TIdHTTP.OnAuthorization event handler to promt the user for new credentials if the initial credentials don't work
I'm using a TIdIPMCastClient, and the following code:
procedure TForm1.FormCreate(Sender: TObject);
var
I: Integer;
begin
BroadcastListenerIPv6.DefaultPort := 6000;
for I := 0 to BroadcastListenerIPv6.Bindings.Count - 1 do
BroadcastListenerIPv6.Bindings.Items[I].Port := BroadcastListenerIPv6.DefaultPort;
BroadcastListenerIPv6.MulticastGroup := 'FF02:0:0:0:0:0:0:1';
BroadcastListenerIPv6.Active := True;
end;
@DelphiWorlds of course you need to have something setup on the network that will be sending packets to the group, and you need to know what that group is ahead of time. What else are you going to listen for packets from? TIdIPMCastClient joins a group. Anyone can send packets to the same group, and they will be delivered to whoever is joined
procedure TForm1.FormCreate(Sender: TObject);
var
I: Integer;
begin
BroadcastServerIPv6.Port := 6000;
BroadcastServerIPv6.MulticastGroup := 'FF02:0:0:0:0:0:0:1';
BroadcastServerIPv6.Active := True;
BroadcastListenerIPv6.DefaultPort := 6000;
for I := 0 to BroadcastListenerIPv6.Bindings.Count - 1 do
BroadcastListenerIPv6.Bindings.Items[I].Port := BroadcastListenerIPv6.DefaultPort;
BroadcastListenerIPv6.MulticastGroup := 'FF02:0:0:0:0:0:0:1';
BroadcastListenerIPv6.Active := True;
end;
Still does not work
Same error, i.e. 49 (Address invalid)
@DelphiWorlds well, you didn't say that earlier. That is an OS error, not an Indy error. Where exactly are you seeing that error? What local IP(s) are you binding the client to? You are only setting TIdSocketHandle.Port in code, are you leaving TIdSocketHandle.IP blank? I don't know if you can do that when joining a multicast group as a client
the client binds to a zero address (apparently meaning all)
yes, I have worked that out
the interface index being used is 0, which coincides with other examples I've seen in my searching
@DelphiWorlds like I said, that just tells the OS to use the default multicast interface, whatever it happens to be, instead of having to specify a specific interface. You could always try stepping into the code with the debugger and play around with the indexes. But I think the first thing you should try is setting the TIdSocketHandle.IP property to the device's local IP when setting up the Bindings collection so TIdIPMCastClient has something specific to bind to locally before joining the group.
procedure TForm1.FormCreate(Sender: TObject);
var
I: Integer;
LIP: string;
begin
FLocalAddresses := TIdStackLocalAddressList.Create;
GStack.GetLocalAddressList(FLocalAddresses);
for I := 0 to FLocalAddresses.Count - 1 do
begin
if FLocalAddresses[I].IPVersion = TIdIPVersion.Id_IPv6 then
begin
LIP := FLocalAddresses[I].IPAddress;
Break;
end;
end;
if LIP.IsEmpty then
Exit; // <======
BroadcastServerIPv6.Port := 6000;
BroadcastServerIPv6.MulticastGroup := 'FF02:0:0:0:0:0:0:1';
BroadcastServerIPv6.Active := True;
BroadcastListenerIPv6.DefaultPort := 6000;
for I := 0 to BroadcastListenerIPv6.Bindings.Count - 1 do
begin
BroadcastListenerIPv6.Bindings.Items[I].Port := BroadcastListenerIPv6.DefaultPort;
BroadcastListenerIPv6.Bindings.Items[I].IP := LIP;
end;
BroadcastListenerIPv6.MulticastGroup := 'FF02:0:0:0:0:0:0:1';
BroadcastListenerIPv6.Active := True;
end;
when I say "only" I mean that BroadcastListenerIPv6.Bindings.Count = 1
I've been through iterations of this before, one where I've created Bindings for each IPv6 address that the device has.. always results the same: error 49
@DelphiWorlds Are you setting either
BroadcastListenerrIPv6.IPVersion := Id_IPv6 or BroadcastListenerIPv6.Bindings.Items[I].IPVersion := Id_IPv6 to match the IP you are assigning? Why do you have a Binding created at design-time if you are just going to overwrite it at runtime? You may as well just use Bindings.Add() at runtime instead.