Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • May 27 2015 20:52

    Italist on patch-3

    alphabetical linting linting (compare)

  • May 27 2015 18:50

    Italist on patch-2

    Update app.html moved js to bo… (compare)

  • May 27 2015 16:49

    Italist on patch-1

    Delete icon.ico not used anywh… (compare)

  • May 21 2015 18:49

    Italist on master

    Update README.md (compare)

  • May 21 2015 18:44

    Italist on master

    Added Gitter badge Merge pull request #2 from gitt… (compare)

  • May 21 2015 18:44
    Italist closed #2
  • May 21 2015 18:32
    gitter-badger opened #2
Italist
@Italist
Hi Gavin, I forked your repo and made some changes.
I put the html styles in separate files, got rid of the outdated html markup(aka <center>),
put the scripts into two separate files, called them from the end of body, for performance,
implemented another script for ease of use of the table (checkboxes clickable by the row),
moved the output box to the top left.
in the next commits i'll probably add a message for when the "getchamps" script has done its work.
and some more default height to the frame, since when you have the champions table there aint enough space for the credits and you gotta scroll for them.
i'll probably add a message to kindly suggest to try n run the app in slow mode when there are some socket errors n stuff.
Italist
@Italist
now i added you here coz for some reason the "getallchamps" script won't run
and that's prolly coz i did some code linting and broke something little and stupid.
and it's been a few hours and i can't figure out wtf i broke. and i hate js so much.
so i thought that you may be of help as you actually wrote all that js.
could you please give it a brief look and see if you can find something wrong?
if you can't manage to find it no worries. i'll start from scratch.
thank youu
Gavin Delphia
@Gavin770
Woah, just saw all of this. I'll catch up with you in a day or so since I've been on vacation.
Also I've made major code and ui changes. Did they fix any of your dislikes?
Italist
@Italist

easy, take your time :D I'm in vacation tho atm, in Florence. It's beautiful!
anyways - I was about to send you a pull request when you committed that last version xD

which made most of my changes and code obsolete haha
but i don't give up so easily and re-wrote many of my changes for the 2.0 version.

what i wrote you before was post 2.0 by the way.

Italist
@Italist
so it still stands.
i really liked the 2.0 version, great idea that visual grid of downloaded item sets. providing the user feedback during the download of the sets and being useful to the user with that mouseover effect over roles.
in my fork i moved the output box to the left because with that grid i felt like it wasn't visible enough, given it provides useful information about the status of the app.
top left *
Italist
@Italist
well all the changes are listed above anyway. if you're curious about any of them just poke me!
Gavin Delphia
@Gavin770
So I'm working on some more changes to include adding some of your quality of life code changes. Also how about that auto updating champion gui to pull down new champs like Ekko automatically.
Gavin Delphia
@Gavin770
Lots of changes recently made again
Italist
@Italist
great idea. how about adding a left click behavoir to the role icons? so you may select multiple icons and see what champs are left.
Gavin Delphia
@Gavin770
it was already implemented haha
not the left click but the other one