These are chat archives for JRJurman/Letteropend

20th
Aug 2014
Kristen Mills
@kristenmills
Aug 20 2014 17:21
gitter
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:22
github.com
Jesse Jurman
@JRJurman
Aug 20 2014 17:22
So, I guess there is a question on whether we should let people construct Film objects with custom data
Kristen Mills
@kristenmills
Aug 20 2014 17:22
Film.new('ghostbusters')
Film.new('ghostbusters', {title: "Ghostbusters", runtime: 107})
Film.new('ghostbusters', title: "Ghostbusters", runtime: 107)
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:23
my argument is that we shouldn't, since it seems like Letteropend::Film#pull_data would always pull in some data from the web either way
whether or not you add those extra options
Kristen Mills
@kristenmills
Aug 20 2014 17:23
I think they should be
Just because if you want to save some time
Jesse Jurman
@JRJurman
Aug 20 2014 17:24
I mean, have you seen the css for this?
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:24
I get that, but I feel like letting people mock one or two fields to save an http request or two could be a slippery slope
Kristen Mills
@kristenmills
Aug 20 2014 17:24
Or a neat OPTIONAL feature
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:24
because at that point users might expect everything to be mockable right now, when they really should be making proper mock objects or something
@JRJurman CSS? xD
oh on letterboxd?
Kristen Mills
@kristenmills
Aug 20 2014 17:25
That's also a good point. Not everything is mockable
Unless we want to do that
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:25
besides even if there wasn't a mock class, you can just mocck http requests
Jesse Jurman
@JRJurman
Aug 20 2014 17:25
<div class="film-poster-93676 poster" data-film-id="93676" data-film-link="/film/guardians-of-the-galaxy/" data-film-name="Guardians of the Galaxy" data-poster-url="/film/guardians-of-the-galaxy/image-150/" data-film-release-year="2014" data-new-list-with-film-action="/list/new/with/guardians-of-the-galaxy/" data-remove-from-watchlist-action="/film/guardians-of-the-galaxy/remove-from-watchlist/" data-add-to-watchlist-action="/film/guardians-of-the-galaxy/add-to-watchlist/" data-rate-action="/film/guardians-of-the-galaxy/rate/" data-mark-as-watched-action="/film/guardians-of-the-galaxy/mark-as-watched/" data-mark-as-not-watched-action="/film/guardians-of-the-galaxy/mark-as-not-watched/" data-minimal-toggle-like-action="/s/film:93676/minimal-toggle-like"> ... </div>
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:25
which we were going to do anyway
whoah
that's hip
Jesse Jurman
@JRJurman
Aug 20 2014 17:25
there is so much crap there, that we don't need to go to the film page for
that's from the poster image
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:26
that's awesome
so, is there any reason to let people override the details besides saving http requests and testing?
Jesse Jurman
@JRJurman
Aug 20 2014 17:26
also, it occurs to me now, that letterboxd likes to keep there own id, so changing url to id (something me and nick discussed before) might be bad
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:26
I feel like saving one or two requests per film is trivial enough to not be worth it
oh
Kristen Mills
@kristenmills
Aug 20 2014 17:27
I disagree
Jesse Jurman
@JRJurman
Aug 20 2014 17:27
I feel like pulling the page just to get the title might be silly
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:27
yeah I was worried that would happen @JRJurman, maybe we should change it to slug
Jesse Jurman
@JRJurman
Aug 20 2014 17:27
especially for how long these requests take
Kristen Mills
@kristenmills
Aug 20 2014 17:27
Saving 1 or 2 request per film for 1000 films is a lot of time saved
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:27
hm
I guess that's a good point :\
Kristen Mills
@kristenmills
Aug 20 2014 17:28
And I'm saying this is just a testing thing
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:28
oh
Kristen Mills
@kristenmills
Aug 20 2014 17:28
For testing, you shouldn't be making any request
s
Using something like webmock is better
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:28
yeah but if you're testing around letterboxd, chances are you'd have to mock other http requests anyway
Kristen Mills
@kristenmills
Aug 20 2014 17:29
No http requests should be made while testing
period
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:29
yeah
Kristen Mills
@kristenmills
Aug 20 2014 17:29
All of it should be mocked
Jesse Jurman
@JRJurman
Aug 20 2014 17:29
wait... isn't that what VCR was for?
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:29
yes, it is
and webmock
Kristen Mills
@kristenmills
Aug 20 2014 17:29
VCR uses webmock right?
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:29
yes, it does
vcr just automatically saves the results of requests in a way that webmock can pick it up
the actual mocks themselves are from webmock
Jesse Jurman
@JRJurman
Aug 20 2014 17:30
did you guys still want me to make the change from *details to details={}?
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:30
(note that you can use other mock libraries with vcr, but we're using webmock)
Kristen Mills
@kristenmills
Aug 20 2014 17:30
yes
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:30
I don't understand why *details should be a thing
Kristen Mills
@kristenmills
Aug 20 2014 17:30
*details is completely unnecessary
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:30
agreed
Jesse Jurman
@JRJurman
Aug 20 2014 17:30
and the initialize should take in a slug?
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:31
unless @JRJurman can convince me otherwise
yeah probably
Kristen Mills
@kristenmills
Aug 20 2014 17:31
yeah
Jesse Jurman
@JRJurman
Aug 20 2014 17:31
instead of url
Kristen Mills
@kristenmills
Aug 20 2014 17:31
definitely
Jesse Jurman
@JRJurman
Aug 20 2014 17:31
k
Kristen Mills
@kristenmills
Aug 20 2014 17:31
I said thet earlier
In the pull request
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:31
I have an idea, we could have a method for expanding slugs and urls and whatever into a fully qualified url
Kristen Mills
@kristenmills
Aug 20 2014 17:31
Because all the urls are the same, why bother passing in extreneous data
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:31
so that you can expand those without creating a Film
and then the Film constructor can use that
Jesse Jurman
@JRJurman
Aug 20 2014 17:32
okay
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:32
btw I can start writing pending specs for all of this
Jesse Jurman
@JRJurman
Aug 20 2014 17:32
should I validate that we're not getting a url instead
Kristen Mills
@kristenmills
Aug 20 2014 17:33
you could normalize if you want
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:33
I like the idea that you can instantiate with a slug or a url
like
Jesse Jurman
@JRJurman
Aug 20 2014 17:33
I could do a check for "letterboxd.com/film/ghostbusters";, "/film/ghostbusters/"
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:33
what if you're using letterboxdin an application wher users can give the full url
Kristen Mills
@kristenmills
Aug 20 2014 17:33
basically have a method that will normalize a url, slug, or partial url
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:33
that's what I said :P
Kristen Mills
@kristenmills
Aug 20 2014 17:33
Into one thing and use that going forward
I said it first
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:34
lol no
unless it wasn't in the chat
Kristen Mills
@kristenmills
Aug 20 2014 17:34
when did you say it
Jesse Jurman
@JRJurman
Aug 20 2014 17:34
:P
Kristen Mills
@kristenmills
Aug 20 2014 17:35
Because I totes said it first
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:35
1:31pm
Kristen Mills
@kristenmills
Aug 20 2014 17:35
in the chat
that's a different statement
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:35
bro don't even trip dawg
Kristen Mills
@kristenmills
Aug 20 2014 17:35
i'm going to pretend i'm right
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:36
lol
Kristen Mills
@kristenmills
Aug 20 2014 17:36
ANYWAY
Jesse Jurman
@JRJurman
Aug 20 2014 17:36
facepalm
should I build a bunch of regexes?
Jesse Jurman
@JRJurman
Aug 20 2014 17:36
Or is there a fancy ruby way to "normalize"
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:37
good question
I have two separate ideas
Kristen Mills
@kristenmills
Aug 20 2014 17:37
I'd split on '/' and grab the last item
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:37
one is to simply check for the number of slashes. we could do a regex, but it's pretty safe to assume that it's only a slug if there are no slashes, and then you go from there
or we could try creating a ruby URI and fall back if it's not a valid URI
Jesse Jurman
@JRJurman
Aug 20 2014 17:38
@kristenmills, this is good ideas
Kristen Mills
@kristenmills
Aug 20 2014 17:38
string.split('/').last
should be the slug
regardless
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:38
oh, another thing, even if they don't specify a slug, we would still want the slug to be defined for the object
so that's a good idea @kristenmills
yeah
oh so it'll just return the whole string if there's no /?
Kristen Mills
@kristenmills
Aug 20 2014 17:39
yeah
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:39
awesome!
good idea
so, I should probably start writing pending specs now
Kristen Mills
@kristenmills
Aug 20 2014 17:40
I know. I'm a genius
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:40
you're a wizard Harry
Kristen Mills
@kristenmills
Aug 20 2014 17:41
I want to refactor your code. You typed out the word lambda
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:41
lolol
do you even proc
Kristen Mills
@kristenmills
Aug 20 2014 17:41
do you even
-> { code}
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:41
so @JRJurman are you working on these changes or should I?
oh yeah that thing
Jesse Jurman
@JRJurman
Aug 20 2014 17:42
I'm working on slug and details
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:42
want me to write specs for the alternate url forms in the constructor?
I mean for the first arg
Jesse Jurman
@JRJurman
Aug 20 2014 17:42
yeah
Kristen Mills
@kristenmills
Aug 20 2014 17:42
I'm going to do the work I'm paid to do
Jesse Jurman
@JRJurman
Aug 20 2014 17:42
haha
do that
Kristen Mills
@kristenmills
Aug 20 2014 17:43
Because my stuff is broken in Prod. That's awks
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:43
lmfao
Jesse Jurman
@JRJurman
Aug 20 2014 17:43
ouch
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:43
nice...
wecouldbecuringcancerinstead
damnit markdown
I can't do hashtags, it thinks they're headers
Kristen Mills
@kristenmills
Aug 20 2014 17:43
#wecouldbecuringcancerinstead
awks
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:44
can you like \ escape it?
Kristen Mills
@kristenmills
Aug 20 2014 17:44
yeah
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:44
oh lol
I was too lazy to try xD
Kristen Mills
@kristenmills
Aug 20 2014 17:44
you don't spend enough time on gitter
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:44
I really don't lel
firefox decided to stop living in the 90s and finally implemented desktop notifications
Kristen Mills
@kristenmills
Aug 20 2014 17:45
Oh good my stuff is only broken in NA.
I think it would be easier if it was broken around the world
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:45
lool
....
okay this is really awkward
Kristen Mills
@kristenmills
Aug 20 2014 17:46
what
is
awks
Kristen Mills
@kristenmills
Aug 20 2014 17:46
awks
That's like attempted mobile
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:46
wait what lmao
Kristen Mills
@kristenmills
Aug 20 2014 17:47
The names are going down the side
that's their mobile site
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:47
oh
the fuck
Kristen Mills
@kristenmills
Aug 20 2014 17:47
shoved in their desktop site
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:47
xD
I clicked around the left sidebar and the right one disappeared
welp
Kristen Mills
@kristenmills
Aug 20 2014 17:47
The sidebar is supposed to be hidden on mobile though so that's weird
Jesse Jurman
@JRJurman
Aug 20 2014 17:48
changes push
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:48
odd
Kristen Mills
@kristenmills
Aug 20 2014 17:49
Hey jesse configure integrations
Jesse Jurman
@JRJurman
Aug 20 2014 17:49
?
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:50
I'm doing it
it shows multiple github integrations..?
Kristen Mills
@kristenmills
Aug 20 2014 17:50
I don't have access to webhooks on this repo
Jesse Jurman
@JRJurman
Aug 20 2014 17:50
do you want that, and how do I give that to you?
Kristen Mills
@kristenmills
Aug 20 2014 17:51
I don't need it. In the activity tab on gitter, click configure integrations
press the github button
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:51
@kristenmills I set up github
but not travis
Kristen Mills
@kristenmills
Aug 20 2014 17:52
How did you set up github? The repo didn't show up for me
We had like 5 githubs
I removed 4 of them
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:53
lmao what
Kristen Mills
@kristenmills
Aug 20 2014 17:53
Whatever
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:54
like you scroll to the bottom of integrations and there's a bunch of buttons
one of them is github
Kristen Mills
@kristenmills
Aug 20 2014 17:54
No but you have to configure it to a specific repo
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:54
for some reason whenever I try to add the github integration, it always adds more than one
oh
wait the first hook says it's working
Kristen Mills
@kristenmills
Aug 20 2014 17:54
Yeah
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:54
so I guess it's ok and I should remove the other webhooks?
since they're not reporting anyway
Kristen Mills
@kristenmills
Aug 20 2014 17:54
I already did
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:54
oh ok
that thing is kind of weird
lol the sidebar on the right says that there are no integrations even if there are, you have to reload
Jesse Jurman
@JRJurman
Aug 20 2014 17:55
oh, cool
I was confused why it kept saying to configure it
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:56
yeah it's weird
just reload and everything should be fine
@JRJurman so should we agree that equality is only based on movie id for now?
Jesse Jurman
@JRJurman
Aug 20 2014 17:57
*movie slug
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:57
it's not perfect but I feel like the cases where you'd need to compare by other things are edge cases anyway
yea that's what i meant
Jesse Jurman
@JRJurman
Aug 20 2014 17:58
and yes
Nick McCurdy
@nickmccurdy
Aug 20 2014 17:58
cool
I'm seeing greeeen
Kristen Mills
@kristenmills
Aug 20 2014 18:00
Add travis integration
Nick McCurdy
@nickmccurdy
Aug 20 2014 18:00
ok
conveniently I haven't pushed the commit that fixes the build yet, but I did push other commits
so we should be getting a notification that the build failed soon
hasn't started yet
Kristen Mills
@kristenmills
Aug 20 2014 18:04
There is no travis webhook
And you have to add stuff to the .travis.yml file to make it work
Nick McCurdy
@nickmccurdy
Aug 20 2014 18:05
I already did
Kristen Mills
@kristenmills
Aug 20 2014 18:05
I'm telling you it's not there
Nick McCurdy
@nickmccurdy
Aug 20 2014 18:05
wait is this going to ignore my change because it's not on master?
Kristen Mills
@kristenmills
Aug 20 2014 18:06
No click integration settings
Nick McCurdy
@nickmccurdy
Aug 20 2014 18:06
the hell, it was there earlier
Kristen Mills
@kristenmills
Aug 20 2014 18:06
Oh now it's there
Nick McCurdy
@nickmccurdy
Aug 20 2014 18:06
I got it, thanks
sorry xD
now it should work
I'll let you know when Travis is done in case the hook doesn't work
ohhh so you're recreating the url based on the slug, clever
Jesse Jurman
@JRJurman
Aug 20 2014 18:10
YOU KNOW IT!
Nick McCurdy
@nickmccurdy
Aug 20 2014 18:10
installing nokogiri... again...
Kristen Mills
@kristenmills
Aug 20 2014 18:10
nokogiri is the worst
Nick McCurdy
@nickmccurdy
Aug 20 2014 18:10
Travis always seems to take longer when you're trying to debug hooks
it is
xD
travis is going to fail
Jesse Jurman
@JRJurman
Aug 20 2014 18:10
Whoa whoa whoa... is there an alternative?!?!? I THOUGHT YOU GUYS SAID IT WAS GREAT?!?!
Nick McCurdy
@nickmccurdy
Aug 20 2014 18:10
yay!
Kristen Mills
@kristenmills
Aug 20 2014 18:11
No it's great
Nick McCurdy
@nickmccurdy
Aug 20 2014 18:11
see there's a thing on the right
wicked
it is
Kristen Mills
@kristenmills
Aug 20 2014 18:11
it's just a long build
Nick McCurdy
@nickmccurdy
Aug 20 2014 18:11
trufax
Jesse Jurman
@JRJurman
Aug 20 2014 18:11
<.<
>.>
Nick McCurdy
@nickmccurdy
Aug 20 2014 18:11
nokogiri is just a piece of shit
Kristen Mills
@kristenmills
Aug 20 2014 18:11
I love nokogiri
Nick McCurdy
@nickmccurdy
Aug 20 2014 18:11
me too, I just hate building it
Kristen Mills
@kristenmills
Aug 20 2014 18:11
Yep
It has to build all sorts of crap
Jesse Jurman
@JRJurman
Aug 20 2014 18:12
yay dependencies
Nick McCurdy
@nickmccurdy
Aug 20 2014 18:12
dependencies are for people who aren't cool enough to write in raw C
Kristen Mills
@kristenmills
Aug 20 2014 18:12
Nokogiri is 47% java
Nick McCurdy
@nickmccurdy
Aug 20 2014 18:13
it is? even on MRI?
Jesse Jurman
@JRJurman
Aug 20 2014 18:13
@kristenmills really?
that's crazy
it might just be jruby stuff
and java is a verbose language
Nick McCurdy
@nickmccurdy
Aug 20 2014 18:14
fixed the build
good point
Kristen Mills
@kristenmills
Aug 20 2014 18:14
So it might actually be more C and Ruby
Nick McCurdy
@nickmccurdy
Aug 20 2014 18:14
I had a feeling that part was for jruby
Kristen Mills
@kristenmills
Aug 20 2014 18:15
Jruby is the devil
Nick McCurdy
@nickmccurdy
Aug 20 2014 18:15
oh cool, the travis hooks in gitter's sidebar link to both the commit range and the build itself
is it just me or do their ruby workers take longer to start builds lately?
Jesse Jurman
@JRJurman
Aug 20 2014 18:17
get_total_time was removed btw
so that can be removed from the specs...
Nick McCurdy
@nickmccurdy
Aug 20 2014 18:17
oh ok
I'm curious though, why did you remove it?
I think it's useful
also list should be Enumerable if it isn't alreaxy
Jesse Jurman
@JRJurman
Aug 20 2014 18:18
it's nice, but not a fundamental thing to do (pulling each films runtime is very long with longer lists)
Nick McCurdy
@nickmccurdy
Aug 20 2014 18:18
which would also make it a little easier to implement get_total_time
I guess :|
Jesse Jurman
@JRJurman
Aug 20 2014 18:18
it's just a normal list
Nick McCurdy
@nickmccurdy
Aug 20 2014 18:19
woooo build's green!
and the hooks are still working
Jesse Jurman
@JRJurman
Aug 20 2014 18:20
whoa really?
Nick McCurdy
@nickmccurdy
Aug 20 2014 18:20
yeah
gonna implement specs for some of the edge cases of slugs and urls
Nick McCurdy
@nickmccurdy
Aug 20 2014 18:27
just pushed the improved slug specs
it works fine :)
@kristenmills in RSpec, is there a better way to repeat the same examples (but with different lets) in different contexts without just copying the code?
Nick McCurdy
@nickmccurdy
Aug 20 2014 18:32
I feel like I'm missing something about how contexts work
Kristen Mills
@kristenmills
Aug 20 2014 18:32
there are shared contexts
and stuff like that
I did something like that with alexandria I think
shared_examples
Nick McCurdy
@nickmccurdy
Aug 20 2014 18:34
ohhh
that's awesome! thanks
Kristen Mills
@kristenmills
Aug 20 2014 18:34
no problem
Nick McCurdy
@nickmccurdy
Aug 20 2014 18:34
I'll make this less jank
I'm assuming that syntax is valid (and not deprecated) in rspec 3?
Kristen Mills
@kristenmills
Aug 20 2014 18:34
I doubt it
yep it's the same
Nick McCurdy
@nickmccurdy
Aug 20 2014 18:38
I love how let gets scoped with shared examples
it's really handy
ooh and it shows it in the doc output too
oh yeah, we need to figure out why Code Climate test coverage isn't working...
@JRJurman want to do that soon?
Kristen Mills
@kristenmills
Aug 20 2014 18:45
is test coverage a free feature?
Jesse Jurman
@JRJurman
Aug 20 2014 18:45
I'm gonna be busy for most of the day sadly :(
so it'll have to wait for another day if it needs repo-creater-intervention
Kristen Mills
@kristenmills
Aug 20 2014 18:48
Test coverage needs to be setup by repo owner I believe
Jesse Jurman
@JRJurman
Aug 20 2014 18:48
Is there a page that explains what I need to do?
Kristen Mills
@kristenmills
Aug 20 2014 18:49
you literally press a button
it should be on the right hand side
oh i lied
you press a button then do a bunch of work
Jesse Jurman
@JRJurman
Aug 20 2014 18:50
I see a bunch of setup stuff...
Should I do this work on master?
Kristen Mills
@kristenmills
Aug 20 2014 18:50
Yeah probably
Jesse Jurman
@JRJurman
Aug 20 2014 18:51
oh, this looks like spec stuff
which should probably go in the rspec branch
Kristen Mills
@kristenmills
Aug 20 2014 18:51
yeah
i supposed
Jesse Jurman
@JRJurman
Aug 20 2014 18:52
@nicolasmccurdy I'm gonna facebook message you the details on the page, if you want to take it from there
*or google+ message you, 'cause hipster
Kristen Mills
@kristenmills
Aug 20 2014 18:53
I'm going to go get lunch
Nick McCurdy
@nickmccurdy
Aug 20 2014 18:54
crap I should probably eat
@kristenmills on Code Climate? yeah they now have free test coverage for open source projects :)
I've been using it instead of Coveralls and I like it
Jesse Jurman
@JRJurman
Aug 20 2014 18:54
can I not send files over plus chat?
Nick McCurdy
@nickmccurdy
Aug 20 2014 18:55
@JRJurman lol that works, sure :P
doesn't gitter have private chat though?
Jesse Jurman
@JRJurman
Aug 20 2014 18:55
shrug
Nick McCurdy
@nickmccurdy
Aug 20 2014 18:56
not sure if google+ supports files in chat... also I'm using a third party client for it
Jesse Jurman
@JRJurman
Aug 20 2014 18:57
I sent it on facebook
Nick McCurdy
@nickmccurdy
Aug 20 2014 18:57
I wish code climate and coveralls made it easier to see test coverage locally
I just want to see the coverage :|
Nick McCurdy
@nickmccurdy
Aug 20 2014 19:06
lol the file you sent me doesn't have CSS
but I can still see it
Nick McCurdy
@nickmccurdy
Aug 20 2014 19:14
I'm going to rubocop all the things
Kristen Mills
@kristenmills
Aug 20 2014 19:49
hi
Nick McCurdy
@nickmccurdy
Aug 20 2014 19:53
yo
I'm rubocopificating
Kristen Mills
@kristenmills
Aug 20 2014 19:53
why is steam so blue
Nick McCurdy
@nickmccurdy
Aug 20 2014 19:54
can you continue a single quoted string with a double quoted string or vice versa?
This message was deleted
huh? o_O
Kristen Mills
@kristenmills
Aug 20 2014 19:54
yes
why are you doing that
Nick McCurdy
@nickmccurdy
Aug 20 2014 19:54
ooh nice
Kristen Mills
@kristenmills
Aug 20 2014 19:54
That seems weird
steam has become extra blue
Nick McCurdy
@nickmccurdy
Aug 20 2014 19:54
what does? steam?
oh the string thing?
line length
Kristen Mills
@kristenmills
Aug 20 2014 19:55
the string thing
oh
Nick McCurdy
@nickmccurdy
Aug 20 2014 19:55
I'm using \ to split a string into two lines
Kristen Mills
@kristenmills
Aug 20 2014 19:55
oh
Nick McCurdy
@nickmccurdy
Aug 20 2014 19:55
but rubocop yells at me if I use double quotes in both parts if only one part needs them
Kristen Mills
@kristenmills
Aug 20 2014 19:55
Rubocop is stupid
because you are supposed to be consitent
Nick McCurdy
@nickmccurdy
Aug 20 2014 19:56
let's hope this isn't a bug lol
Kristen Mills
@kristenmills
Aug 20 2014 19:56
and lean towards double quoted
Nick McCurdy
@nickmccurdy
Aug 20 2014 19:56
I disagree
single quoted strings should be used unless you need interpolation, certain character escapes, or multiple double quote characters
single quotes are faster
Kristen Mills
@kristenmills
Aug 20 2014 19:57
well your a javascript developer and that's javascript style
Nick McCurdy
@nickmccurdy
Aug 20 2014 19:57
it's not
javascript style is to always use single quotes, unless you have HTML or something else with multiple double quotes
Kristen Mills
@kristenmills
Aug 20 2014 19:57
that's what i'm saying
Nick McCurdy
@nickmccurdy
Aug 20 2014 19:57
because javascript doesn't have string interpolation (yet) and escapes work on double and single quoted strings
yeah but ruby is more different than that
Kristen Mills
@kristenmills
Aug 20 2014 19:58
javascript best practice is single quote
ruby best practice is double quoted
Nick McCurdy
@nickmccurdy
Aug 20 2014 19:58
because single quoted strings are actually faster and have less features
Kristen Mills
@kristenmills
Aug 20 2014 19:58
yes but that doesn't mean it's not stylistically prefered
apparently the ruby style guide now has both
Kristen Mills
@kristenmills
Aug 20 2014 19:59
The second style is arguably a bit more popular in the Ruby community. The string literals in this guide, however, are aligned with the first style.
Nick McCurdy
@nickmccurdy
Aug 20 2014 19:59
I though it only had type A
Kristen Mills
@kristenmills
Aug 20 2014 19:59
Quote
Nick McCurdy
@nickmccurdy
Aug 20 2014 19:59
hmm
Kristen Mills
@kristenmills
Aug 20 2014 20:00
I usually use single quoted because that's what I do naturally
But I don't think it's prefered
Nick McCurdy
@nickmccurdy
Aug 20 2014 20:00
idk I could go either way for this specific project
I usually prefer using single quotes primarily (type a)
mainly because of the benchmark speeds
Kristen Mills
@kristenmills
Aug 20 2014 20:01
like i don't really care but I don't like rubocop. I think it's too strict and has made up style that's not really consistent with anyone
Nick McCurdy
@nickmccurdy
Aug 20 2014 20:01
I disagree for the most part
like, it does have some inconsistencies
it's supposed to follow the ruby style guide
and it does... for the most part
Kristen Mills
@kristenmills
Aug 20 2014 20:02
I think it's just a bit too strict sometimes. Especially with rails.
Nick McCurdy
@nickmccurdy
Aug 20 2014 20:02
we could always tell it to shut up about double/single quotes
yeah the rails stuff is weird
I still don't understand why the sexy validator cop isn't enabled by default
Kristen Mills
@kristenmills
Aug 20 2014 20:02
i guess i mostly have used it with rails. Maybe it's fine for regular ruby stuff
Nick McCurdy
@nickmccurdy
Aug 20 2014 20:03
like if you're not using ActiveRecord, you're not going to have a method called validates_precense_of
so they might as well always turn it on
anyway
Kristen Mills
@kristenmills
Aug 20 2014 20:03
i'll be back
Nick McCurdy
@nickmccurdy
Aug 20 2014 20:03
I would like to use rubocop for general stuff if that's fine
I was going to just assume we were using the single quote style
but I'd be fine either way
Kristen Mills
@kristenmills
Aug 20 2014 20:04
Yeah that's fine
Just don't expect me to run rubocop :)
Nick McCurdy
@nickmccurdy
Aug 20 2014 20:04
lol
also there's like global variables and class variables and similar stuff in the source, and rubocop has been helpful with finding it
Kristen Mills
@kristenmills
Aug 20 2014 20:05
I'll be back. I have to go back to work. I went home for a second
Nick McCurdy
@nickmccurdy
Aug 20 2014 20:05
oh okay cool
@hollyhastings yo
so we've been working on changing the constructor for the Film class, tests (with RSpec), and linting (with Rubocop)
Nick McCurdy
@nickmccurdy
Aug 20 2014 20:10
woop the line length cop is happy now
right now we just have complexity, method length, and global variables to fix
@JRJurman if you could work on removing global variables, that would be awesome. I could do it but you understand the code more than me, and I don't want to break things
run this to find all global variables: git grep "\\$\w+"
don't mess with $LOAD_PATH, that's the one global we want to keep
only $ct in examples/getAllTime.rb needs to go away
21 rubocop offenses to go
Nick McCurdy
@nickmccurdy
Aug 20 2014 20:15
also if someone could help me implement more specs that would be sweet
btw I'm leaving for a bit soon
Travis does not make it easy to reach inbox 0...
Kristen Mills
@kristenmills
Aug 20 2014 20:21
i'm back
Nick McCurdy
@nickmccurdy
Aug 20 2014 20:21
kewl
Kristen Mills
@kristenmills
Aug 20 2014 20:22
I forgot my badge. Then I had to go back home
Then the cat tried to escape
it' was an ordeal
Nick McCurdy
@nickmccurdy
Aug 20 2014 20:22
oh god
you have a cat??
Kristen Mills
@kristenmills
Aug 20 2014 20:22
Yingling has a cat
Nick McCurdy
@nickmccurdy
Aug 20 2014 20:22
I have like +100 respect for Yingling now
tell him I said that
Kristen Mills
@kristenmills
Aug 20 2014 20:22
I claim no ownership of this cat
Nick McCurdy
@nickmccurdy
Aug 20 2014 20:23
dude one time a couple weeks ago I was walking down the block
and some woman had her door open and was talking to someone outside
and her cat tried to bolt out the door
when it was stopped it looked so pissed
Kristen Mills
@kristenmills
Aug 20 2014 20:24
lolololol
Nick McCurdy
@nickmccurdy
Aug 20 2014 20:25
like its ears were back and it looked like it was about to kill someone
I require cat photos
@smy2748 gimme
Holly Hastings
@hollyhastings
Aug 20 2014 20:27
dude one time i was walking down a street and pet a cat and then this women takes out all of her cats ( 5 of them) and told me all about their names and stories. She never told me her name
Kristen Mills
@kristenmills
Aug 20 2014 20:27
Steve thinks there must be something really exciting out in the hall because Yingling and I leave all the time. So he bolts out the door stops, can't find the excitement and doesn't know what to do from there.
lolololol
Nick McCurdy
@nickmccurdy
Aug 20 2014 20:28
does anyone want me to open up a pull request for style?
it's not done but we can discuss or whatever
Kristen Mills
@kristenmills
Aug 20 2014 20:28
go nuts
Nick McCurdy
@nickmccurdy
Aug 20 2014 20:28
come to think of it, it would be nice to have a checklist...
checklist all the things
@hollyhastings that's excellent
Kristen Mills
@kristenmills
Aug 20 2014 20:28
Steve is a monster cat. He perches on you at odd hours wanting food
Nick McCurdy
@nickmccurdy
Aug 20 2014 20:29
lol
my cat is just a jerk
he expects to be fed at 1am and 4am, it's awful
Kristen Mills
@kristenmills
Aug 20 2014 20:29
I was awoken at like 5 this morning
I was being attacked
by a cat
Nick McCurdy
@nickmccurdy
Aug 20 2014 20:30
lol
Kristen Mills
@kristenmills
Aug 20 2014 20:30
and by attacked i mean it was on me
Holly Hastings
@hollyhastings
Aug 20 2014 20:30
Nick's cat loves showing off his buttonhole every time we facetime
*butthole
Nick McCurdy
@nickmccurdy
Aug 20 2014 20:30
my dad used to be in a small apartment with two cats
Holly Hastings
@hollyhastings
Aug 20 2014 20:30
Every
Nick McCurdy
@nickmccurdy
Aug 20 2014 20:30
and he had like a dresser or a recording booth or something right next to his bed
Holly Hastings
@hollyhastings
Aug 20 2014 20:30
Sing;w
*SIngle
time
Nick McCurdy
@nickmccurdy
Aug 20 2014 20:30
and one time we was awaken because one of his cats decided to jump onto him while he was sleeping
also when my cat was a kitten, I made the mistake of thinking it would be a good idea to let him stay in my room overnight
Holly Hastings
@hollyhastings
Aug 20 2014 20:31
now time my cat was pissed off at me and then laid on my face to get get me back
lol
Nick McCurdy
@nickmccurdy
Aug 20 2014 20:31
I had to keep my toes perfectly still or he'd pounce on them, and by the time I went to sleep, I would move the slightest bit and he'd wake me up by attacking my feet
Kristen Mills
@kristenmills
Aug 20 2014 20:32
steve was doing that this morning
just biting my ankles
Nick McCurdy
@nickmccurdy
Aug 20 2014 20:32
lol how old is he?
Kristen Mills
@kristenmills
Aug 20 2014 20:32
7 I think
Holly Hastings
@hollyhastings
Aug 20 2014 20:32
LOL
what kind of cat?
Nick McCurdy
@nickmccurdy
Aug 20 2014 20:32
oh boy
Kristen Mills
@kristenmills
Aug 20 2014 20:32
Idk. Cat like
Holly Hastings
@hollyhastings
Aug 20 2014 20:32
lol
Nick McCurdy
@nickmccurdy
Aug 20 2014 20:32
lmao
oh yeah, the pull request...
#13
Kristen Mills
@kristenmills
Aug 20 2014 20:34
I see it
In the sidebar
Nick McCurdy
@nickmccurdy
Aug 20 2014 20:34
nerd
it's not done btw
Kristen Mills
@kristenmills
Aug 20 2014 20:34
you said that
Nick McCurdy
@nickmccurdy
Aug 20 2014 20:37
updated the description
uggggh I really don't want to fix code climate
effort
btw @kristenmills are you on campus this semester?
I can't remember if you're a senior.. lol
wait you totally are
Kristen Mills
@kristenmills
Aug 20 2014 20:48
yeah
Senior Project
Nick McCurdy
@nickmccurdy
Aug 20 2014 20:49
do you know what you're doing?
Kristen Mills
@kristenmills
Aug 20 2014 20:50
It's called LinGUIni
Nick McCurdy
@nickmccurdy
Aug 20 2014 20:50
loool
btw I should be getting to RIT (colony again) tomorrow
Stephen Yingling
@smy2748
Aug 20 2014 21:01
LinGUInu LinGUIni, give me the formulini
Kristen Mills
@kristenmills
Aug 20 2014 21:13
Production is fixed
Kristen Mills
@kristenmills
Aug 20 2014 21:57
NO
Stephen Yingling
@smy2748
Aug 20 2014 22:01
but everyone loves happy appy