Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Oct 30 2021 00:40
    codesee-architecture-diagrams[bot] commented #91
  • Oct 30 2021 00:39
    feldoh synchronize #91
  • Oct 30 2021 00:38

    feldoh on jpackage

    Update .gitattributes (compare)

  • Oct 30 2021 00:31
    codesee-architecture-diagrams[bot] commented #91
  • Oct 30 2021 00:29
    feldoh synchronize #91
  • Oct 30 2021 00:29

    feldoh on jpackage

    Update build.yml Back out of c… (compare)

  • Oct 30 2021 00:19
    codesee-architecture-diagrams[bot] commented #91
  • Oct 30 2021 00:18
    feldoh synchronize #91
  • Oct 30 2021 00:18

    feldoh on jpackage

    Fix coveralls (compare)

  • Oct 30 2021 00:11
    codesee-architecture-diagrams[bot] commented #91
  • Oct 30 2021 00:09
    feldoh synchronize #91
  • Oct 30 2021 00:09

    feldoh on jpackage

    Improve actions build (compare)

  • Oct 29 2021 23:48
    codesee-architecture-diagrams[bot] commented #91
  • Oct 29 2021 23:46
    feldoh opened #91
  • Oct 29 2021 23:44

    feldoh on jpackage

    Try github actions (compare)

  • Oct 29 2021 23:30

    feldoh on jpackage

    Working jpackage with java17 (compare)

  • Oct 29 2021 00:30
    codesee-architecture-diagrams[bot] commented #84
  • Oct 29 2021 00:29
    feldoh synchronize #84
  • Oct 29 2021 00:29

    feldoh on dep-updates

    Add CodeSee architecture diagra… Merge pull request #85 from fel… Only build master and develop b… and 50 more (compare)

  • Oct 29 2021 00:14
    codesee-architecture-diagrams[bot] commented #90
Steven Angles
@stangles
hi @feldoh, in regards to #40, i typically can't bear to open a PR without some tests. to that end, i would like to add some test dependencies to the project so i can write tests. i typically use JUnit (http://junit.org/junit4/) for testing and Mockito (http://mockito.org/) for mocking. i wanted to check with you that it's okay to add these dependencies before i do write the tests. if you have preferences for other frameworks, let me know and i'll use those instead
Dexter Lowe
@feldoh
Nope that's good, JUnit and Mockito match my preferences well. I was planning on adding TestFx which includes both deps anyway.
turns out it's relatively tricky to test JavaFx stuff without a specialist framework; I have a local branch but it's never got very far.
Dexter Lowe
@feldoh
ha I see you beat me to fixing that null message
Steven Angles
@stangles
yes indeed. it seemed easy enough to fix, so i figured i would
Dexter Lowe
@feldoh
If you want a few more easy hacktoberfest tickets I'll be happy to mark any commit you make as hacktoberfest i.e. more features or more tests given that you've got an idea of the codebase now
Steven Angles
@stangles
certainly. i actually found out that PRs don't need to be tagged with hacktoberfest to count. i'll pick up a few more issues and open PRs for them
Dexter Lowe
@feldoh
@stangles Do you fancy doing a code review; I've finished adding tests for the rest of the cli. Given you added the first tests I thought you might be interested in doing the review.
Steven Angles
@stangles
@feldoh, sure, I'll take a look
Steven Angles
@stangles

@feldoh my access to github is currently spotty, due to a DDoS against a DNS provider that github uses: https://www.dynstatus.com/incidents/nlr4yrr162t8

I think the PR is fine to merge, you definitely nailed the coverage.

Dexter Lowe
@feldoh
mine was also pretty spotty; I'll merge. I made a new issue to swap to either command or CoR