Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    William Yao
    @William-Yao425
    Hi, I am working on #9281. I have an idea to replace the previous group in 'SelectedGroup' container by the right-clicked group then the removal action should work well. Whereas I not sure where I can get the group after right-click. Do I need an EventListener or Could you please tell me what relevant classes might be helpful in this case ?
    William Yao
    @William-Yao425
    Hi all, I would like to have a PR by fix #9281. However, there is a deployment taks fails. Dose the error indicate something setup or the part of my code was wrong?
    image.png
    William Yao
    @William-Yao425
    So I am working on a window system, and the other two deployment of window and linux are passed, but the macOS fails and indicates this error message
    Carl Christian Snethlage
    @calixtus
    As long as it locally runs it should be no problem. Macos-build is being automatically notarized by apple with a secret, which is supplied only to the original jabref repo ci, so its ok, that it fails for your repo.
    Oliver Kopp
    @koppor
    If you merge latest main, there should be a green check mark at Mac os x -- we improved the GitHub Actions Workflow a bit...
    William Yao
    @William-Yao425

    but the thing is, the PR I would like to merge into main is failing by the error above. Could you give me some instruction that how can I get the green check mark at Mac OSX

    If you merge latest main, there should be a green check mark at Mac os x -- we improved the GitHub Actions Workflow a bit...

    image.png
    ThiloteE
    @the-rabbit-tiger:matrix.org
    [m]
    As Oliver said, updating your fork to reflect changest in newest JabRef/JabRef main should (hopefully) do the trick.
    ThiloteE
    @the-rabbit-tiger:matrix.org
    [m]
    Just ignore this MacOS check for now. Christoph and Oliver are working on refining the check. The test is failing, because some secrets have to be injected and this is usually only done prior to a new release of JabRef. We don't do it for the development version.
    :point_up: Edit: As Oliver said, updating your fork to reflect changes in newest JabRef/JabRef main should (hopefully) do the trick.
    ThiloteE
    @the-rabbit-tiger:matrix.org
    [m]
    If you are sure your pull-request will not fix the issue, you can still create a pull-request and comment and describe what works and what does not work, then link the PR to the issue and then close it. That way, if somebody else wants to fix this issue, they see what has been tried and what works/does not work and they will see where the code is located at.
    William Yao
    @William-Yao425
    Thanks for your reply, ThiloteE. However, I tried to make our forked branch updated by merge Jabref main into our branch, but the Mac OSX deployment is still failing. In addition, the PR have the solution to the bug, it might not be the best solution, but I am sure it can fix the #9281 bug. I just want to double check whether this mac deployment will affect the PR to be reviewed and might be merged (if the fix solution looks good).
    image.png
    ThiloteE
    @the-rabbit-tiger:matrix.org
    [m]
    The failing mac deployment will have no impact on the review. If the pr is alright, it will be merged after review :-)
    Since there are a lot of open pull-requests right now, it might take a little until all of them have been reviewed.
    1 reply
    Carl Christian Snethlage
    @calixtus
    @William-Yao425 please note, that you are not able to merge your own or into jabref source, but even though you may have all tests green you need two accepting code reviews the maintainers. The maintainers are able to merge your PR even though a test may fail.
    William Yao
    @William-Yao425
    Thanks for your suggestion ,Carl. I understand the process of merging a open PR, I was just concerned about if the automation testing failure would trigger no review from maintainers. I think it can be reviewed As ThiloteE mentioned before. Thanks again for your wonderful response :).
    ThiloteE
    @the-rabbit-tiger:matrix.org
    [m]
    :point_up: Edit: If you are sure your pull-request will not fix the issue or only partly fix the issue, you can still create a pull-request and comment and describe what works and what does not work, then link the PR to the issue and then leave it open in the hopes of somebody trying to improve your PR or alternatively you can immediately close the PR. (If you have no hope that somebody will continue your work in the short future, closing is the better choice). That way, if somebody else wants to fix this issue, they can have a look at your PR and see what has been tried and what works/does not work and they will see where the code is located at.

    :point_up: Edit: If you are sure your pull-request will not fix the issue or only partly fix the issue, you can still create a pull-request and comment and describe what works and what does not work, then link the PR to the issue and then leave it open in the hopes of somebody trying to improve your PR or alternatively you can immediately close the PR. (If you have no hope that somebody will continue your work in the short future, closing is the better choice).

    That way, if somebody else wants to fix this issue, they still have the chance to have a look at your PR and see what has been tried and what works/does not work and they will see where the code is located at.

    michaela559
    @michaela559

    hello, working on #9153 (Sort on timestamp should be maintained after closing and reopening a library) (could not unfortunately start working on it sooner because of health reasons, sorry).

    I'm having trouble understanding the issue becuase for me, the timestamp sort doesn't work BEFORE closing and reopening, either. Is that my fault or the state of the app now?

    ThiloteE
    @the-rabbit-tiger:matrix.org
    [m]
    uhm, in theory it should sort before closing. I will test this later today
    ThiloteE
    @the-rabbit-tiger:matrix.org
    [m]
    it works for me
    you can go to options > preferences > entry table and add "modificationdate" or "creationdate" to the maintable. Then you can left-click on the column "modificationdate" and thereby sort
    ThiloteE
    @the-rabbit-tiger:matrix.org
    [m]
    michaela559
    @michaela559
    image.png
    no info about time though
    Christoph
    @Siedlerchr
    grafik.png
    @michaela559 You need to enable the storing of the dates for the entries
    1 reply
    ThiloteE
    @the-rabbit-tiger:matrix.org
    [m]
    Michaela, i think this issue was a non-issue. Thank you nevertheless! Feel free to look around and have a go at one of the other issues, if you may :-)
    108
    @Kyoko108
    Can anyone here guide me to leverage my Java skills so that my GSoC contributions are valid and legit ?
    Carl Christian Snethlage
    @calixtus
    Sorry, but this is a user and dev support chat for jabref. Maybe look into a general java forum?
    Oliver Kopp
    @koppor

    To all: We reworked the setup guidelines one week ago. We also added some checks in the steps so that "errors" are catched early.

    Please walk though https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace again

    shraddha761
    @shraddha761
    Hi, I want to start contribution in this project.How will I start can anyone suggest ? As i am completely beginner.
    Christoph
    @Siedlerchr
    @shraddha761 Welcome to JabRef. Please have a look at our contribution guide https://devdocs.jabref.org/contributing.html
    systemoperator
    @systemoperator
    Has anyone experience with the following error, when running jlink with jabref:
    Error: jdk.internal.org.objectweb.asm.MethodTooLargeException: Method too large: jdk/internal/module/SystemModules$all.moduleDescriptors ()[Ljava/lang/module/ModuleDescriptor;
    jdk.internal.org.objectweb.asm.MethodTooLargeException: Method too large: jdk/internal/module/SystemModules$all.moduleDescriptors ()[Ljava/lang/module/ModuleDescriptor;
    Christoph
    @Siedlerchr
    @systemoperator This is a bug in the jdk which can happen when you try to add additional module information or libraries. Java merges all together into a single method and that has a 64kb limit https://bugs.openjdk.org/browse/JDK-8240567
    JabRef is just below the limit
    Might also depend on the jdk. As you can see our CI runs through with temurin. https://adoptium.net/de/temurin/archive/?version=18
    You can try to do a ./gradlew clean before as well
    systemoperator
    @systemoperator
    @Siedlerchr I'm also using Temurin 18. Now I performed a clean and run jlink from terminal, the error did not vanish. Only added one additional library. :/
    Carl Christian Snethlage
    @calixtus
    Yes, we have the same problem. We are working on a fix for jlink, but that takes time and is a slow process...
    systemoperator
    @systemoperator
    Ok :)
    Christoph
    @Siedlerchr
    Yes, atm you cannot really add any other external library :(
    If you have some knowledge of byte code handling you are welcome to help openjdk/jdk#10704
    Kevin
    @K5qu4r3d
    Hi, new contributor here. I just finished setting up JabRef locally and ran the project successfully without any problems. However, IntelliJ is telling me that inbuildSrc/copied/.../journals/JournalAbbreviationRepository the Abbreviation class has not been imported here - I have not modified the code at all before discovering this, and the latest changes have been applied. Is it correct to assume it was intended like this? If not, then is it okay to fix the error and import the Abbreviation class to JournalAbbreviationRepository?
    Christoph
    @Siedlerchr
    There is also a thing about the configuration of the buildSrc folder
    Kevin
    @K5qu4r3d
    @Siedlerchr Looks like I didn't get past the initial IntelliJ setup part of the doc. I took care of the buildSrc problem on my end. Thanks!