We chose slf4j because it provides the same logging interface/façade and so the underlying implementation can be changed easily
By switching to TinyLog, we accept that SLF4J cannot be used any more. --> We want to work on the startup time and the memory consumption. Thus, we want to remove unnecessary layers. Thus, we watned to play with TinyLog.
We accept that newcomers might not be used to it.
This was the short form of the last step. - With tinylog: Logger.debug("something"); without tinylog:
private static final Logger Logger= LoggerFactory.getLogger(LayoutEntry.class);
...
Logger.debug("something");
./gradlew javadoc failed, complaining that two packages were not visible/exported to org.jabref.
The two packages in question are the ones in the addExports list in the moduleOptions of the compileJava task, so I copied them into the moduleOptions of the javadoc task:
javadoc {
options {
encoding = 'UTF-8'
version = true
author = true
}
moduleOptions {
// TODO: Remove access to internal api
addExports = [
'javafx.controls/com.sun.javafx.scene.control' : 'org.jabref',
'org.controlsfx.controls/impl.org.controlsfx.skin' : 'org.jabref'
]
}
}This eliminated the error for impl.org.controlsfx.skin but the error persists for com.sun.javafx.scene.control:
/path/to/jabref/src/main/java/org/jabref/gui/actions/ActionFactory.java:19: error: package com.sun.javafx.scene.control is not visible
import com.sun.javafx.scene.control.ContextMenuContent;
^
(package com.sun.javafx.scene.control is declared in module javafx.controls, which does not export it to module org.jabref)
/path/to/jabref/src/main/java/org/jabref/gui/fieldeditors/TextInputControlBehavior.java:28: error: package com.sun.javafx.scene.control is not visible
import com.sun.javafx.scene.control.Properties;
^
(package com.sun.javafx.scene.control is declared in module javafx.controls, which does not export it to module org.jabref)
2 errorsAnyone know how to fix this?
Basically, I am a bit stuck on JabRef/jabref#6394 and am trying to figure out how groups ideally should work in the GUI.
This specific example might not be possible right now but demonstrates the issue. If
- group A contains all entries not in group B, and
- group B contains all entries in group A
for arguments sake, what group color should it have and how should it be updated without creating an update cycle?
