Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Jamie Mason
    @JamieMason
    I think they can be addressed, it's just been tricky so far
    at it's heart, all shrinkpack actually does is: crawl the npm-shrinkwrap.json dependency graph, copy into the project the tarballs which npm install downloads, then rewrite the paths in the dependency graph to point at those downloaded tarballs.
    Dylan Piercey
    @DylanPiercey
    @JamieMason whats the progress on scoped packages? This project looks great by the way!
    Jamie Mason
    @JamieMason
    version 0.5.0 released
    From my tests, this version should add support for git dependencies and scoped packages
    Dylan Piercey
    @DylanPiercey
    Awesome work @JamieMason. I'll get to trying this later today, thanks for figuring this out!
    Dylan Piercey
    @DylanPiercey
    This message was deleted
    Seems to work well now! Thanks @JamieMason .
    Jamie Mason
    @JamieMason
    I didn't get time this weekend to close the new issues, but have made a good start on simplifying the codebase overall. Hope to get it done this week.
    Dylan Piercey
    @DylanPiercey
    Glad to hear. Thanks for your work @JamieMason.
    Jamie Mason
    @JamieMason
    some more progress on the refactor, should be a couple more days and hopefully most of the open issues will be addressed. Screenshot here: https://www.dropbox.com/s/jvyp6ucbpjrerpb/Screen%20Shot%202016-04-13%20at%2000.04.47.png?dl=0
    Dylan Piercey
    @DylanPiercey
    Looks awesome. The logs will be helpful.
    Dylan Piercey
    @DylanPiercey
    This message was deleted
    @JamieMason, just tried out 0.10 and it works perfect! Much faster as well. The only minor issue I have is that it errors if it doesn't do anything which makes my npm script fail, not a big deal but ideally this wouldn't be an error since it seems that shrinkpack has done it's job.
    blob
    Jamie Mason
    @JamieMason
    thanks Dylan, if you could create a small issue I'll get that sorted
    Rupert Redington
    @marxian

    @JamieMason, thanks for this, it is just what I need.

    It seems to me, though, that this commit (JamieMason/shrinkpack@409062c ) prevents us from re-running shrinkpack after adding a new dependency.

    I thought I could workaround this by regenerating the shrinkwrap, but to my surprise the new npm-shrinkwrap.json contained 'resolved' properties pointing at './node_shrinkwrap'. Looking further into this I find that that resolution for the packages has found its way into the npm cache, probably as a result of running 'npm install' against a previously shrinkpacked project. I don't know what to do about this...

    Jamie Mason
    @JamieMason
    thanks @marxian, I'll get that sorted as soon as I can. Please raise an issue incase I forget (I'm on my way out at the moment).
    Rupert Redington
    @marxian
    Done!
    Jamie Mason
    @JamieMason
    thansk a lot @marxian – I didn't get to them this weekend as planned, but hope to have this and the other issues picked up this week.
    Jamie Mason
    @JamieMason
    0.12.1 released – the issues discussed in this chat should hopefully be addressed now. Thanks a lot
    Dylan Piercey
    @DylanPiercey
    @JamieMason gotta say your recent updates to this lib have been awesome. It's 500x faster, 100x clearer (on what it's doing) and works for anything I can throw at it. Great job! I'm excited to throw this into some production apps soon.
    Jamie Mason
    @JamieMason
    I'm away next week, so any updates etc will happen after then – thanks all for following shrinkpack.
    René Domingue
    @rdomingue
    Hi Jamie... conserning the issue : JamieMason/shrinkpack#41
    I'm not sure it seems to be 0.12.3
    René Domingue
    @rdomingue
    blob
    I confirm
    Jamie Mason
    @JamieMason
    Please note that there is a bug which was introduced in npm 3.8.8 which affects shrinkwrap/shrinkpack, please use npm 3.8.7 or older until a fix is released, more information in JamieMason/shrinkpack#45. Thanks.
    Sebastian Werner
    @swernerx
    Hi. I just discovered this tool. It's super interesting for what it should solve. I am just not sure how you deal with the new folder containing all these tgz files... is the idea to put all of them into Git? If that's true... wouldn't it bloat the size of the Git repository by same major amount over a few releases? (Maybe one can combine it with Git LFS, but then again there will be a dynamic download, right?)
    Jamie Mason
    @JamieMason
    Thanks @swernerx, that's right that the idea is to check them into Git. The zip files are very small but a few have mentioned that uncompressed tars will actually be more appropriate for Git, please see JamieMason/shrinkpack#40 where we'll likely add a shrinkpack --uncompressed option.
    Jamie Mason
    @JamieMason
    As I get time I'm trying to improve the Documentation. So far there is just this new Tutorial in the Wiki but more will follow.
    Sam Farrington
    @SamFarrington
    Hey there - I'm wondering if shrinkpack can work with npm pack for total offline installs?
    As in after running shrinkpack produce a .tgz using npm pack that can then be installed anywhere?
    Sam Farrington
    @SamFarrington
    ^ Just to clarify what I meant the above post. After git cloning a repo which has been shrinkpacked, npm pack can be run to produce a supposedly installable tar file.
    This however doesn't work. It seems like there is an assumption somewhere in the code that npm is running in the same directory that contains node_shrinkwrap.
    Which isn't the case when installing an npm pack produced file, rather than running from a git clone
    The use case for this is installing on a production system that does not have access to the git repo(or any internet for that matter)
    A workaround is to produce an archive of the git repo and transfer that to the target server, then running npm install in the resultant folder on the server
    However I'm not sure if there are any important differences between an archive produced by npm pack and an archive produced via git archive
    Sam Farrington
    @SamFarrington
    Anyone else having problems downloading tarballs today? I've got a project where shrinkpack was previously running without issue however now I'm getting a spam of ! failed to resolve tarball for nan@2.4.0 [Error: ! failed to download nan@2.4.0] for each dependency
    Jamie Mason
    @JamieMason
    Hi @Bucabug, sorry for the slow reply. Please could you raise a new issue which follows the bug reports section of the issue template? Thanks
    Sam Farrington
    @SamFarrington
    Hey @JamieMason - issue raised #69
    C. Corey Capel
    @capelio
    Are there known issues w/ npm@2.x ?
    C. Corey Capel
    @capelio
    @JamieMason ^ :)
    Jamie Mason
    @JamieMason
    hello, could you add some more detail please?
    C. Corey Capel
    @capelio
    Sure thing. I'm using npm 2.15.1, and after running npm shrinkwrap --dev && shrinkpack via a npm script, I'm seeing oddities in the npm-shrinkwrap.json file, specifically:
    "dependencies": { "alrighty": { "version": "1.0.0", "from": "node_shrinkwrap/alrighty-1.0.0.tar", "resolved": "./node_shrinkwrap/alrighty-1.0.0.tar" }, ... }
    After reading the tutorial, I would expect from to be more like a npm semver string, rather than a path to node_shrinkwrap
    C. Corey Capel
    @capelio
    @JamieMason ^