Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jul 08 19:22
    dependabot[bot] labeled #113
  • Jul 08 19:22
    dependabot[bot] labeled #113
  • Jul 08 19:22
    dependabot[bot] opened #113
  • Jul 08 19:22

    dependabot[bot] on nuget

    Bump Microsoft.AspNetCore.Mvc.C… (compare)

  • Jul 07 23:09
    dependabot[bot] labeled #112
  • Jul 07 23:09
    dependabot[bot] labeled #112
  • Jul 07 23:09
    dependabot[bot] opened #112
  • Jul 07 23:09

    dependabot[bot] on nuget

    Bump Microsoft.AspNetCore.Http … (compare)

  • Jun 28 09:48
    dionfoster commented #77
  • Jun 28 02:04
    rochitsen commented #77
  • Jun 24 13:02
    dependabot[bot] labeled #111
  • Jun 24 13:02
    dependabot[bot] labeled #111
  • Jun 24 13:02
    dependabot[bot] opened #111
  • Jun 24 13:02

    dependabot[bot] on npm_and_yarn

    Bump shell-quote from 1.7.2 to … (compare)

  • Jun 22 15:32
    dependabot[bot] labeled #110
  • Jun 22 15:32
    dependabot[bot] labeled #110
  • Jun 22 15:32
    dependabot[bot] opened #110
  • Jun 22 15:32

    dependabot[bot] on nuget

    Bump Newtonsoft.Json from 9.0.1… (compare)

  • Jun 14 19:45
    satishviswanathan commented #84
  • Jun 14 18:14
    jeremydmiller commented #84
Jeremy D. Miller
@jeremydmiller
I probably added the Sdk thing at some point when I was doing 3.0
Jonathan Mezach
@jmezach
@jeremydmiller I created another PR with some additional build related changes: rytmis/alba#3
If @rytmis can merge that we can have a look at the build and see if everything is working now
Lauri Kotilainen
@rytmis
Done
Jeremy D. Miller
@jeremydmiller
Nice, got it
Jeremy D. Miller
@jeremydmiller
@jmezach When you saw the tests for Alba failing in CI even though all the tests passed, what did you do to address that? I’m seeing the exact same problem in Lamar
Jonathan Mezach
@jmezach
@jeremydmiller In the case of Alba the problem was that the tests were being run against .NET Core 2.1, 2.2 and 3.0, with the middle one (2.2) failing because of the 2.2.7 runtime not being installed on the built machine. 2.2.7 is the latest version in the 2.2 train afaik, thus I thought that the TargetLatestRuntimePatch MSBuild property was causing that failure.
Something's still going wrong with Alba though, looks like the NuGet package is being produced but not uploaded as an artifact
Jonathan Mezach
@jmezach
I noticed when running the build on my own machine that the package was being created outside of the repository. Maybe something changed with dotnet pack in that the output path is now relative from where the command is run, rather than the project file?
Jeremy D. Miller
@jeremydmiller
Yeah, saw that in Oakton. The pathing rules changed somehow in the .Net Core 3 version of the dotnet cli. That’s easier to deal with.
Jonathan Mezach
@jmezach
I'll try to fix that ;)
Jeremy D. Miller
@jeremydmiller
The irritating thing is that it worked the way you’d expect in the original, project.json version of dotnet pack, but was changed when they rammed MSBuild underneath it. Looks like it got reverted to the way you would have expected it to work
Jonathan Mezach
@jmezach
@rytmis Yet another PR: rytmis/alba#4 ;)
Lauri Kotilainen
@rytmis
Merged, sorry for the delay
Jonathan Mezach
@jmezach
No worries :)
Nice, looks like we have an artifact now
I'll give that package a try to see if it still works correctly ;)
Although that might be problematic since the version is still the same
Jeremy D. Miller
@jeremydmiller
Can you bump the version to 3.1?
Jonathan Mezach
@jmezach
;) If you can point me to where I need to make the necessary changes
Jeremy D. Miller
@jeremydmiller
Open up the actual csproj file and change the <VersionPrefix> node. Since Alba is so small, I didn’t do anything fancier than that
Jonathan Mezach
@jmezach
@rytmis Here we go again ;) rytmis/alba#5
Jonathan Mezach
@jmezach
Alright, we got an Alba 3.1.0 package
I need to get going now, will try tomorrow
Jonathan Mezach
@jmezach
I just ran tests that use Alba on both netcoreapp2.2 and netcoreapp3.0 with 3.1.0 and they work just fine
Mind you I only have 4 tests, but I guess that the basic scenario's work
@jeremydmiller Are there any specific scenario's you would like to see working?
Lauri Kotilainen
@rytmis
I've got a test suite that I had to disable when I migrated the app to netcoreapp30. I should give that a try now.
Lauri Kotilainen
@rytmis
Ah, making Alba target netcoreapp2x instead of netstandard2x means I can't reference it in a netstandard20 class library.
Jonathan Mezach
@jmezach
I guess not. @rytmis Is there a specific reason why you'd want to do that?
Lauri Kotilainen
@rytmis
Well, my wrapper library for Alba was netstandard20, so I have to change that.
Might not be much of an issue, we'll see...
Jonathan Mezach
@jmezach
@jeremydmiller What do you think? Should we still support netstandard2.0 TFM?
Lauri Kotilainen
@rytmis

Well, it looks like I can make it work with netcoreapp as well.

Also, good news, everyone: not only does my test suite work with netcoreapp3.0 now, it also found a rather major mistake I had made when migrating the app...

Jonathan Mezach
@jmezach
;) Nice
Jonathan Mezach
@jmezach
Looks like we are ready to merge then, if @jeremydmiller agrees ;)
Lauri Kotilainen
@rytmis
Yeah, I'm down with that.
Arguably it's a semver-breaking change to switch the TFMs like that, but I don't think Jeremy has been that strict about those -- and with the ever-shifting platform, being strict about it means a lot of work.
Jeremy D. Miller
@jeremydmiller
@jmezach I’ve gone back and forth on whether we do it by targeting the runtimes or not. I’d say netstandard2.0 is for ASP.Net Core v2.*, and netstandard2.1 for ASP.Net Core 3.0 applications
If we can possibly get away with that anyway.
Jonathan Mezach
@jmezach
AFAIK ASP.NET Core 3.0 itself only targets netcoreapp3.0 and no longer targets netstandard
So I don't think there's much point in letting Alba target netstandard2.1
Jeremy D. Miller
@jeremydmiller
Looking at the published Nugets, you’re right. Looking at the main hosting Nuget, it's targeting netstandard2.0 and netcoreapp3.0
Jonathan Mezach
@jmezach
There might be value in sticking with netstandard2.0 to stay compatible with ASP.NET Core 2.x on .NET Framework
Jeremy D. Miller
@jeremydmiller
I think just what you said here. We’ll probably need to set up dependency version ranges though. I don’t think I did that the first time through.
I’ll have some time this weekend to go over the Nuget mechanics, then get this published if you two think it’s ready
Jonathan Mezach
@jmezach
As far as I am concerned it's good to go ;)
Now I just need to have some more packages start to support .NET Core 3.0 :P
Lauri Kotilainen
@rytmis
Functionality-wise, things look good to me. If we're confident that .NET Standard 2.1 is functionally equivalent to netcoreapp3.0 in Alba's particular case, then sure, why not go with that.
Jeremy D. Miller
@jeremydmiller