Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jun 24 13:02
    dependabot[bot] labeled #111
  • Jun 24 13:02
    dependabot[bot] labeled #111
  • Jun 24 13:02
    dependabot[bot] opened #111
  • Jun 24 13:02

    dependabot[bot] on npm_and_yarn

    Bump shell-quote from 1.7.2 to … (compare)

  • Jun 22 15:32
    dependabot[bot] labeled #110
  • Jun 22 15:32
    dependabot[bot] labeled #110
  • Jun 22 15:32
    dependabot[bot] opened #110
  • Jun 22 15:32

    dependabot[bot] on nuget

    Bump Newtonsoft.Json from 9.0.1… (compare)

  • Jun 14 19:45
    satishviswanathan commented #84
  • Jun 14 18:14
    jeremydmiller commented #84
  • Jun 14 17:31
    satishviswanathan commented #84
  • May 30 11:22
    PhilipRRWFM edited #109
  • May 30 11:15
    PhilipRRWFM opened #109
  • May 22 16:15
    hartmark commented #108
  • May 22 16:13
    hartmark opened #108
  • May 17 01:34
    Hawxy commented #107
  • May 04 13:52
    nghhoese commented #70
  • May 02 17:13
    jasper-ci removed as member
  • Apr 25 13:44
    marcindruzgala opened #107
  • Mar 23 08:52
    AdaskoTheBeAsT commented #106
Jonathan Mezach
@jmezach
Mind you I only have 4 tests, but I guess that the basic scenario's work
@jeremydmiller Are there any specific scenario's you would like to see working?
Lauri Kotilainen
@rytmis
I've got a test suite that I had to disable when I migrated the app to netcoreapp30. I should give that a try now.
Lauri Kotilainen
@rytmis
Ah, making Alba target netcoreapp2x instead of netstandard2x means I can't reference it in a netstandard20 class library.
Jonathan Mezach
@jmezach
I guess not. @rytmis Is there a specific reason why you'd want to do that?
Lauri Kotilainen
@rytmis
Well, my wrapper library for Alba was netstandard20, so I have to change that.
Might not be much of an issue, we'll see...
Jonathan Mezach
@jmezach
@jeremydmiller What do you think? Should we still support netstandard2.0 TFM?
Lauri Kotilainen
@rytmis

Well, it looks like I can make it work with netcoreapp as well.

Also, good news, everyone: not only does my test suite work with netcoreapp3.0 now, it also found a rather major mistake I had made when migrating the app...

Jonathan Mezach
@jmezach
;) Nice
Jonathan Mezach
@jmezach
Looks like we are ready to merge then, if @jeremydmiller agrees ;)
Lauri Kotilainen
@rytmis
Yeah, I'm down with that.
Arguably it's a semver-breaking change to switch the TFMs like that, but I don't think Jeremy has been that strict about those -- and with the ever-shifting platform, being strict about it means a lot of work.
Jeremy D. Miller
@jeremydmiller
@jmezach I’ve gone back and forth on whether we do it by targeting the runtimes or not. I’d say netstandard2.0 is for ASP.Net Core v2.*, and netstandard2.1 for ASP.Net Core 3.0 applications
If we can possibly get away with that anyway.
Jonathan Mezach
@jmezach
AFAIK ASP.NET Core 3.0 itself only targets netcoreapp3.0 and no longer targets netstandard
So I don't think there's much point in letting Alba target netstandard2.1
Jeremy D. Miller
@jeremydmiller
Looking at the published Nugets, you’re right. Looking at the main hosting Nuget, it's targeting netstandard2.0 and netcoreapp3.0
Jonathan Mezach
@jmezach
There might be value in sticking with netstandard2.0 to stay compatible with ASP.NET Core 2.x on .NET Framework
Jeremy D. Miller
@jeremydmiller
I think just what you said here. We’ll probably need to set up dependency version ranges though. I don’t think I did that the first time through.
I’ll have some time this weekend to go over the Nuget mechanics, then get this published if you two think it’s ready
Jonathan Mezach
@jmezach
As far as I am concerned it's good to go ;)
Now I just need to have some more packages start to support .NET Core 3.0 :P
Lauri Kotilainen
@rytmis
Functionality-wise, things look good to me. If we're confident that .NET Standard 2.1 is functionally equivalent to netcoreapp3.0 in Alba's particular case, then sure, why not go with that.
Jeremy D. Miller
@jeremydmiller
Thanks for all your work on this one.
Lauri Kotilainen
@rytmis
Yay! Thanks. 🙂
Jonathan Mezach
@jmezach
@jeremydmiller Thank you for letting us do this ;). Glad I could help out here.
Craig Quillen
@cquillen
Just getting started with Alba. Trying to test a Core MVC controller action.
It's failing with "bad request - invalid hostname"
Here is my SUT setup code:
       public async Task Test_Logging()

        {

            var builder = BusinessRulesEngine.Web.Program.CreateWebHostBuilder(new string[] { });



            using (var system = new SystemUnderTest(builder, typeof(Startup).Assembly))

            {

                await system.Scenario(_ =>

                {

                    _.Get.Url("/home/TestLogging");

                    _.ContentShouldBe("");

                    _.StatusCodeShouldBeOk();

                });



            }

        }
thoughts on why it doesn't like the hostname?
@jeremydmiller
Jeremy D. Miller
@jeremydmiller
I have no idea, I’ve never seen that before. Can you post the actual stacktrace? Something tripping up inside of AspNetCore itself I’d expect. Something in your code looking for the host name off of the HttpContext?
Craig Quillen
@cquillen
I actually just figured it out.
had mixed runtime refs between app and test projects.
added these to test.csproj
<TargetLatestRuntimePatch >true</TargetLatestRuntimePatch >
Jeremy D. Miller
@jeremydmiller
AspNetCore 2.*? I think that’s in the Alba documentation isn’t it?
Not an issue w/ AspNetCore 3.0 I believe
Craig Quillen
@cquillen
and <project sdk="microsoft.net.sdk.web"
yeah 2.2
i was also getting the multiple version warning during assembly binding
all better now
not sure about the docs. I'll look again.
now i'm getting authorization failures, but that I understand. I've not done anything to set an auth header for my test request.
pretty sure it's working
Jeremy D. Miller
@jeremydmiller
Cool, and feel free to yell back here about any holes in the docs
For 3.0, they changed things for Nuget references for AspNetCore yet again. Alba just targets netcoreapp3.0 and the references will float based on the runtime version now. Should soften up the exact problems you saw