I have this code to assert on GraphQL queries
public class SuccessResultAssertion : GraphQLAssertion
{
private readonly string _result;
public SuccessResultAssertion(string result) => _result = result;
public override void Assert(Scenario scenario, HttpContext context, ScenarioAssertionException ex)
{
var writer = (IDocumentWriter) context.RequestServices.GetService(typeof(IDocumentWriter));
var expectedResult = writer.Write(CreateQueryResult(_result));
var body = ex.ReadBody(context);
if (!body.Equals(expectedResult))
{
ex.Add($"Expected '{expectedResult}' but got '{body}'");
}
}
}So I noticed that while executing tests only the first test has context.RequestServices filled, the scond tests throws an exception as RequestServices is null
IScenarioAssertion
what I see as benefit as well is that on UT actions as here
[Test]
public async Task SearchOneFondsQueries()
{
await Run(
_ =>
{
var input = new GraphQLRequest
{
Query = @"{ funds(searchQuery: ""Fond de Test Hedge en Duration"") { name } }"
};
_.Post.Json(input).ToUrl("/graphql");
_.StatusCodeShouldBe(HttpStatusCode.OK);
_.GraphQL()
.ShouldBeSuccess(@"{ ""funds"": [
{
""name"": ""Fond de Test Hedge en Duration""
}]}");
});
}where Scenario is passed in into the Run function, I could add extensions method that would allow for me to retrieve a dependency, and configure expectations on it. Because for my test some fake dependencies are registered in within the test startup and initialized with SystemUnderTest.ForStartup<T>(builder =>... so that way I would have an easy way to retrieve them and set expectations based on test requirements
@jeremydmiller I just started playing around with Alba for some HTTP API integration tests. So far, I like it a lot. One thing that bugs me though is that the built-in assertion on the content type behaves not as I would expect. I have configured my scenario _.ContentTypeShouldBe("application/problem+json"), which then fails with:
Alba.ScenarioAssertionException : Expected a single header value of 'content-type'='application/problem+json', but the actual value was 'application/problem+json; charset=utf-8'Of course I can include the charset on the expected value. However, it feels a bit clunky to do so. I could make a contribution to improve this if you like, but I am not sure if this fits in your ideas how the library should develop.
