but the other handler, which is set up almost identically (
UpdateFeatureSubscriptionsHandler) has been working fine (not sure if it still is, but I assume it is)
the code gen came out in a different order the second time around, so that was the
runReportHandler that I saw without the elided task lol
so if you want to spend more time "doing it right" that's fine with me
let me see if I can throw together a pull request for you
I know you've been busy at work lately :)
I swear I’ve tried to deal with this before, but that would have been ~2 years ago and I’ve slept since then
So there seems to be a few different places where fixing this issue could be done, lamar's code gen seems to lean on the
AsyncMode setting on the GeneratedMethod, but it also never seems to actually set that. So to make it "smarter" it would need to lean a little more on computing what the async mode should be.
So I'm happy to work on a PR for you, but I would need a little guidance from you on how to implement it. At which point, maybe you just would rather do it yourself.
@jeremydmiller Ok, so after a lot of digging, and wracking my brains on how to successfully write a failing unit test for this, it looks like the fix is fairly simple. It looks like just changing the
ServiceScopeFactoryCreation to set IsAsync to true would solve the problem, even though that is technically not true.
Also, it derives from
SyncFrame, which always sets it to false, but doesn't provide anything else, so I'm not sure if there's some significance to making it a SyncFrame.
But in my hacky little test, making that simple change solves the problem
?
Ok, so my thought is to add a new property to Frame: RequiresAwait, and then modify the MethodFrameArranger.Arange() as:
public void Arrange(out AsyncMode asyncMode, out Frame topFrame)
{
var compiled = compileFrames(_method.Frames);
asyncMode = AsyncMode.AsyncTask;
if(compiled.Any(x => x.IsAsync) && compiled.Any(x => x.RequiresAwait))
{
asyncMode = AsyncMode.AsyncTask;
}
else if (compiled.All(x => !x.IsAsync))
{
asyncMode = AsyncMode.None;
}
else if (compiled.Count(x => x.IsAsync) == 1 && compiled.Last().IsAsync && compiled.Last().CanReturnTask())
{
asyncMode = compiled.Any(x => x.Wraps) ? AsyncMode.AsyncTask : AsyncMode.ReturnFromLastNode;
}
topFrame = chainFrames(compiled);
}Thoughts?
The case that screwed us is if ONLY the very last frame is IsAsync == true, but there’s another Frame somewhere that’s Wraps == true.
It solves your problem fast. Returning the last task was just more optimal performance wise where you could get away with it
So let me just change that quickly and see if that fixes the test
I'll submit a PR