Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jun 24 17:22
    dnfadmin commented #1846
  • Jun 24 17:22
    dnfadmin commented #1846
  • Jun 24 17:16

    jeremydmiller on master

    Fix StorageOperationWithDeletio… (compare)

  • Jun 24 17:16

    jeremydmiller on master

    Fix StorageOperationWithDeletio… (compare)

  • Jun 24 17:16
    jeremydmiller closed #2277
  • Jun 24 17:16
    jeremydmiller closed #2277
  • Jun 24 17:11
    jeremydmiller closed #2256
  • Jun 24 17:11
    jeremydmiller closed #2256
  • Jun 24 17:11
    jeremydmiller closed #2243
  • Jun 24 17:11
    jeremydmiller closed #2243
  • Jun 24 17:11

    jeremydmiller on include-issues

    (compare)

  • Jun 24 17:11

    jeremydmiller on include-issues

    (compare)

  • Jun 24 17:11

    jeremydmiller on master

    WIP: failing tests to reproduce… Linq fixes for Include + paging… (compare)

  • Jun 24 17:11

    jeremydmiller on master

    WIP: failing tests to reproduce… Linq fixes for Include + paging… (compare)

  • Jun 24 17:11
    jeremydmiller closed #2280
  • Jun 24 17:11
    jeremydmiller closed #2280
  • Jun 24 17:00

    jeremydmiller on master

    Fetch stream for writing works … (compare)

  • Jun 24 17:00
    jeremydmiller closed #2273
  • Jun 24 17:00

    jeremydmiller on master

    Fetch stream for writing works … (compare)

  • Jun 24 17:00
    jeremydmiller closed #2273
Babu Annamalai
@mysticmind
Yeah, but it atleast reduces the surface area the problems...
Oskar Dudycz
@oskardudycz
Yes, at least it will cut some weird bugs questions from the users as we had last time
I’ll prepare the PR for that
I’ll also check if we can drop using Npgsql.json.net package, that’s forcing the JSON.net upgrade
Babu Annamalai
@mysticmind
Sure
Oskar Dudycz
@oskardudycz
I think that if we move to support 462 or 461 then we could probably also go with the minor update
Although I really don't think comfortable with not following strictly semantic versioning...
It’s even more confusing for the users more than it is for us...
We could, in theory, go with 4.0 just to be prim and proper
but then it won’t be good from the marketing perspective
As we already officially started a discussion on the plans for the v4
Babu Annamalai
@mysticmind
Note that there is already an issue raised by a user who attempted upgrading to Npgsql 4.1.0. JasperFx/marten#1359
Oskar Dudycz
@oskardudycz
Yeah, but it’s from v3
I think that we need to do a better job of being more proactive in the version checking (eg. as @baronfel did for us). I was thinking about some nightly build with the latest prerelease of npgsql
Oskar Dudycz
@oskardudycz
I’ll probably also create issues with that for them, but imho we should try to be closer to them, as it’s our major reference package
Babu Annamalai
@mysticmind
I think the user has incorrectly put details as v3
However close we work with Npgsql versions, any breaking changes will take time to resolve for us
Nightly build with pre-release versions of Npgsql would certainly help us to uncover issues sooner than later
Oskar Dudycz
@oskardudycz
Yes I agree, but if we work closely with them then we can discuss with them turnaround as @baronfel together with me did
In general, I’m trying to find some pragmatic approach
😉
Babu Annamalai
@mysticmind
We depend fully on Npgsql so it imperative for us to figure out a pragmatic approach :-)
Oskar Dudycz
@oskardudycz
Exactly - yelling at clouds won't help 😋
(unfortunately 😉)
Jeremy D. Miller
@jeremydmiller
I say to limit it to 4.0 to <4.1 for right now
Oskar Dudycz
@oskardudycz
Ok, I checked, Npgsql.Json.NET can't be removed
here's the PR
Oskar Dudycz
@oskardudycz
I discussed with @roji on https://gitter.im/npgsql/npgsql the plan for the upgrade. They're willing to revert the JSON.NET upgrade
So the plan would be for this time being we'll:
  • lock the version to <4.1
  • review other potential issues and send the feedback to npgsql team
  • wait for the fixes in 4.1.1
  • make the update
Shay Rojansky
@roji
I'm also OK with reverting anything else that doesn't mean a major conflict/break/rewrite
Oskar Dudycz
@oskardudycz
:+1:
I wasn't aware that you're also on our channel :)
Shay Rojansky
@roji
Neither was I :) I think it's because I just got mentioned?
Oskar Dudycz
@oskardudycz
might be, but that's cool - you're more than welcome here :)
Shay Rojansky
@roji
Jeremy D. Miller
@jeremydmiller
@roji Since you’re here, do y’all use any kind of automated tooling to check for SemVer violations in your API surface? The NServiceBus guys have something for that, but I’ve never used that. Or I’m guess that I’m asking, could you start doing that?
Shay Rojansky
@roji
Yeah, this release made me think about that more
In general things have been a bit too lax on that front
Jeremy D. Miller
@jeremydmiller
With Newtonsoft you might be able to get away with setting a pretty permissive version range. Newtonsoft is always a risk for diamond dependency issues
Shay Rojansky
@roji
We really don't plan for another minor release before 5 so I wouldn't say it's urgent. Also, this mess was a result of us not planning to have a 4.1 originally, and deciding to do one after breaking changes were already introduced
So there are some "justifications" for why this happened
Re Newtonsoft, I don't really have any specific dependency (or feelings) about a specific version. It's true that up to now we generally target the highest version to make sure we're compatible with that
Users can always override though if necessary
Jeremy D. Miller
@jeremydmiller
Dude, I’ve got plenty of sympathy here, but y’all are a foundational library
Shay Rojansky
@roji
Yeah, I dropped the ball on this, no excuses really.
Jeremy D. Miller
@jeremydmiller
Again, I’m sympathetic as a 15 year OSS author:)
Shay Rojansky
@roji
Thanks for saying that...
Oskar Dudycz
@oskardudycz
btw. there is a nice discussion on the "Maturity Ladder" that was mentioned on the channel. https://github.com/dotnet-foundation/project-maturity-model/issues/32#issuecomment-536282845 I've also put my few cents there.
Oskar Dudycz
@oskardudycz
3.8.1 version with locked Npgsql version released