Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Oct 21 16:02
    eouw0o83hf opened #1585
  • Oct 21 16:02
    eouw0o83hf opened #1585
  • Oct 21 03:42
    longility commented #1578
  • Oct 21 03:42
    longility commented #1578
  • Oct 20 18:27

    mysticmind on master

    Remove matrix build and replace… Update npgsql min version to 4.… Disable test parallelization in… (compare)

  • Oct 20 18:27

    mysticmind on master

    Remove matrix build and replace… Update npgsql min version to 4.… Disable test parallelization in… (compare)

  • Oct 20 17:39

    mysticmind on master

    Disable test parallelization in… (compare)

  • Oct 20 17:39

    mysticmind on master

    Disable test parallelization in… (compare)

  • Oct 20 17:07

    mysticmind on master

    Update npgsql min version to 4.… (compare)

  • Oct 20 17:07

    mysticmind on master

    Update npgsql min version to 4.… (compare)

  • Oct 20 16:56

    mysticmind on master

    Remove matrix build and replace… (compare)

  • Oct 20 16:56

    mysticmind on master

    Remove matrix build and replace… (compare)

  • Oct 20 15:46

    jeremydmiller on master

    one off context wasn't marked a… (compare)

  • Oct 20 15:46

    jeremydmiller on master

    one off context wasn't marked a… (compare)

  • Oct 20 15:35

    jeremydmiller on master

    working over the integration te… Merge branch 'master' of https:… (compare)

  • Oct 20 15:35

    jeremydmiller on master

    working over the integration te… Merge branch 'master' of https:… (compare)

  • Oct 20 07:45

    mysticmind on master

    Add GH Actions based CI Build (compare)

  • Oct 20 07:45

    mysticmind on master

    Add GH Actions based CI Build (compare)

  • Oct 20 07:43

    mysticmind on master

    Disable Azure pipelines to enab… (compare)

  • Oct 20 07:43

    mysticmind on master

    Disable Azure pipelines to enab… (compare)

Oskar Dudycz
@oskardudycz
I have .NET 5 installed and I was doing workshop with Marten and I didn't face any issues so it might not be so hard
however I was using the netcore3 apps
only compiling it with .NET 5
Jeremy D. Miller
@jeremydmiller
Yeah, that shouldn’t be an issue at all. There’s always dependency problems when we get these new .Net versions
Oskar Dudycz
@oskardudycz
Wasn't the whole idea of netstandard and netcore that we should finaly not have those problems? 🤔
(Sorry, I'm just trolling :wink: )
JT
@Hawxy
Is marten getting rid of the net461 target for v4?
Oskar Dudycz
@oskardudycz
I'd like to, but I'm not sure
@jeremydmiller @mysticmind how will we proceed with that?
Jeremy D. Miller
@jeremydmiller
I think all the core team wants to
Oskar Dudycz
@oskardudycz
Maybe we could try to at least ask on twitter?
Babu Annamalai
@mysticmind
I would definitely like to get rid of net461 as well. We don't have a insight into users running Marten on different .NET versions. That said, given that we are on v4, I think focusing on .NET 5 and running unit tests against it will be a better bet. So we can just go ahead and get rid of net461 and see how many users eventually start to complain :-)
If someone wants to stick with net461, they can run on 3.x, it is a happy path!
I will attempt to add CI build for .NET 5
Jeremy D. Miller
@jeremydmiller
Can we just call it and kill .Net 4.6.1 right here and now? Nobody wants to support it, Marten 3.* still works, and we don’t get paid to keep that going. It’s gonna make all of us happier and that’s not nothing
Babu Annamalai
@mysticmind
resounding yes from me!
Oskar Dudycz
@oskardudycz
Yup. I second that
We could provide paid support if someone wants to have it for 4.6.1
Microsoft does the same for older .NET
Do we want to also update to netstandard2.1?
Marko Lahma
@lahma
netstandard2.0 allows full framework development, 2.1 does not. so you would be cutting out all FW users
Jeremy D. Miller
@jeremydmiller
I don’t think we should move up from netstandard2.0
What he said:0
Babu Annamalai
@mysticmind
Also netstandard2.1 requires min .NET Core 3.0
Oskar Dudycz
@oskardudycz
Fine for me
However we need to remember that’s not LTS from MS
Jeremy D. Miller
@jeremydmiller
True, but that doesn’t cause us anywhere near the headaches that .net 4.* does
Oskar Dudycz
@oskardudycz
Agree
I’ll prepare pr for that then
Babu Annamalai
@mysticmind
image.png
With 4.x, we are not targeting net461 but for netstandard2.0
the alpha up in NuGet only targets netstandard2.0
we already killed it and discussing after the fact :-)
Oskar Dudycz
@oskardudycz
🔥✊😁
Marko Lahma
@lahma
next up, should first 4.0 alpha be released :wink:
Jeremy D. Miller
@jeremydmiller
Go look on Nuget;)
Marko Lahma
@lahma
do you have any wild guesses about "JSON compatibility" along the road to the 4.0 final? i.e. if I'd go with 4.0 alpha now and build a huge event store will there be a lot of hair-pulling to migrate database JSON data to RTM
@lahma No changes whatsoever right now. I think there will be additive changes to the database schema for the async projections and probably additional functions, but nothing destructive in the database
Marko Lahma
@lahma
nice! thank you
bitbonk
@bitbonk
what migration options do I have when I need to make breaking changes to the model classes that have already been persisted ?
should I create a new model in a V2 Namespace and then load it using V1, migrate to V2 and then save it ?
Zbigniew Żołnierowicz
@zbigniewzolnierowicz
Hey! I have a question - does Marten support ignoring properties of a class when building a schema? Sort of like the Entity Framework's [NotMapped]?
Babu Annamalai
@mysticmind
@bitbonk The strategy is wholly up to the application logic to implement how you see it fit. Please check https://martendb.io/documentation/documents/advanced/javascript_transformations/ and https://martendb.io/documentation/documents/advanced/patch_api/ to get some ideas around how to deal with v1 data when you fetch it or can update/migrate the persisted records to v2
Babu Annamalai
@mysticmind
@zbigniewzolnierowicz I don't think Marten has the ability to ignore a property when defining the schema. A workaround is for you to use https://www.newtonsoft.com/json/help/html/PropertyJsonIgnore.htm since Marten uses Newtonsoft.Json as the default serializer.
Zbigniew Żołnierowicz
@zbigniewzolnierowicz
@mysticmind that's what I thought, thank you for your answer!
Babu Annamalai
@mysticmind
Most welcome :thumbsup:
Jeremy D. Miller
@jeremydmiller
@zbigniewzolnierowicz I wouldn’t say “workaround” so much as we support anything that Newtonsoft.Json does:)
Oskar Dudycz
@oskardudycz
@zbigniewzolnierowicz I was always using JsonIgnore for that plus once I configured custom Newtonsoft.Json configuration to support NotMapped attribute https://docs.microsoft.com/en-us/dotnet/api/system.componentmodel.dataannotations.schema.notmappedattribute?view=netcore-3.1
it's relatively easy to do, by extending the json resolver