Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Apr 14 15:19

    github-actions[bot] on v4.5.0

    (compare)

  • Apr 14 15:17

    jeremydmiller on master

    option to also clear state on a… (compare)

  • Apr 14 13:59

    github-actions[bot] on v4.4.0

    (compare)

  • Apr 14 13:54

    jeremydmiller on master

    new extension methods for rebui… (compare)

  • Apr 13 19:46

    github-actions[bot] on v4.3.1

    (compare)

  • Apr 13 19:43

    jeremydmiller on master

    changing the resources display … (compare)

  • Apr 13 13:43

    github-actions[bot] on v4.3.0

    (compare)

  • Apr 13 13:34

    jeremydmiller on master

    Workaround for extension servic… (compare)

  • Apr 08 15:56

    github-actions[bot] on v4.2.0

    (compare)

  • Apr 08 15:53
    dependabot[bot] labeled #65
  • Apr 08 15:53
    dependabot[bot] opened #65
  • Apr 08 15:53

    dependabot[bot] on npm_and_yarn

    Bump prismjs from 1.25.0 to 1.2… (compare)

  • Apr 08 15:53
    jeremydmiller closed #64
  • Apr 08 15:53
    jeremydmiller closed #62
  • Apr 08 15:53
    jeremydmiller closed #61
  • Apr 08 15:53
    jeremydmiller closed #63
  • Apr 08 15:53
    jeremydmiller closed #60
  • Apr 08 15:53

    jeremydmiller on master

    ran the stdocs to vitepress con… *mostly* converted docs to Vite… deleting obsolete stdocs docume… and 9 more (compare)

  • Apr 08 15:36
    jeremydmiller milestoned #64
  • Apr 08 15:36
    jeremydmiller milestoned #63
David Smith
@flipdoubt
@jeremydmiller even if the pull request simply changes the access modifier from internal to public? Just curious as to why you went with internal.
Jeremy D. Miller
@jeremydmiller
I can’t say I ever thought about the configuration preview being swappable, so there was no reason to make it public
David Smith
@flipdoubt
When running my code on a machine without Visual Studio, I get an error with the following stack trace. I searched the docs but didn't find anything regarding "Microsoft.CodeAnalysis". How can I fix this issue?
[2021-05-03 16:05:42Z] [FTL] [<s:>] WebApp failed to start.
System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.CodeAnalysis, Version=2.3.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. The system cannot find the file specified.
File name: 'Microsoft.CodeAnalysis, Version=2.3.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'
   at System.ModuleHandle.ResolveType(QCallModule module, Int32 typeToken, IntPtr* typeInstArgs, Int32 typeInstCount, IntPtr* methodInstArgs, Int32 methodInstCount, ObjectHandleOnStack type)
   at System.ModuleHandle.ResolveTypeHandleInternal(RuntimeModule module, Int32 typeToken, RuntimeTypeHandle[] typeInstantiationContext, RuntimeTypeHandle[] methodInstantiationContext)
   at System.Reflection.RuntimeModule.ResolveType(Int32 metadataToken, Type[] genericTypeArguments, Type[] genericMethodArguments)
   at System.Reflection.CustomAttribute.FilterCustomAttributeRecord(MetadataToken caCtorToken, MetadataImport& scope, RuntimeModule decoratedModule, MetadataToken decoratedToken, RuntimeType attributeFilterType, Boolean mustBeInheritable, ListBuilder`1& derivedAttributes, RuntimeType& attributeType, IRuntimeMethodInfo& ctorWithParameters, Boolean& isVarArg)
   at System.Reflection.CustomAttribute.IsCustomAttributeDefined(RuntimeModule decoratedModule, Int32 decoratedMetadataToken, RuntimeType attributeFilterType, Int32 attributeCtorToken, Boolean mustBeInheritable)
   at System.Reflection.CustomAttribute.IsDefined(RuntimeAssembly assembly, RuntimeType caType)
   at System.Reflection.RuntimeAssembly.IsDefined(Type attributeType, Boolean inherit)
   at System.Attribute.IsDefined(Assembly element, Type attributeType, Boolean inherit)
   at System.Reflection.CustomAttributeExtensions.IsDefined(Assembly element, Type attributeType)
   at Baseline.Reflection.ReflectionExtensions.HasAttribute[T](Assembly provider)
   at Oakton.CommandFactory.<>c.<RegisterCommandsFromExtensionAssemblies>b__30_0(Assembly a)
Jeremy D. Miller
@jeremydmiller
Can you try cleaning off your code first, then trying it from scratch? That just smells like dotnet restore not running cleanly from trash left behind
David Smith
@flipdoubt
This is a staging machine, so it should be cleaner than my local machine where it works without error. One thing I haven't considered, however, is that it is a Production build instead of Debug, which I never really tested locally. Are there any considerations when running in production? dotnet run ... doesn't even work without the project file.
David Smith
@flipdoubt
Am I being silly in that this should never be in a release build?
Jeremy D. Miller
@jeremydmiller
I don’t know about that, but this just feels like a run of the mill Nuget dependency issue. Could be something has an incompatible reference to that Nuget, and it is a common diamond dependency.
We could relax the dependency in Baseline to let it float. That could easily be the culprit
David Smith
@flipdoubt
All I'm trying to do is test it with the output from dotnet publish ... and I can't even get the resulting binaries to recognize any of the Oakton commands. I can't use dotnet run ... here because there is no project file. How can I execute commands in a release build?
Jeremy D. Miller
@jeremydmiller
It publishes to an exe, right?
the results of dotnet publish?
Or if it writes to a dll, you can run that through dotnet run [assembly file name]. It’s been awhile since I’ve done that, so it might be a flag of some sort
David Smith
@flipdoubt

In dotnet core, dotnet run app.exe or any file produces a response like the following:

Couldn't find a project to run. Ensure a project exists in C:\code\publish\App, or pass the path to the project using --project.

From the dotnet-run docs:

The dotnet run command is used in the context of projects, not built assemblies. If you're trying to run a framework-dependent application DLL instead, you must use dotnet without a command.

Are people only using Oakton on source projects or on release builds as well?

Jeremy D. Miller
@jeremydmiller
If you have an exe, you should be able to just go “myapp [args]"
And folks are using Oakton to run .Net Core projects in production, yes. I’ve done that as well
David Smith
@flipdoubt
Excellent. So how do you invoke the describe command on a dotnet core executable compiled for release? For me, app.exe --describe or app.exe --help return without any console output.
Jeremy D. Miller
@jeremydmiller
app.exe describe
app.exe help should give you the help output
You wouldn’t need the double dash if you’re running from the executable instead of dotnet run
David Smith
@flipdoubt
Ah, ok. When I run app.exe help on my dev machine, my app logs the same FileNotFoundException referencing "Microsoft.CodeAnalysis". Now that I can reproduce that locally, I will go through the cleaning exercise.
Jeremy D. Miller
@jeremydmiller
So we still have the Nuget problem. You might see what version of that nuget gets published by dotnet publish
David Smith
@flipdoubt

Same result.

Which package are you referring to with "you might see what version of that nuget gets published by dotnet publish"? There is no Microsoft.CodeAnalysis.dll in the publish output.

Jeremy D. Miller
@jeremydmiller
Yeah, and that’s your problem
So when it says FileNotFoundException, it’s unable to load the assembly referenced. You might try making a direct dependency to that nuget package w/ that version
David Smith
@flipdoubt
Got it.
Thanks.
Jeremy D. Miller
@jeremydmiller
Sorry this is being frustrating. We’ve all been there.
bitbonk
@bitbonk
This is super cool, this should be part of Oakton: https://andrewlock.net/viewing-overriden-configuration-values-in-aspnetcore/
Jeremy D. Miller
@jeremydmiller
@bitbonk It is in 4.1 just by dumping out the built in ConfigurationRoot diagnostics, but not as pretty as what he did. Sounds like a good PR:)
bitbonk
@bitbonk
especially the overwritten values view, this is a live saver
Jeremy D. Miller
@jeremydmiller
Yup. I added it specifically for a project at work for exactly that reason.
bitbonk
@bitbonk
I'll see if I can get a PR ready, just might need to ask if I may steal the code from that post
Jeremy D. Miller
@jeremydmiller
I don’t think he’d mind, and it should be a quick win. should
bitbonk
@bitbonk
@jeremydmiller So here we go: JasperFx/oakton#52
David Smith
@flipdoubt
After changing the standard CreateHostBuilder(args).Build().Run() to CreateHostBuilder(args).RunOaktonCommands(args), some of the our middleware get loggers without log sinks configured. All I have to do is change to code back to fix it, so Build().Run(args) does something RunOaktonCommands(args) does not do. Any clue what that might be and whether there is a work around? It's as if Oakton doesn't call IHostBuilder.Build, but it is hard to tell.
Jeremy D. Miller
@jeremydmiller
@flipdoubt I think it’s more likely that what Oakton is doing when it tries to set the log level dynamically is messing with you.
David Smith
@flipdoubt
@jeremydmiller , I'm "good" with that too, though still confused because it only affects some of our loggers. Do you have any suggestions for a work around? How/where can I help?
Jeremy D. Miller
@jeremydmiller
If there isn’t one already, could you raise a bug in GitHub?
In the Oakton codebase, do a find usages on the NetInput.LogLevelFlag and see where it might be using that too aggressively. I’m inclined to blame Oakton’s special sauce here.
Like it may be clearing logging when it shouldn’t be.
David Smith
@flipdoubt
Looks like the same issue as #51 . I will look into the code too. Thanks.
Jeremy D. Miller
@jeremydmiller
@flipdoubt Sigh, it’s overdue for me to look at it if you don’t find something
David Smith
@flipdoubt
image.png
NetCoreInput.cs line 44 would be my guess, but I'm not sure what the intent is behind the code.
Jeremy D. Miller
@jeremydmiller
The original idea was to be able to change the log level up or down based on the input flag
David Smith
@flipdoubt
I haven't stepped into what HostBuilder.ConfigureLogging does, but does that clear all the individual namespaced filters I've configured in Serilog? I will need to write a sample that uses Serilog.
Jeremy D. Miller
@jeremydmiller
I’m guessing so.
David Smith
@flipdoubt
I've spent a decent chunk of time on it and found that code in NetCoreInput never has a logger value and does not do anything out of the ordinary. Something that Oakton does while loading configuration from appsettings.json interferes with how Serilog configures sinks and forces Serilog to use a SilentLogger as described by serilog/serilog#562 and shown below.
image.png
I am able to correct this by configuring Serilog with the preserveStaticLogger: true parameter described here.