Jinja2Cpp/Lobby

Flex Ferrum

@flexferrum

@martinmoene why can it happen?

I cloned optional-lite did git tag and got list of tags.

I did the same with expected-lite and got empty list

Actually, Manu's expected-lite conan package now broken due to this issue. And I suppose Martin's conan package is broken as well for the same reason.

Flex Ferrum

@flexferrum

And one more question. Jinja2C++ got one dependence which is absent in conan (robin_hood hash map). Thus conan build script should relay not only conan deps, but on external repo. How to implement in correctly? Can I treat this dep as internal and get it from github inside my build scripts or there is more convenient solution.

Flex Ferrum

@flexferrum

Meet the conan.io package for the Jinja2C++ 1.0.0!

https://github.com/jinja2cpp/conan-recipes/tree/master/Jinja2Cpp/current

Need to fix passing MSVC runtime type from conan settings to the Jinja2C++ cmake - and ready to upload the package to the bintray.

Flex Ferrum

@flexferrum

I think, that's good opportunity for Jinja2Cpp https://blog.conan.io/2019/09/04/A-new-binary-building-service-for-Conan-center-packages.html

Javier G. Sogo

@jgsogo

We think it is the best way for open source projects and community (but I'm a little bit biased :laughing: )

Community will help you to maintain the recipe and we will be able to generate the packages if a new compiler appears

Also, you don't have to worry about writing your CI for Conan

Flex Ferrum

@flexferrum

So, I'll send the request for participate in EAP.

Thanks!

Do I understand correctly: when I make a PR to this repo, I won't need to maintain the recipe?

Javier G. Sogo

@jgsogo

Anyone will be able to submit a new PR to fix/improve, add new versions of your library,... it decouples recipe development from the library (or viceversa)

the community can take care of the recipe. Although someone (us) has to approve the PR, we free the library author from that burden

If you apply for the EAP, I will ensure that you are included asap

Flex Ferrum

@flexferrum

Thanks for the explanation!

Martin Moene

@martinmoene

@flexferrum (msg Aug 7) Are the tags still missing on a fresh clone? I get:

>git tag
v0.1.0
v0.2.0
v0.3.0

Original local repo also has v0.0.0, v0.0.1

Sorry for taking this long to come back at this.

Flex Ferrum

@flexferrum

Sorry for taking this long to come back at this.

No problems. :)

Are the tags still missing on a fresh clone

No. Now everything is fine.

Martin Moene

@martinmoene

Ah , just doing nothing can solve some things :)

Flex Ferrum

@flexferrum

Yes. Definitely. :)

Flex Ferrum

@flexferrum

@jgsogo https://github.com/conan-io/conan-center-index/issues/4#issuecomment-528812946

Javier G. Sogo

@jgsogo

Great! I'm not sure if today (weekend) we will be able to move it, it depends on people taking care of the infrastructure too, and we try to rest a little bit out of work hours

Your recipe depends on @martinmoene ones. Anyone can make the PR with a recipe, of course, but in case of recipe-library authors we (Conan team) prefer to wait and give them the opportunity to try Conan-center on their own... unless they ask for help

Flex Ferrum

@flexferrum

Thanks!

but in case of recipe-library authors we (Conan team) prefer to wait and give them the opportunity to try Conan-center on their own... unless they ask for help

Actually, it's possible to get rid of this deps as a conan deps and take it from github directly.

Flex Ferrum

@flexferrum

@jgsogo what do you think: in case of Jinja2Cpp what is better: to push @martinmoene recipes to the conan or to make them as a non-conan dependencies? I'd prefer the second case, but I need extra opinion.

Javier G. Sogo

@jgsogo

I think that @martinmoene recipes should be in Conan-center, for sure. You can always hide them behind your interface and it won't be a problem for people consuming your package. But if your API exposes some of the nonstd headers and your consumers are using a different version, the may have some problems

btw, you two are added to the EAP of Conan-center, you can submit the recipes and the CI will run ^^

Martin Moene

@martinmoene

I'd like to provide these recipes, but I may need some help with them... These weeks my mind is in a totally different place, of which the most earthly one is a kitchen-redo :)

Flex Ferrum

@flexferrum

Yes, I expose nonstd types via public interface. So... If @martinmoene doesn't mind, I'll submit the PR with his libraries I use.

Martin Moene

@martinmoene

@flexferrum Yes please :)

Flex Ferrum

@flexferrum

Perfect!

Martin Moene

@martinmoene

Thank you so much!

Flex Ferrum

@flexferrum

You are welcome. :)

Martin Moene

@martinmoene

Flex Ferrum

@flexferrum

So, firstly I'll push recipes for the nonstd libs and after successful acceptance that I'll push recipe for Jinja2Cpp

Javier G. Sogo

@jgsogo

Great! We would like to have as many contributors as possibe, that's the reason we are not uploading many recipes ourselves

Try to upload them, it should be quite straightforward, and there is a bot that will help you with the PR, but you can always ask ;D

Flex Ferrum

@flexferrum

Sure

Javier G. Sogo

@jgsogo

I've submitted one of the nonstd recipes to Conan Center index: conan-io/conan-center-index#55

Moving all of them should be quite straightforward (header only ones)

Flex Ferrum

@flexferrum

Ok! Thanks!

Flex Ferrum

@flexferrum

@jgsogo , is there a way to limit set of C++ standards available to the recipe?

Javier G. Sogo

@jgsogo

There is a compiler.cppstd setting, but I'm not sure how many profiles we are generating right now

Flex Ferrum

@flexferrum

I was offered another way of fix. :) It was my mistake.

Flex Ferrum

@flexferrum

PRs for expected-lite and variant-lite are successfully created.

Where communities thrive

People

Repo info

Activity