Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Oct 13 15:31

    Fabrice-TIERCELIN on master

    Handle eager operators (compare)

  • Oct 13 15:21

    Fabrice-TIERCELIN on master

    Reduce indentation (compare)

  • Oct 12 15:26

    Fabrice-TIERCELIN on master

    Missing break (compare)

  • Oct 12 15:18

    Fabrice-TIERCELIN on master

    Remove old config (compare)

  • Oct 12 15:11

    Fabrice-TIERCELIN on master

    Better clean control workflow (compare)

  • Oct 12 15:05

    Fabrice-TIERCELIN on master

    Better clean control workflow (compare)

  • Oct 12 14:57

    Fabrice-TIERCELIN on master

    Better clean control workflow (compare)

  • Oct 12 14:49

    Fabrice-TIERCELIN on master

    Better clean control workflow (compare)

  • Oct 12 14:43

    Fabrice-TIERCELIN on master

    Better clean control workflow (compare)

  • Oct 12 14:35

    Fabrice-TIERCELIN on master

    Better clean control workflow (compare)

  • Oct 12 14:19

    Fabrice-TIERCELIN on master

    Better clean control workflow (compare)

  • Oct 11 04:55

    Fabrice-TIERCELIN on master

    Do not refactor different falli… (compare)

  • Oct 11 04:36

    Fabrice-TIERCELIN on master

    Do not refactor different falli… (compare)

  • Oct 11 04:20

    Fabrice-TIERCELIN on master

    Do not refactor different falli… (compare)

  • Oct 10 17:11

    Fabrice-TIERCELIN on master

    Do not refactor different falli… (compare)

  • Oct 10 16:59

    Fabrice-TIERCELIN on master

    Do not refactor different falli… (compare)

  • Oct 10 16:37

    Fabrice-TIERCELIN on master

    Do not refactor different falli… (compare)

  • Oct 10 16:14

    Fabrice-TIERCELIN on master

    Do not refactor different falli… (compare)

  • Oct 10 16:02

    Fabrice-TIERCELIN on master

    Do not refactor different falli… (compare)

  • Oct 10 15:53

    Fabrice-TIERCELIN on master

    Do not refactor different falli… (compare)

Jean-Noël Rouvignac
@JnRouvignac
Yep I'll try to
Luis Cruz
@luiscruz
In order to fix PR #212 I need the method getAncestorOrNull that I’ve created on that one.
Jean-Noël Rouvignac
@JnRouvignac
it starts to be hard for me to keep up between yours PRs and Fabrice's :)
ok
Luis Cruz
@luiscruz
yea, I understand ;)
Jean-Noël Rouvignac
@JnRouvignac
OK there is a lot in this one
The rewrites are currently a bit blurred
it is hard to read when comes this level of rewriting
but I think I'll clean that up
I made several new comments
Please ping me once you'll have acted on them and pushed the new code for review
Luis Cruz
@luiscruz
ok
Luis Cruz
@luiscruz
ping :)
Luis Cruz
@luiscruz
I’ve fixed your code reviews. Let me know what is the next step
Jean-Noël Rouvignac
@JnRouvignac
Next step is tomorrow
:)
Luis Cruz
@luiscruz
deal! :D
Fabrice TIERCELIN
@Fabrice-TIERCELIN
Should I take #222?
Jean-Noël Rouvignac
@JnRouvignac
@Fabrice-TIERCELIN please do if you feel confident
be careful there are many corner cases here
methods (you can ignore parameters), fields, variables can be shadowed
etc.
This is pretty tough
maybe start small and provide a simple fix
then we'll take it forward from there
Jean-Noël Rouvignac
@JnRouvignac
@luiscruz I have looked at the PR and I have several problems with it
first of all mvn clean install fails
for the rest, maybe this is not the best medium here to explain them
last, reviewing PRs on github is not great IMO :(
but anyway we'll get through this
Jean-Noël Rouvignac
@JnRouvignac
What I mean is that there is more work needed before I can merge it
Luis Cruz
@luiscruz
Hi
I’ll see that now
Jean-Noël Rouvignac
@JnRouvignac
hello
I'll speak to you on hangout to avoid polluting this channel with remarks towards the PR
if you log in
:)
Luis Cruz
@luiscruz
are we talking about JnRouvignac/AutoRefactor#226?
Jean-Noël Rouvignac
@JnRouvignac
yes
Luis Cruz
@luiscruz
alright
we can speak on hangout
when are you available?
Jean-Noël Rouvignac
@JnRouvignac
let's chat now :)
no need to call IMO
Luis Cruz
@luiscruz
ok
Jean-Noël Rouvignac
@JnRouvignac
@cal101 nice job on the headless version of AutoRefactor!
cal
@cal101
Hi folks! @JnRouvignac @Fabrice-TIERCELIN
cal
@cal101
You may have noticed that I did some autorefactor related stuff lately. I am repeating an experiment executing bulk autorefactoring on a >16k classes legacy application to investigate the result. Autorefactorings are grouped. Execution is done via jenkins pipeline doing git commits between refactoring groups. The outcome is pushed and automatic testing is done. The line coverage is 43% so some semantic testing is done. @Fabrice-TIERCELIN fixed a lot of bugs lately and so i was able to enable most of the refactorings and the code compiles and all tests pass now.
cal
@cal101
Doing bulk refactorings and reviewing bulk results gives me a different view on the results of refactorings. Most improve quality some don't. Autorefactor plugin is like a closed app. Very useful even for beginners. Autorefactor cli is meant for the professional who needs some tweaking options. I will do obvious filters like excluding classes but I am reaching the point where i want to disable or tweak/disable parts of refactorings. I want to avoid forking and would like to discuss options to proceed.