These are chat archives for JnRouvignac/AutoRefactor

18th
Oct 2016
Luis Cruz
@luiscruz
Oct 18 2016 14:51
Hi Jean-Noël
I’ve finished implementing ViewHolder and DrawAllocation anti patterns
I believe we can move forward to code review, real app testing, and merging. What do you think?
There are some corner cases that I’ve been documenting with ToDo comments. I’ll try to implement some of them in the meantime
Jean-Noël Rouvignac
@JnRouvignac
Oct 18 2016 15:45
Ok
I'll be done with work in the house tomorrow
Luis Cruz
@luiscruz
Oct 18 2016 15:48
Alright, let’s try to do this tomorrow? The day after tomorrow?
Jean-Noël Rouvignac
@JnRouvignac
Oct 18 2016 15:49
Tomorrow
Luis Cruz
@luiscruz
Oct 18 2016 15:49
Alright ;)
Jean-Noël Rouvignac
@JnRouvignac
Oct 18 2016 15:49
How do you want to proceed ?
Tomorrow should be OK
First, let's do one rule at a time
It is complex enough :)
Luis Cruz
@luiscruz
Oct 18 2016 15:50
yea, sounds good
Jean-Noël Rouvignac
@JnRouvignac
Oct 18 2016 15:50
Do you want to submit a PR then I comment on it?
Luis Cruz
@luiscruz
Oct 18 2016 15:51
so perhaps I can try to create pull requests for yout github project
ok
sounds good
Jean-Noël Rouvignac
@JnRouvignac
Oct 18 2016 15:51
For each rule you should create an issue like the one I created
Yep PRs
One PR per rule
Luis Cruz
@luiscruz
Oct 18 2016 15:51
I have everything in the same branch
But I think it wont be difficult to separate.
Jean-Noël Rouvignac
@JnRouvignac
Oct 18 2016 15:52
You'll have to create separate branches for each rule
You'll have to rebase and squash commits
Make sure you mention the issue in the commit message
Luis Cruz
@luiscruz
Oct 18 2016 15:53
ok
Is it okay for you if I have a single commit for each rule?
Jean-Noël Rouvignac
@JnRouvignac
Oct 18 2016 15:55
Yes it will be easier for m
Luis Cruz
@luiscruz
Oct 18 2016 15:55
alright
Jean-Noël Rouvignac
@JnRouvignac
Oct 18 2016 15:56
It looks like you are more comfortable now
You implemented two rules without asking
Well done!
Luis Cruz
@luiscruz
Oct 18 2016 15:57
yea, I had more work in understanding the rules and corner cases rather than implementing it ;)
but
Jean-Noël Rouvignac
@JnRouvignac
Oct 18 2016 15:57
Did you also try to refactor real code?
Luis Cruz
@luiscruz
Oct 18 2016 15:57
I didn’t care about good practices
not yet
Jean-Noël Rouvignac
@JnRouvignac
Oct 18 2016 15:57
:) both expected
Luis Cruz
@luiscruz
Oct 18 2016 15:58
:sweat_smile:
Jean-Noël Rouvignac
@JnRouvignac
Oct 18 2016 16:03
You
Start
Can stay preparing the prs from now on
Luis Cruz
@luiscruz
Oct 18 2016 16:07
yea, I’ll be working on that
Jean-Noël Rouvignac
@JnRouvignac
Oct 18 2016 16:31
Did you test the rules against the codebase of some real apps?
That would be entertaining