These are chat archives for JnRouvignac/AutoRefactor

17th
Nov 2016
Fabrice TIERCELIN
@Fabrice-TIERCELIN
Nov 17 2016 13:18
OK. I'm in.
Jean-Noël Rouvignac
@JnRouvignac
Nov 17 2016 15:31
Hi Fabrice ;)
Thanks for all the PRs it will take me some time to go through all of them
However, reviewing your PRs prevent me from fixing the most pressing issues for releasing a 1.1 version
Would you be interested in helping me with pushing the 1.1. release out?
I know a few bugs that I want to fix in 1.1
Fabrice TIERCELIN
@Fabrice-TIERCELIN
Nov 17 2016 17:50
It's up to you but for me, PR #231 and #232 are very important. They fix bugs that have dramatically caused damage on my project. PR #230 is very useful but not required. The others can wait. What are the remaining bugs?
Jean-Noël Rouvignac
@JnRouvignac
Nov 17 2016 17:55
I pushed a commit recently which fixes PR #231 (I hope)
I agree #232 is bad
Shit I have bad network here
See if JnRouvignac/AutoRefactor@8a3cd08 fixes the problems of products #231
Lb
Fabrice TIERCELIN
@Fabrice-TIERCELIN
Nov 17 2016 18:10
Indeed the bug in #231 has disappeared but the PR still handles remove() and processes the code a better way so I keep the PR. However, it is less a priority for now.
Fabrice TIERCELIN
@Fabrice-TIERCELIN
Nov 17 2016 18:22
I have listed some bugs I have noticed on the plugin:
1) The following code is badly processed:
Float aFloat = new Float(4 + 5.0d);
2) #232
Jean-Noël Rouvignac
@JnRouvignac
Nov 17 2016 18:22
Ok for pr #231
Fabrice TIERCELIN
@Fabrice-TIERCELIN
Nov 17 2016 18:24
3) Missing imports for TestNG with assertXXX()
I have discovered this issue during #236 but as it wasn't a regression, I have planned to fix it later.
Jean-Noël Rouvignac
@JnRouvignac
Nov 17 2016 18:25
Ok please continue flagging which prs are priority
Fabrice TIERCELIN
@Fabrice-TIERCELIN
Nov 17 2016 18:25
I will rename them.
Actually, just #232 is a blocker.
Jean-Noël Rouvignac
@JnRouvignac
Nov 17 2016 18:27
#222 is priority for me
A bit tricky
And #172 is dangerous
It modifies semantics
And it is too hard to notice
Fabrice TIERCELIN
@Fabrice-TIERCELIN
Nov 17 2016 18:34
Assign me #172