These are chat archives for JnRouvignac/AutoRefactor

21st
Nov 2016
Luis Cruz
@luiscruz
Nov 21 2016 15:20
Hi Jean-Noël!
Can you please review #213 ?
Jean-Noël Rouvignac
@JnRouvignac
Nov 21 2016 15:20
Hi Luis
PR 213?
Luis Cruz
@luiscruz
Nov 21 2016 15:20
yap
Jean-Noël Rouvignac
@JnRouvignac
Nov 21 2016 15:22
OK, I can now see you've addressed the review comments
Yep I'll try to
Luis Cruz
@luiscruz
Nov 21 2016 15:22
In order to fix PR #212 I need the method getAncestorOrNull that I’ve created on that one.
Jean-Noël Rouvignac
@JnRouvignac
Nov 21 2016 15:22
it starts to be hard for me to keep up between yours PRs and Fabrice's :)
ok
Luis Cruz
@luiscruz
Nov 21 2016 15:23
yea, I understand ;)
Jean-Noël Rouvignac
@JnRouvignac
Nov 21 2016 15:41
OK there is a lot in this one
The rewrites are currently a bit blurred
it is hard to read when comes this level of rewriting
but I think I'll clean that up
I made several new comments
Please ping me once you'll have acted on them and pushed the new code for review
Luis Cruz
@luiscruz
Nov 21 2016 15:48
ok
Luis Cruz
@luiscruz
Nov 21 2016 16:41
ping :)
Luis Cruz
@luiscruz
Nov 21 2016 17:04
I’ve fixed your code reviews. Let me know what is the next step
Jean-Noël Rouvignac
@JnRouvignac
Nov 21 2016 17:08
Next step is tomorrow
:)
Luis Cruz
@luiscruz
Nov 21 2016 17:08
deal! :D
Fabrice TIERCELIN
@Fabrice-TIERCELIN
Nov 21 2016 19:38
Should I take #222?