These are chat archives for JnRouvignac/AutoRefactor

22nd
Nov 2016
Jean-Noël Rouvignac
@JnRouvignac
Nov 22 2016 09:10
@Fabrice-TIERCELIN please do if you feel confident
be careful there are many corner cases here
methods (you can ignore parameters), fields, variables can be shadowed
etc.
This is pretty tough
maybe start small and provide a simple fix
then we'll take it forward from there
Jean-Noël Rouvignac
@JnRouvignac
Nov 22 2016 13:30
@luiscruz I have looked at the PR and I have several problems with it
first of all mvn clean install fails
for the rest, maybe this is not the best medium here to explain them
last, reviewing PRs on github is not great IMO :(
but anyway we'll get through this
Jean-Noël Rouvignac
@JnRouvignac
Nov 22 2016 13:42
What I mean is that there is more work needed before I can merge it
Luis Cruz
@luiscruz
Nov 22 2016 14:46
Hi
I’ll see that now
Jean-Noël Rouvignac
@JnRouvignac
Nov 22 2016 14:46
hello
I'll speak to you on hangout to avoid polluting this channel with remarks towards the PR
if you log in
:)
Luis Cruz
@luiscruz
Nov 22 2016 14:48
are we talking about JnRouvignac/AutoRefactor#226?
Jean-Noël Rouvignac
@JnRouvignac
Nov 22 2016 14:48
yes
Luis Cruz
@luiscruz
Nov 22 2016 14:48
alright
we can speak on hangout
when are you available?
Jean-Noël Rouvignac
@JnRouvignac
Nov 22 2016 14:48
let's chat now :)
no need to call IMO
Luis Cruz
@luiscruz
Nov 22 2016 14:49
ok