Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Feb 01 05:33

    Fabrice-TIERCELIN on maven

    (compare)

  • Feb 01 05:33

    Fabrice-TIERCELIN on master

    Bump checkstyle from 10.6.0 to … (compare)

  • Feb 01 05:33
    Fabrice-TIERCELIN closed #509
  • Feb 01 05:32

    Fabrice-TIERCELIN on maven

    (compare)

  • Feb 01 05:32

    Fabrice-TIERCELIN on master

    Bump maven-enforcer-plugin from… (compare)

  • Feb 01 05:32
    Fabrice-TIERCELIN closed #508
  • Feb 01 05:15
    dependabot[bot] labeled #509
  • Feb 01 05:15
    dependabot[bot] opened #509
  • Feb 01 05:15

    dependabot[bot] on maven

    Bump checkstyle from 10.6.0 to … (compare)

  • Feb 01 05:15
    dependabot[bot] labeled #508
  • Feb 01 05:15

    dependabot[bot] on maven

    Bump maven-enforcer-plugin from… (compare)

  • Feb 01 05:15
    dependabot[bot] opened #508
  • Jan 27 11:52

    dependabot[bot] on maven

    (compare)

  • Jan 27 11:52

    Fabrice-TIERCELIN on master

    Bump spotless-maven-plugin from… (compare)

  • Jan 27 11:52
    Fabrice-TIERCELIN closed #507
  • Jan 27 05:10
    dependabot[bot] labeled #507
  • Jan 27 05:10
    dependabot[bot] opened #507
  • Jan 27 05:10

    dependabot[bot] on maven

    Bump spotless-maven-plugin from… (compare)

  • Jan 19 17:59

    dependabot[bot] on maven

    (compare)

  • Jan 19 17:59

    Fabrice-TIERCELIN on master

    Bump assertj-core from 3.24.1 t… (compare)

Jean-Noël Rouvignac
@JnRouvignac
great :)
Vaibhav Tulsyan
@xennygrimmato
Stuck after that :P
Jean-Noël Rouvignac
@JnRouvignac
which step?
Vaibhav Tulsyan
@xennygrimmato
Be back in some time. Will post my issue here
Jean-Noël Rouvignac
@JnRouvignac
ok
Luis Cruz
@luiscruz
Hi Jean-Noël!!
:)
So, I’m not able to properly import Android Studio projects to the Eclipse
The importer does not work, so I have to create a new Android project and manually import manifest, source code, resources, etc.
The problem with the importer is that it does not recognize the main source code of the project
and since it does not recognize it as java source code, AutoRefactor menus are not shown.
In alternative, I can run alt+shift+Yand it will apply AutoRefactor. The only drawback is that I have to manually apply to every file.
I have applied it to this project: https://github.com/trikita/talalarmo
And Wakelock anti pattern is refactored :clap: :D
Luis Cruz
@luiscruz
However, indentation is weird.. Don’t know if there is an easy workaround
Here is a part of the input:
    @Override
    public void onBackPressed() {
        stopAlarm();
        super.onBackPressed();
    }

    @Override
    protected void onDestroy() {
        super.onDestroy();
        mWakeLock.release();
    }

    private void stopAlarm() {
Here is the output:
    @Override
    public void onBackPressed() {
        stopAlarm();
        super.onBackPressed();
    }

    @Override
    protected void onDestroy() {
        super.onDestroy();
    }

    @Override
    protected void onPause() {
                super.onPause();
                if (!mWakeLock.isHeld()) {
                    mWakeLock.release();
                }
            }

    private void stopAlarm() {
Jean-Noël Rouvignac
@JnRouvignac
Hi Luis!
Congratulations!
Luis Cruz
@luiscruz
I’m now fixing some of your reviews that are still missing
Let me see if I can finish this today ;)
Jean-Noël Rouvignac
@JnRouvignac
Alas I am getting late for the reviews :(
Luis Cruz
@luiscruz
no worries ;) I’ll get rid of the ones we have now and when you’re available we continue ;)
Jean-Noël Rouvignac
@JnRouvignac
I have 2 PRs in addition to yours and I have not found time to review them yet
Luis Cruz
@luiscruz
yea no worries, if you don’t have time I’ll start reviewing myself the remaining rules
;)
Jean-Noël Rouvignac
@JnRouvignac
Yes please apply some of the comments I made earlier
You know a bit better wha
What I am looking for now
Luis Cruz
@luiscruz
yea ;)
Would mind explaining how to use insertLast(ASTNode listHolder, StructuralPropertyDescriptor locationInParent, ASTNode nodeToInsert)
?

for a body declaration:

insertLast(typeDeclaration, typeDeclaration.getBodyDeclarationsProperty(),declaration)

Would work?
forget, I’ll try it first
Jean-Noël Rouvignac
@JnRouvignac
Yep I think so
Luis Cruz
@luiscruz
perfect :D
Jean-Noël Rouvignac
@JnRouvignac
;)
Concerning indentation, it may be down to JDT configuration for formatting
But I have found it to be disconcerting at times
Jean-Noël Rouvignac
@JnRouvignac
Re: importing from android studio
What do you call the importer ?
The Java importer ?
Something else?
Luis Cruz
@luiscruz
no, after installing Android plugin there is a new kind of projects — Android
that already imports the sdk and necessary tools
Screen Shot 2016-10-31 at 18.44.03.png
Jean-Noël Rouvignac
@JnRouvignac
Ah crap :(
Bug report?
Luis Cruz
@luiscruz
it is important because according to the project different versions of sdks should apply..