Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Nov 04 17:20
    nbauma109 closed #495
  • Nov 04 13:34
    Fabrice-TIERCELIN commented #495
  • Nov 04 12:47
    nbauma109 commented #495
  • Nov 04 12:37
    Fabrice-TIERCELIN commented #495
  • Nov 04 12:16
    nbauma109 opened #495
  • Oct 09 21:46

    JnRouvignac on master

    Remove reference to autorefacto… (compare)

  • Mar 20 16:05

    Fabrice-TIERCELIN on master

    Handle findFirst() and findAny() (compare)

  • Mar 20 15:59

    Fabrice-TIERCELIN on master

    Fix error message in ASTNodes.j… (compare)

  • Jan 16 15:36
    Fabrice-TIERCELIN labeled #494
  • Jan 16 15:36
    Fabrice-TIERCELIN assigned #494
  • Jan 11 21:49
    nbauma109 opened #494
  • Nov 03 2021 06:06

    Fabrice-TIERCELIN on master

    Improve MAVEN build Performance (compare)

  • Nov 03 2021 06:06
    Fabrice-TIERCELIN closed #493
  • Nov 03 2021 01:37
    ChenZhangg commented #493
  • Nov 01 2021 18:52
    Fabrice-TIERCELIN commented #493
  • Oct 28 2021 01:39
    ChenZhangg opened #493
  • Jun 29 2021 04:35

    Fabrice-TIERCELIN on master

    Separate analyze and refactoring (compare)

  • Jun 27 2021 18:43
    cal101 commented #492
  • Jun 27 2021 18:34
    Fabrice-TIERCELIN closed #492
  • Jun 27 2021 18:34

    Fabrice-TIERCELIN on master

    Closes #492; Only use methods i… (compare)

Luis Cruz
@luiscruz
In alternative, I can run alt+shift+Yand it will apply AutoRefactor. The only drawback is that I have to manually apply to every file.
I have applied it to this project: https://github.com/trikita/talalarmo
And Wakelock anti pattern is refactored :clap: :D
However, indentation is weird.. Don’t know if there is an easy workaround
Here is a part of the input:
    @Override
    public void onBackPressed() {
        stopAlarm();
        super.onBackPressed();
    }

    @Override
    protected void onDestroy() {
        super.onDestroy();
        mWakeLock.release();
    }

    private void stopAlarm() {
Here is the output:
    @Override
    public void onBackPressed() {
        stopAlarm();
        super.onBackPressed();
    }

    @Override
    protected void onDestroy() {
        super.onDestroy();
    }

    @Override
    protected void onPause() {
                super.onPause();
                if (!mWakeLock.isHeld()) {
                    mWakeLock.release();
                }
            }

    private void stopAlarm() {
Jean-Noël Rouvignac
@JnRouvignac
Hi Luis!
Congratulations!
Luis Cruz
@luiscruz
I’m now fixing some of your reviews that are still missing
Let me see if I can finish this today ;)
Jean-Noël Rouvignac
@JnRouvignac
Alas I am getting late for the reviews :(
Luis Cruz
@luiscruz
no worries ;) I’ll get rid of the ones we have now and when you’re available we continue ;)
Jean-Noël Rouvignac
@JnRouvignac
I have 2 PRs in addition to yours and I have not found time to review them yet
Luis Cruz
@luiscruz
yea no worries, if you don’t have time I’ll start reviewing myself the remaining rules
;)
Jean-Noël Rouvignac
@JnRouvignac
Yes please apply some of the comments I made earlier
You know a bit better wha
What I am looking for now
Luis Cruz
@luiscruz
yea ;)
Would mind explaining how to use insertLast(ASTNode listHolder, StructuralPropertyDescriptor locationInParent, ASTNode nodeToInsert)
?

for a body declaration:

insertLast(typeDeclaration, typeDeclaration.getBodyDeclarationsProperty(),declaration)

Would work?
forget, I’ll try it first
Jean-Noël Rouvignac
@JnRouvignac
Yep I think so
Luis Cruz
@luiscruz
perfect :D
Jean-Noël Rouvignac
@JnRouvignac
;)
Concerning indentation, it may be down to JDT configuration for formatting
But I have found it to be disconcerting at times
Jean-Noël Rouvignac
@JnRouvignac
Re: importing from android studio
What do you call the importer ?
The Java importer ?
Something else?
Luis Cruz
@luiscruz
no, after installing Android plugin there is a new kind of projects — Android
that already imports the sdk and necessary tools
Screen Shot 2016-10-31 at 18.44.03.png
Jean-Noël Rouvignac
@JnRouvignac
Ah crap :(
Bug report?
Luis Cruz
@luiscruz
it is important because according to the project different versions of sdks should apply..
I can do that, but they are not supporting Eclipse for Android development anymore :(
Jean-Noël Rouvignac
@JnRouvignac
I think this is now an eclipse project named and more
AndMore
Luis Cruz
@luiscruz
side note:
I get this error with mvn clean install
[ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:0.23.1:compile (default-compile) on project org.autorefactor.plugin: Compilation failure: Compilation failure:
[ERROR] /home/travis/build/JnRouvignac/AutoRefactor/plugin/src/main/java/org/autorefactor/refactoring/ASTBuilder.java:[421]
[ERROR] modifiers(vde).add(final0());
[ERROR] ^^^^^^^^^
[ERROR] The method modifiers(IExtendedModifier...) in the type ASTBuilder is not applicable for the arguments (VariableDeclarationExpression)
[ERROR] 1 problem (1 error)
[ERROR] -> [Help 1]
Jean-Noël Rouvignac
@JnRouvignac
Err with code from master?
Luis Cruz
@luiscruz
I think I got this after merging
but I can run and test the project anyway :\