Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Mar 20 16:05

    Fabrice-TIERCELIN on master

    Handle findFirst() and findAny() (compare)

  • Mar 20 15:59

    Fabrice-TIERCELIN on master

    Fix error message in ASTNodes.j… (compare)

  • Jan 16 15:36
    Fabrice-TIERCELIN labeled #494
  • Jan 16 15:36
    Fabrice-TIERCELIN assigned #494
  • Jan 11 21:49
    nbauma109 opened #494
  • Nov 03 2021 06:06

    Fabrice-TIERCELIN on master

    Improve MAVEN build Performance (compare)

  • Nov 03 2021 06:06
    Fabrice-TIERCELIN closed #493
  • Nov 03 2021 01:37
    ChenZhangg commented #493
  • Nov 01 2021 18:52
    Fabrice-TIERCELIN commented #493
  • Oct 28 2021 01:39
    ChenZhangg opened #493
  • Jun 29 2021 04:35

    Fabrice-TIERCELIN on master

    Separate analyze and refactoring (compare)

  • Jun 27 2021 18:43
    cal101 commented #492
  • Jun 27 2021 18:34
    Fabrice-TIERCELIN closed #492
  • Jun 27 2021 18:34

    Fabrice-TIERCELIN on master

    Closes #492; Only use methods i… (compare)

  • Jun 27 2021 18:27
    Fabrice-TIERCELIN labeled #492
  • Jun 27 2021 18:26
    Fabrice-TIERCELIN assigned #492
  • Jun 27 2021 17:42
    cal101 opened #492
  • Jun 26 2021 11:19
    JnRouvignac closed #93
  • Jun 26 2021 11:19
    JnRouvignac commented #93
  • Jun 26 2021 11:19
    JnRouvignac commented #93
Jean-Noël Rouvignac
@JnRouvignac
See if it helps
Luis Cruz
@luiscruz
vde.modifiers()?
or changing the method name?
Jean-Noël Rouvignac
@JnRouvignac
The latter
I think I know
Name shadowing indeed
Ok just put a random name
I'll fix it post merge
Luis Cruz
@luiscruz
alright renamed to modifiersList
Luis Cruz
@luiscruz
Hi Jean-Noël! I’m working on an anti-pattern for the views of Android projects. They are written in XML so I’m creating a separate script for that. Before proceeding with it I wanted to confirm with you that AutoRefactor does not have anything on this. Is that right?
Jean-Noël Rouvignac
@JnRouvignac
Hi Luis
nada zero indeed :)
not sure how to go about that
just working with the XML DOM maybe?
Luis Cruz
@luiscruz
:laughing:
Jean-Noël Rouvignac
@JnRouvignac
it already contains the comments, so it is easy to figure it out
Luis Cruz
@luiscruz
yes, I’m thinking on doing that
Jean-Noël Rouvignac
@JnRouvignac
I think it falls under the http://www.eclipse.org/webtools/
Luis Cruz
@luiscruz
I think any XML parser will do the job..
Jean-Noël Rouvignac
@JnRouvignac
I think I agree :)
Luis Cruz
@luiscruz
I’m just worried that some rules depend on multiple files
but I’ll start with a simple XML parser for the simplest rules and then figure it out
Jean-Noël Rouvignac
@JnRouvignac
+1
Luis Cruz
@luiscruz
Hi Jean-nöel! Thanks for the code review! I have a question regarding copyright:
Some of the tests were copied/adapted from the lint project's source code. Should I mention that? How should I do that?
Jean-Noël Rouvignac
@JnRouvignac
Argument
Hi Luis
I meant Argh
What license is it?
We cannot copy code like this
Luis Cruz
@luiscruz
Apache 2.0
Jean-Noël Rouvignac
@JnRouvignac
I think it is OK. Let me check
Luis Cruz
@luiscruz
It's not an exact copy but i wrote samples while looking at theire tests
Their
I would have to recheck to make sure I can make such statement 😅
Jean-Noël Rouvignac
@JnRouvignac
Search for apache
How much is copied ?
Jean-Noël Rouvignac
@JnRouvignac
It still requires application of the same license to all unmodified parts and, in every licensed file,
So the files must be under apache v2
Luis Cruz
@luiscruz
sorry, I passed out yesterday :sweat_smile:
Jean-Noël Rouvignac
@JnRouvignac
Ha ha ha! It's ok
Luis Cruz
@luiscruz
fyi I copied the tests from this file
We can either change the license in these sample files or I can come up with new samples
I’m fine with both options, but I believe the simplest one is changing the license
Jean-Noël Rouvignac
@JnRouvignac
Sorry late lunch
I will answer asap
Jean-Noël Rouvignac
@JnRouvignac
Hi @luiscruz
I have not taken time yet to review the copyright issues