Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 16 15:36
    Fabrice-TIERCELIN labeled #494
  • Jan 16 15:36
    Fabrice-TIERCELIN assigned #494
  • Jan 11 21:49
    nbauma109 opened #494
  • Nov 03 2021 06:06

    Fabrice-TIERCELIN on master

    Improve MAVEN build Performance (compare)

  • Nov 03 2021 06:06
    Fabrice-TIERCELIN closed #493
  • Nov 03 2021 01:37
    ChenZhangg commented #493
  • Nov 01 2021 18:52
    Fabrice-TIERCELIN commented #493
  • Oct 28 2021 01:39
    ChenZhangg opened #493
  • Jun 29 2021 04:35

    Fabrice-TIERCELIN on master

    Separate analyze and refactoring (compare)

  • Jun 27 2021 18:43
    cal101 commented #492
  • Jun 27 2021 18:34
    Fabrice-TIERCELIN closed #492
  • Jun 27 2021 18:34

    Fabrice-TIERCELIN on master

    Closes #492; Only use methods i… (compare)

  • Jun 27 2021 18:27
    Fabrice-TIERCELIN labeled #492
  • Jun 27 2021 18:26
    Fabrice-TIERCELIN assigned #492
  • Jun 27 2021 17:42
    cal101 opened #492
  • Jun 26 2021 11:19
    JnRouvignac closed #93
  • Jun 26 2021 11:19
    JnRouvignac commented #93
  • Jun 26 2021 11:19
    JnRouvignac commented #93
  • Jun 26 2021 04:20

    Fabrice-TIERCELIN on master

    Standard tests New CleanUp: Replaces some chec… (compare)

  • Jun 25 2021 15:49
    cal101 commented #391
Jean-Noël Rouvignac
@JnRouvignac
Search for apache
How much is copied ?
Jean-Noël Rouvignac
@JnRouvignac
It still requires application of the same license to all unmodified parts and, in every licensed file,
So the files must be under apache v2
Luis Cruz
@luiscruz
sorry, I passed out yesterday :sweat_smile:
Jean-Noël Rouvignac
@JnRouvignac
Ha ha ha! It's ok
Luis Cruz
@luiscruz
fyi I copied the tests from this file
We can either change the license in these sample files or I can come up with new samples
I’m fine with both options, but I believe the simplest one is changing the license
Jean-Noël Rouvignac
@JnRouvignac
Sorry late lunch
I will answer asap
Jean-Noël Rouvignac
@JnRouvignac
Hi @luiscruz
I have not taken time yet to review the copyright issues
Please commit the files with the same header as the other files
We'll fix the headers post PR merges if need be
please also update the PRs according to the code review
Luis Cruz
@luiscruz
Hi Jean-Noël! This week im helping organizing web summit in lisbon and I couldn't really do much work. I'll try to go over it during the weekend ;)
Jean-Noël Rouvignac
@JnRouvignac
Oh ok, no problem at all
I'll focus on other PRs in the meantime
No rush
Have an enjoyable experience, and a successful event
Luis Cruz
@luiscruz
Cool :) thanks
Jean-Noël Rouvignac
@JnRouvignac
And get some rest over the weekend ;)
Luis Cruz
@luiscruz
Ahah I'll think about that :smile:
Luis Cruz
@luiscruz
Hi
I’m having problems with a comment that gets removed after refactoring
Jean-Noël Rouvignac
@JnRouvignac
hello
yes tell me
or show me the culprit code :)
Luis Cruz
@luiscruz
Are comments part of other statements?
Jean-Noël Rouvignac
@JnRouvignac
I bet it is calling ASTBuilder.copy()
nope they live in a strange world
a bit there, a bit not there
Luis Cruz
@luiscruz
ok, let me check it
Jean-Noël Rouvignac
@JnRouvignac
they are a bit like ghosts
:)
Luis Cruz
@luiscruz
:sweat_smile:
yea I’m using copy()
Jean-Noël Rouvignac
@JnRouvignac
you would need to use move() or other techniques in order to keep the source as close to the original as possible
Luis Cruz
@luiscruz
humm actually
do you think this also removes it r.remove(visitor.viewAssignmentStatement); ?
Jean-Noël Rouvignac
@JnRouvignac
maybe
code! I need code!
I cannot tell just like this
Luis Cruz
@luiscruz
because the thing is I am creating a different statement based on this one, and then I get rid of it
Jean-Noël Rouvignac
@JnRouvignac
but definitely, you should not both move and delete the same node
it was ok when you copied