Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Nov 03 06:06

    Fabrice-TIERCELIN on master

    Improve MAVEN build Performance (compare)

  • Nov 03 06:06
    Fabrice-TIERCELIN closed #493
  • Nov 03 01:37
    ChenZhangg commented #493
  • Nov 01 18:52
    Fabrice-TIERCELIN commented #493
  • Oct 28 01:39
    ChenZhangg opened #493
  • Jun 29 04:35

    Fabrice-TIERCELIN on master

    Separate analyze and refactoring (compare)

  • Jun 27 18:43
    cal101 commented #492
  • Jun 27 18:34
    Fabrice-TIERCELIN closed #492
  • Jun 27 18:34

    Fabrice-TIERCELIN on master

    Closes #492; Only use methods i… (compare)

  • Jun 27 18:27
    Fabrice-TIERCELIN labeled #492
  • Jun 27 18:26
    Fabrice-TIERCELIN assigned #492
  • Jun 27 17:42
    cal101 opened #492
  • Jun 26 11:19
    JnRouvignac closed #93
  • Jun 26 11:19
    JnRouvignac commented #93
  • Jun 26 11:19
    JnRouvignac commented #93
  • Jun 26 04:20

    Fabrice-TIERCELIN on master

    Standard tests New CleanUp: Replaces some chec… (compare)

  • Jun 25 15:49
    cal101 commented #391
  • Jun 25 15:47
    cal101 commented #93
  • Jun 25 15:43
    cal101 added as member
  • Jun 25 07:02
    JnRouvignac commented #391
Jean-Noël Rouvignac
@JnRouvignac
Oh ok, no problem at all
I'll focus on other PRs in the meantime
No rush
Have an enjoyable experience, and a successful event
Luis Cruz
@luiscruz
Cool :) thanks
Jean-Noël Rouvignac
@JnRouvignac
And get some rest over the weekend ;)
Luis Cruz
@luiscruz
Ahah I'll think about that :smile:
Luis Cruz
@luiscruz
Hi
I’m having problems with a comment that gets removed after refactoring
Jean-Noël Rouvignac
@JnRouvignac
hello
yes tell me
or show me the culprit code :)
Luis Cruz
@luiscruz
Are comments part of other statements?
Jean-Noël Rouvignac
@JnRouvignac
I bet it is calling ASTBuilder.copy()
nope they live in a strange world
a bit there, a bit not there
Luis Cruz
@luiscruz
ok, let me check it
Jean-Noël Rouvignac
@JnRouvignac
they are a bit like ghosts
:)
Luis Cruz
@luiscruz
:sweat_smile:
yea I’m using copy()
Jean-Noël Rouvignac
@JnRouvignac
you would need to use move() or other techniques in order to keep the source as close to the original as possible
Luis Cruz
@luiscruz
humm actually
do you think this also removes it r.remove(visitor.viewAssignmentStatement); ?
Jean-Noël Rouvignac
@JnRouvignac
maybe
code! I need code!
I cannot tell just like this
Luis Cruz
@luiscruz
because the thing is I am creating a different statement based on this one, and then I get rid of it
Jean-Noël Rouvignac
@JnRouvignac
but definitely, you should not both move and delete the same node
it was ok when you copied
but copy always means you lose the comments
you should use move() by default
Luis Cruz
@luiscruz
I am copying the inflater.inflate expression
and in the end I remove the original statement
so even if I “move” I wouldn’t get the comments, since it is only a subtree
Jean-Noël Rouvignac
@JnRouvignac
I see no comments here?
so no comments to lose?
Luis Cruz
@luiscruz
I’ll do it again
            //this should not be refactored
            rootView = inflater.inflate(android.R.layout.simple_list_item_1, parent, false);
            //this should not be refactored
            if (convertView == null) {
                convertView = inflater.inflate(android.R.layout.simple_list_item_1, parent, false);
            }
Jean-Noël Rouvignac
@JnRouvignac
so you are losing this comment?
Luis Cruz
@luiscruz
yes!
Jean-Noël Rouvignac
@JnRouvignac
by default comments are attached to the nodes following them
this is a property of the ASTParser
Luis Cruz
@luiscruz
ok, so if I want to keep them I have to make sure I copy it before removing the node
is that right?
Jean-Noël Rouvignac
@JnRouvignac
I do not think that will work
I recall something and I think it was more complicated than this
Luis Cruz
@luiscruz
:\
Jean-Noël Rouvignac
@JnRouvignac
comments are somewhat attached to an ASTNode, but they are not directly part of the AST