Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jun 16 19:08
    nbauma109 commented #491
  • Jun 16 18:46
    Fabrice-TIERCELIN assigned #491
  • Jun 16 18:46
    Fabrice-TIERCELIN labeled #491
  • Jun 16 18:46
    Fabrice-TIERCELIN commented #491
  • Jun 16 18:38
    nbauma109 opened #491
  • Jun 16 16:47
    Fabrice-TIERCELIN closed #490
  • Jun 16 16:47

    Fabrice-TIERCELIN on master

    Closes #490; Handle name confli… (compare)

  • Jun 16 16:40
    Fabrice-TIERCELIN labeled #490
  • Jun 16 16:40
    Fabrice-TIERCELIN assigned #490
  • Jun 16 06:51
    nbauma109 opened #490
  • Jun 15 21:09
    nbauma109 commented #489
  • Jun 15 19:16
    Fabrice-TIERCELIN closed #489
  • Jun 15 19:16
    Fabrice-TIERCELIN commented #489
  • Jun 12 10:19
    Fabrice-TIERCELIN assigned #489
  • Jun 12 09:41
    nbauma109 opened #489
  • Jun 02 05:36
    Fabrice-TIERCELIN commented #487
  • Jun 01 06:30
    Fabrice-TIERCELIN closed #487
  • Jun 01 06:30

    Fabrice-TIERCELIN on master

    Closes #487; Flag the changed a… (compare)

  • Jun 01 06:22

    Fabrice-TIERCELIN on master

    Flag the changed area as changed (compare)

  • May 29 11:23
    cal101 commented #487
Jean-Noël Rouvignac
@JnRouvignac
or else duck and ignore this problem (as I cowardly did)
Luis Cruz
@luiscruz
I will create a comment and assign it using setAlternateRoot
Jean-Noël Rouvignac
@JnRouvignac
actually not totally I went as far as understanding using the move() method is important :)
ok, try and see if that helps
Luis Cruz
@luiscruz
I dont believe it willl work as well, but it shouldn’t take too much time
:)
does’t work
Jean-Noël Rouvignac
@JnRouvignac
:-|
Luis Cruz
@luiscruz
anyway, I’ll go over this after lunch
thanks ;)
Jean-Noël Rouvignac
@JnRouvignac
np sorry I could not give you the ultimate answer
Luis Cruz
@luiscruz
no worries ;)
Luis Cruz
@luiscruz
do you know how can I get text from a comment?
Luis Cruz
@luiscruz
well, never mind. I give up for now. It’s not a priority for now.
Jean-Noël Rouvignac
@JnRouvignac
See CommentsRefactoring
Luis Cruz
@luiscruz
changing the topic, why does getAncestor throws an exception instead of returning null?
Jean-Noël Rouvignac
@JnRouvignac
Because when using this API, it is expected to find the required type
I never had a problem with it
Is it causing you grief ?
Luis Cruz
@luiscruz
:sweat_smile: it’s just that in my code sometimes there are cases in which I’m not expecting it to find the ancestor
so a simple `ìf/else``turns into nested try/catch statements
Jean-Noël Rouvignac
@JnRouvignac
Ah this is ugly
Maybe can we add getAncestorOrNull?
Luis Cruz
@luiscruz
yea
shall I do it?
Jean-Noël Rouvignac
@JnRouvignac
Yes
Please
Fabrice TIERCELIN
@Fabrice-TIERCELIN
OK. I'm in.
Jean-Noël Rouvignac
@JnRouvignac
Hi Fabrice ;)
Thanks for all the PRs it will take me some time to go through all of them
However, reviewing your PRs prevent me from fixing the most pressing issues for releasing a 1.1 version
Would you be interested in helping me with pushing the 1.1. release out?
I know a few bugs that I want to fix in 1.1
Fabrice TIERCELIN
@Fabrice-TIERCELIN
It's up to you but for me, PR #231 and #232 are very important. They fix bugs that have dramatically caused damage on my project. PR #230 is very useful but not required. The others can wait. What are the remaining bugs?
Jean-Noël Rouvignac
@JnRouvignac
I pushed a commit recently which fixes PR #231 (I hope)
I agree #232 is bad
Shit I have bad network here
See if JnRouvignac/AutoRefactor@8a3cd08 fixes the problems of products #231
Lb
Fabrice TIERCELIN
@Fabrice-TIERCELIN
Indeed the bug in #231 has disappeared but the PR still handles remove() and processes the code a better way so I keep the PR. However, it is less a priority for now.
Fabrice TIERCELIN
@Fabrice-TIERCELIN
I have listed some bugs I have noticed on the plugin:
1) The following code is badly processed:
Float aFloat = new Float(4 + 5.0d);
2) #232
Jean-Noël Rouvignac
@JnRouvignac
Ok for pr #231
Fabrice TIERCELIN
@Fabrice-TIERCELIN
3) Missing imports for TestNG with assertXXX()
I have discovered this issue during #236 but as it wasn't a regression, I have planned to fix it later.
Jean-Noël Rouvignac
@JnRouvignac
Ok please continue flagging which prs are priority
Fabrice TIERCELIN
@Fabrice-TIERCELIN
I will rename them.
Actually, just #232 is a blocker.