Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • May 15 15:24
    Fabrice-TIERCELIN labeled #485
  • May 15 15:24
    Fabrice-TIERCELIN assigned #485
  • May 15 15:16
    Fabrice-TIERCELIN closed #485
  • May 15 15:16

    Fabrice-TIERCELIN on master

    Close #485; Do not add redundan… (compare)

  • May 14 13:05
    nbauma109 edited #485
  • May 13 12:53
    Fabrice-TIERCELIN closed #484
  • May 13 12:53

    Fabrice-TIERCELIN on master

    Closes #484; Refactor active di… (compare)

  • May 13 08:27
    nbauma109 opened #485
  • May 13 08:25
    Fabrice-TIERCELIN labeled #484
  • May 13 08:25
    Fabrice-TIERCELIN assigned #484
  • May 13 07:42
    nbauma109 opened #484
  • May 11 05:42
    Fabrice-TIERCELIN closed #483
  • May 11 05:42

    Fabrice-TIERCELIN on master

    Closes #483; Handle dimension o… (compare)

  • May 10 19:31

    Fabrice-TIERCELIN on master

    Preserve more comments (compare)

  • May 10 06:23
    Fabrice-TIERCELIN labeled #483
  • May 10 06:23
    Fabrice-TIERCELIN assigned #483
  • May 10 06:19
    nbauma109 opened #483
  • May 03 15:50

    Fabrice-TIERCELIN on master

    Sort and complete the tests (compare)

  • May 03 15:28

    Fabrice-TIERCELIN on master

    Flag the cleanups (compare)

  • May 02 16:03

    Fabrice-TIERCELIN on master

    Handle constructors with string (compare)

Luis Cruz
@luiscruz
do you know how can I get text from a comment?
Luis Cruz
@luiscruz
well, never mind. I give up for now. It’s not a priority for now.
Jean-Noël Rouvignac
@JnRouvignac
See CommentsRefactoring
Luis Cruz
@luiscruz
changing the topic, why does getAncestor throws an exception instead of returning null?
Jean-Noël Rouvignac
@JnRouvignac
Because when using this API, it is expected to find the required type
I never had a problem with it
Is it causing you grief ?
Luis Cruz
@luiscruz
:sweat_smile: it’s just that in my code sometimes there are cases in which I’m not expecting it to find the ancestor
so a simple `ìf/else``turns into nested try/catch statements
Jean-Noël Rouvignac
@JnRouvignac
Ah this is ugly
Maybe can we add getAncestorOrNull?
Luis Cruz
@luiscruz
yea
shall I do it?
Jean-Noël Rouvignac
@JnRouvignac
Yes
Please
Fabrice TIERCELIN
@Fabrice-TIERCELIN
OK. I'm in.
Jean-Noël Rouvignac
@JnRouvignac
Hi Fabrice ;)
Thanks for all the PRs it will take me some time to go through all of them
However, reviewing your PRs prevent me from fixing the most pressing issues for releasing a 1.1 version
Would you be interested in helping me with pushing the 1.1. release out?
I know a few bugs that I want to fix in 1.1
Fabrice TIERCELIN
@Fabrice-TIERCELIN
It's up to you but for me, PR #231 and #232 are very important. They fix bugs that have dramatically caused damage on my project. PR #230 is very useful but not required. The others can wait. What are the remaining bugs?
Jean-Noël Rouvignac
@JnRouvignac
I pushed a commit recently which fixes PR #231 (I hope)
I agree #232 is bad
Shit I have bad network here
See if JnRouvignac/AutoRefactor@8a3cd08 fixes the problems of products #231
Lb
Fabrice TIERCELIN
@Fabrice-TIERCELIN
Indeed the bug in #231 has disappeared but the PR still handles remove() and processes the code a better way so I keep the PR. However, it is less a priority for now.
Fabrice TIERCELIN
@Fabrice-TIERCELIN
I have listed some bugs I have noticed on the plugin:
1) The following code is badly processed:
Float aFloat = new Float(4 + 5.0d);
2) #232
Jean-Noël Rouvignac
@JnRouvignac
Ok for pr #231
Fabrice TIERCELIN
@Fabrice-TIERCELIN
3) Missing imports for TestNG with assertXXX()
I have discovered this issue during #236 but as it wasn't a regression, I have planned to fix it later.
Jean-Noël Rouvignac
@JnRouvignac
Ok please continue flagging which prs are priority
Fabrice TIERCELIN
@Fabrice-TIERCELIN
I will rename them.
Actually, just #232 is a blocker.
Jean-Noël Rouvignac
@JnRouvignac
#222 is priority for me
A bit tricky
And #172 is dangerous
It modifies semantics
And it is too hard to notice
Fabrice TIERCELIN
@Fabrice-TIERCELIN
Assign me #172
Luis Cruz
@luiscruz
Hi Jean-Noël!
Can you please review #213 ?
Jean-Noël Rouvignac
@JnRouvignac
Hi Luis
PR 213?
Luis Cruz
@luiscruz
yap
Jean-Noël Rouvignac
@JnRouvignac
OK, I can now see you've addressed the review comments