Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Apr 18 09:15
    nbauma109 opened #482
  • Apr 14 05:27

    Fabrice-TIERCELIN on master

    Remove useless parenthesis (compare)

  • Apr 14 05:00

    Fabrice-TIERCELIN on master

    Flag obsolete rules (compare)

  • Apr 07 04:53
    Fabrice-TIERCELIN commented #465
  • Apr 06 14:58
    Fabrice-TIERCELIN closed #481
  • Apr 06 14:58
    Fabrice-TIERCELIN commented #481
  • Apr 06 14:46
    nbauma109 commented #481
  • Apr 06 13:06
    Fabrice-TIERCELIN commented #481
  • Apr 06 12:21
    nbauma109 commented #481
  • Apr 06 12:20
    nbauma109 commented #481
  • Apr 06 11:58
    Fabrice-TIERCELIN commented #481
  • Apr 06 11:45
    Fabrice-TIERCELIN labeled #481
  • Apr 06 11:45
    Fabrice-TIERCELIN assigned #481
  • Apr 06 11:29
    nbauma109 commented #481
  • Apr 06 10:19
    nbauma109 commented #481
  • Apr 06 09:58
    nbauma109 edited #481
  • Apr 06 09:53
    nbauma109 edited #481
  • Apr 06 09:52
    nbauma109 opened #481
  • Apr 04 18:14

    Fabrice-TIERCELIN on master

    Flag the right node (compare)

  • Apr 04 17:19

    Fabrice-TIERCELIN on master

    Separate analyze and rewriting (compare)

Jean-Noël Rouvignac
@JnRouvignac
Shit I have bad network here
See if JnRouvignac/AutoRefactor@8a3cd08 fixes the problems of products #231
Lb
Fabrice TIERCELIN
@Fabrice-TIERCELIN
Indeed the bug in #231 has disappeared but the PR still handles remove() and processes the code a better way so I keep the PR. However, it is less a priority for now.
Fabrice TIERCELIN
@Fabrice-TIERCELIN
I have listed some bugs I have noticed on the plugin:
1) The following code is badly processed:
Float aFloat = new Float(4 + 5.0d);
2) #232
Jean-Noël Rouvignac
@JnRouvignac
Ok for pr #231
Fabrice TIERCELIN
@Fabrice-TIERCELIN
3) Missing imports for TestNG with assertXXX()
I have discovered this issue during #236 but as it wasn't a regression, I have planned to fix it later.
Jean-Noël Rouvignac
@JnRouvignac
Ok please continue flagging which prs are priority
Fabrice TIERCELIN
@Fabrice-TIERCELIN
I will rename them.
Actually, just #232 is a blocker.
Jean-Noël Rouvignac
@JnRouvignac
#222 is priority for me
A bit tricky
And #172 is dangerous
It modifies semantics
And it is too hard to notice
Fabrice TIERCELIN
@Fabrice-TIERCELIN
Assign me #172
Luis Cruz
@luiscruz
Hi Jean-Noël!
Can you please review #213 ?
Jean-Noël Rouvignac
@JnRouvignac
Hi Luis
PR 213?
Luis Cruz
@luiscruz
yap
Jean-Noël Rouvignac
@JnRouvignac
OK, I can now see you've addressed the review comments
Yep I'll try to
Luis Cruz
@luiscruz
In order to fix PR #212 I need the method getAncestorOrNull that I’ve created on that one.
Jean-Noël Rouvignac
@JnRouvignac
it starts to be hard for me to keep up between yours PRs and Fabrice's :)
ok
Luis Cruz
@luiscruz
yea, I understand ;)
Jean-Noël Rouvignac
@JnRouvignac
OK there is a lot in this one
The rewrites are currently a bit blurred
it is hard to read when comes this level of rewriting
but I think I'll clean that up
I made several new comments
Please ping me once you'll have acted on them and pushed the new code for review
Luis Cruz
@luiscruz
ok
Luis Cruz
@luiscruz
ping :)
Luis Cruz
@luiscruz
I’ve fixed your code reviews. Let me know what is the next step
Jean-Noël Rouvignac
@JnRouvignac
Next step is tomorrow
:)
Luis Cruz
@luiscruz
deal! :D
Fabrice TIERCELIN
@Fabrice-TIERCELIN
Should I take #222?
Jean-Noël Rouvignac
@JnRouvignac
@Fabrice-TIERCELIN please do if you feel confident
be careful there are many corner cases here
methods (you can ignore parameters), fields, variables can be shadowed
etc.
This is pretty tough
maybe start small and provide a simple fix