Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 09:16
    cal101 opened #475
  • 09:15
    cal101 opened #474
  • 09:11
    cal101 opened #473
  • 09:09
    cal101 synchronize #462
  • Mar 01 19:41
    cal101 commented #462
  • Mar 01 19:19

    Fabrice-TIERCELIN on master

    update formatter configuration … (compare)

  • Mar 01 19:19
    Fabrice-TIERCELIN closed #471
  • Mar 01 18:29
    cal101 edited #472
  • Mar 01 18:26
    cal101 opened #472
  • Mar 01 17:58
    cal101 commented #470
  • Mar 01 17:57

    Fabrice-TIERCELIN on master

    New CleanUp: Merge inside if st… (compare)

  • Mar 01 17:56
    cal101 synchronize #471
  • Mar 01 17:53
    cal101 opened #471
  • Mar 01 05:02
    Fabrice-TIERCELIN commented #470
  • Mar 01 04:59

    Fabrice-TIERCELIN on master

    Restore formatting (compare)

  • Mar 01 04:52

    Fabrice-TIERCELIN on master

    add formatter configuration for… (compare)

  • Mar 01 04:52
    Fabrice-TIERCELIN closed #470
  • Feb 28 21:24
    cal101 opened #470
  • Feb 28 18:53
    Fabrice-TIERCELIN commented #469
  • Feb 28 18:33
    cal101 commented #469
Jean-Noël Rouvignac
@JnRouvignac
A bit tricky
And #172 is dangerous
It modifies semantics
And it is too hard to notice
Fabrice TIERCELIN
@Fabrice-TIERCELIN
Assign me #172
Luis Cruz
@luiscruz
Hi Jean-Noël!
Can you please review #213 ?
Jean-Noël Rouvignac
@JnRouvignac
Hi Luis
PR 213?
Luis Cruz
@luiscruz
yap
Jean-Noël Rouvignac
@JnRouvignac
OK, I can now see you've addressed the review comments
Yep I'll try to
Luis Cruz
@luiscruz
In order to fix PR #212 I need the method getAncestorOrNull that I’ve created on that one.
Jean-Noël Rouvignac
@JnRouvignac
it starts to be hard for me to keep up between yours PRs and Fabrice's :)
ok
Luis Cruz
@luiscruz
yea, I understand ;)
Jean-Noël Rouvignac
@JnRouvignac
OK there is a lot in this one
The rewrites are currently a bit blurred
it is hard to read when comes this level of rewriting
but I think I'll clean that up
I made several new comments
Please ping me once you'll have acted on them and pushed the new code for review
Luis Cruz
@luiscruz
ok
Luis Cruz
@luiscruz
ping :)
Luis Cruz
@luiscruz
I’ve fixed your code reviews. Let me know what is the next step
Jean-Noël Rouvignac
@JnRouvignac
Next step is tomorrow
:)
Luis Cruz
@luiscruz
deal! :D
Fabrice TIERCELIN
@Fabrice-TIERCELIN
Should I take #222?
Jean-Noël Rouvignac
@JnRouvignac
@Fabrice-TIERCELIN please do if you feel confident
be careful there are many corner cases here
methods (you can ignore parameters), fields, variables can be shadowed
etc.
This is pretty tough
maybe start small and provide a simple fix
then we'll take it forward from there
Jean-Noël Rouvignac
@JnRouvignac
@luiscruz I have looked at the PR and I have several problems with it
first of all mvn clean install fails
for the rest, maybe this is not the best medium here to explain them
last, reviewing PRs on github is not great IMO :(
but anyway we'll get through this
Jean-Noël Rouvignac
@JnRouvignac
What I mean is that there is more work needed before I can merge it
Luis Cruz
@luiscruz
Hi
I’ll see that now
Jean-Noël Rouvignac
@JnRouvignac
hello
I'll speak to you on hangout to avoid polluting this channel with remarks towards the PR
if you log in
:)
Luis Cruz
@luiscruz
are we talking about JnRouvignac/AutoRefactor#226?
Jean-Noël Rouvignac
@JnRouvignac
yes