Can you please review #213 ?
PR 213?
Yep I'll try to
ok
The rewrites are currently a bit blurred
it is hard to read when comes this level of rewriting
but I think I'll clean that up
I made several new comments
Please ping me once you'll have acted on them and pushed the new code for review
:)
be careful there are many corner cases here
methods (you can ignore parameters), fields, variables can be shadowed
etc.
This is pretty tough
maybe start small and provide a simple fix
then we'll take it forward from there
first of all
mvn clean install fails
for the rest, maybe this is not the best medium here to explain them
last, reviewing PRs on github is not great IMO :(
but anyway we'll get through this
I’ll see that now
I'll speak to you on hangout to avoid polluting this channel with remarks towards the PR
if you log in
:)
we can speak on hangout
when are you available?