ok
The rewrites are currently a bit blurred
it is hard to read when comes this level of rewriting
but I think I'll clean that up
I made several new comments
Please ping me once you'll have acted on them and pushed the new code for review
:)
be careful there are many corner cases here
methods (you can ignore parameters), fields, variables can be shadowed
etc.
This is pretty tough
maybe start small and provide a simple fix
then we'll take it forward from there
first of all
mvn clean install fails
for the rest, maybe this is not the best medium here to explain them
last, reviewing PRs on github is not great IMO :(
but anyway we'll get through this
I’ll see that now
I'll speak to you on hangout to avoid polluting this channel with remarks towards the PR
if you log in
:)
we can speak on hangout
when are you available?
no need to call IMO
You may have noticed that I did some autorefactor related stuff lately. I am repeating an experiment executing bulk autorefactoring on a >16k classes legacy application to investigate the result. Autorefactorings are grouped. Execution is done via jenkins pipeline doing git commits between refactoring groups. The outcome is pushed and automatic testing is done. The line coverage is 43% so some semantic testing is done. @Fabrice-TIERCELIN fixed a lot of bugs lately and so i was able to enable most of the refactorings and the code compiles and all tests pass now.
Doing bulk refactorings and reviewing bulk results gives me a different view on the results of refactorings. Most improve quality some don't. Autorefactor plugin is like a closed app. Very useful even for beginners. Autorefactor cli is meant for the professional who needs some tweaking options. I will do obvious filters like excluding classes but I am reaching the point where i want to disable or tweak/disable parts of refactorings. I want to avoid forking and would like to discuss options to proceed.
Hi @JnRouvignac I am working on a legacy code base that has tons of issues that need to refactored. I came across AutoRefactor and installed the eclipse plugin in 2020-06. However, refactorings are not working. I saw on GitHub project page that AutoRefactor is now being merged into Eclipse. Has that been done already? I could not find anything in the latest Eclipse IDE. Any help in getting this up and running would be great.